Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[16.0][FIX] base_geoengine: name and order of parameters of the gist index creation function #350

Merged
merged 1 commit into from
Feb 11, 2025
Merged

[16.0][FIX] base_geoengine: name and order of parameters of the gist index creation function #350

merged 1 commit into from
Feb 11, 2025

Conversation

sersanchus
Copy link

It's been a while since spatial indexes could not be created on geographic fields. This commit correctly uses the nomenclature of the functions and the parameters to use.
It also correctly creates indexes when the column is newly created and not updated.

@sersanchus sersanchus changed the title [16.0][FIX] base_geonegine: name and order of parameters of the gist index creation functionFix name and order of parameters of the gist index creation function [16.0][FIX] base_geoengine: name and order of parameters of the gist index creation function Jan 10, 2024
@github-actions GitHub Actions
Copy link

There hasn't been any activity on this pull request in the past 4 months, so it has been marked as stale and it will be closed automatically if no further activity occurs in the next 30 days.
If you want this PR to never become stale, please ask a PSC member to apply the "no stale" label.

@github-actions github-actions bot added the stale PR/Issue without recent activity, it'll be soon closed automatically. label May 12, 2024
@rafalkrupinski
Copy link

could someone have a look at this pls?

@github-actions github-actions bot removed the stale PR/Issue without recent activity, it'll be soon closed automatically. label May 19, 2024
@github-actions GitHub Actions
Copy link

There hasn't been any activity on this pull request in the past 4 months, so it has been marked as stale and it will be closed automatically if no further activity occurs in the next 30 days.
If you want this PR to never become stale, please ask a PSC member to apply the "no stale" label.

@github-actions github-actions bot added the stale PR/Issue without recent activity, it'll be soon closed automatically. label Sep 22, 2024
peluko00
peluko00 approved these changes Sep 30, 2024
View reviewed changes
Copy link

@peluko00 peluko00 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code review, LGTM

@github-actions github-actions bot removed the stale PR/Issue without recent activity, it'll be soon closed automatically. label Oct 6, 2024
@github-actions GitHub Actions
Copy link

github-actions bot commented Feb 9, 2025

There hasn't been any activity on this pull request in the past 4 months, so it has been marked as stale and it will be closed automatically if no further activity occurs in the next 30 days.
If you want this PR to never become stale, please ask a PSC member to apply the "no stale" label.

@github-actions github-actions bot added the stale PR/Issue without recent activity, it'll be soon closed automatically. label Feb 9, 2025
@peluko00
Copy link

Can you rebase please @sersanchus?

@sersanchus
Copy link
Author

Can you rebase please @sersanchus?

Done.

@peluko00
Copy link

Can you review please @max3903 ?

@max3903 max3903 added this to the 16.0 milestone Feb 10, 2025
@max3903 max3903 added bug needs review and removed stale PR/Issue without recent activity, it'll be soon closed automatically. labels Feb 10, 2025
@peluko00
Copy link

It's ready to merge @max3903 ?

@max3903
Copy link
Member

max3903 commented Feb 11, 2025

/ocabot merge patch

@OCA-git-bot
Copy link
Contributor

Hey, thanks for contributing! Proceeding to merge this for you.
Prepared branch 16.0-ocabot-merge-pr-350-by-max3903-bump-patch, awaiting test results.

@OCA-git-bot
Copy link
Contributor

Congratulations, your PR was merged at c3219b8. Thanks a lot for contributing to OCA. ❤️

@OCA-git-bot OCA-git-bot merged commit aa2e9ad into OCA:16.0 Feb 11, 2025
6 of 7 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@max3903 max3903 max3903 approved these changes

@peluko00 peluko00 peluko00 approved these changes

Assignees
No one assigned
Labels
approved bug merged 🎉 needs review
Projects
None yet
Milestone
16.0
Development

Successfully merging this pull request may close these issues.
6 participants
@sersanchus @rafalkrupinski @peluko00 @max3903 @OCA-git-bot @ssancho-hg