Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[17.0][MIG] hr_employee_age: Migration to 17.0. #1406

Open
wants to merge 22 commits into
base: 17.0
Choose a base branch
from
Open

[17.0][MIG] hr_employee_age: Migration to 17.0. #1406

wants to merge 22 commits into from

Conversation

Vang-NguyenPhu
Copy link

No description provided.

saltonmassally and others added 21 commits December 6, 2024 16:55
@saltonmassally @Vang-NguyenPhu
[ADD] hr_employee_age
07bf7b1
@saltonmassally @Vang-NguyenPhu
implementation update
22fb7dd
@pedrobaeza @Vang-NguyenPhu
[MIG] Make modules uninstallable
2b5acaf
@sbidoul @Vang-NguyenPhu
[FIX] remove en.po that was erroneously created by transbot
b7eddbf
@pedrobaeza @Vang-NguyenPhu
[MIG] Rename manifest files
2041291
@Yopli2k @Vang-NguyenPhu
[MIG] 10.0 Porting hr_employee_age (OCA#293)
c5a1c2b
@Trivedi-Vacha-SerpentCS @Vang-NguyenPhu
[Mig][IMP]hr_employee_age:Migration to 11.0.
08185e6
@mclaeysb @Vang-NguyenPhu
[REF] hr_employee_age: blacken
3bd7e2c
@mclaeysb @Vang-NguyenPhu
[MIG] hr_employee_age
88d1b99
@mclaeysb @Vang-NguyenPhu
[FIX] hr_employee_age: fix tests, fix readme
d9334e3 
Updated by "Update PO files to match POT (msgmerge)" hook in Weblate.

Translation: hr-12.0/hr-12.0-hr_employee_age
Translate-URL: https://translation.odoo-community.org/projects/hr-12-0/hr-12-0-hr_employee_age/
@Saran440 @Vang-NguyenPhu
[IMP] hr_employee_age: black, isort
609e94b
@Saran440 @Vang-NguyenPhu
[13.0][MIG] hr_employee_age
cdc6a9a
@komsan-S @Vang-NguyenPhu
[MIG] hr_employee_age : Migration to 14.0
fd20344
@pegonzalezspesol @Vang-NguyenPhu
[MIG] hr_employee_age: Migration to 15.0
1a08fd2
@destroT @Vang-NguyenPhu
[MIG] hr_employee_age: Migration to 16.0
a6fdb7a
@Vang-NguyenPhu
[UPD] Update hr_employee_age.pot
ef7d894
@OCA-git-bot @Vang-NguyenPhu
[UPD] README.rst
95ea919
@weblate @Vang-NguyenPhu
Update translation files
9c8e5d4 
Updated by "Update PO files to match POT (msgmerge)" hook in Weblate.

Translation: hr-16.0/hr-16.0-hr_employee_age
Translate-URL: https://translation.odoo-community.org/projects/hr-16-0/hr-16-0-hr_employee_age/
@victoralmau @Vang-NguyenPhu
[IMP] hr_employee_age: Add groups="hr.group_hr_user" to age field acc…
5b0aaac 
…ording to birthday field definition

TT43046
@OCA-git-bot @Vang-NguyenPhu
hr_employee_age 16.0.1.0.1
f02c7cb
@OCA-git-bot @Vang-NguyenPhu
[UPD] README.rst
40c0909
@Vang-NguyenPhu Vang-NguyenPhu mentioned this pull request Dec 6, 2024
Open
22 tasks
@CoraVanga
Copy link

LGTM

@huan-tq
Copy link

huan-tq commented Dec 6, 2024

Useful function!

hitrosol
hitrosol approved these changes Dec 8, 2024
View reviewed changes
Copy link

@hitrosol hitrosol left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@OCA-git-bot
Copy link
Contributor

This PR has the approved label and has been created more than 5 days ago. It should therefore be ready to merge by a maintainer (or a PSC member if the concerned addon has no declared maintainer). 🤖

cuongnmtm
cuongnmtm suggested changes Dec 13, 2024
View reviewed changes
Copy link

@cuongnmtm cuongnmtm left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just a minor change for the version.
You should add the prefix [17.0] to the PR title.

hr_employee_age/__manifest__.py Outdated Show resolved Hide resolved
@Vang-NguyenPhu Vang-NguyenPhu changed the title [MIG] hr_employee_age: Migration to 17.0. [17.0][MIG] hr_employee_age: Migration to 17.0. Dec 13, 2024
@Vang-NguyenPhu Vang-NguyenPhu force-pushed the 17.0-mig-hr_employee_age branch 2 times, most recently from 69c8014 to 0dd25f9 Compare December 13, 2024 09:42
@Vang-NguyenPhu Vang-NguyenPhu force-pushed the 17.0-mig-hr_employee_age branch from 0dd25f9 to 553b2e5 Compare December 13, 2024 09:50
victoralmau
victoralmau suggested changes Dec 18, 2024
View reviewed changes
hr_employee_age/models/hr_employee.py Outdated Show resolved Hide resolved
hr_employee_age/tests/test_hr_employee.py Outdated Show resolved Hide resolved
victoralmau
victoralmau suggested changes Dec 18, 2024
View reviewed changes
Copy link
Member

@victoralmau victoralmau left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code and functional review.

@Vang-NguyenPhu Vang-NguyenPhu force-pushed the 17.0-mig-hr_employee_age branch from 553b2e5 to 8a09cac Compare December 20, 2024 09:48
@Vang-NguyenPhu Vang-NguyenPhu force-pushed the 17.0-mig-hr_employee_age branch from 8a09cac to 0cabf36 Compare December 20, 2024 09:51
@OCA-git-bot
Copy link
Contributor

This PR has the approved label and has been created more than 5 days ago. It should therefore be ready to merge by a maintainer (or a PSC member if the concerned addon has no declared maintainer). 🤖

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@cuongnmtm cuongnmtm cuongnmtm approved these changes

@hitrosol hitrosol hitrosol approved these changes

@victoralmau victoralmau victoralmau approved these changes

@dreispt dreispt dreispt approved these changes

Assignees
No one assigned
Labels
approved ready to merge
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.