[17.0][FIX] hr_employee_calendar_planning: Change test employee name #1409
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This test collides with the dms module. In this test an employee is being created with a name that already exists in another test. The employee's file directory is created with the name of this employee. As there is already an employee with that name, there is already a directory with that name and this is what causes the error. As the probability of 2 employees with the same name coinciding in the same company is very small, instead of intervening in the logic for the creation of the employee's directory, we change the name of the employee in the test so that it does not cause the error when executing this module together with dms. In the hypothetical case of two employees with the same name within the same company, we would have to resort to using other tools, either by creating an additional module to modify the logic and add an employee identifier to the name of the directory. TT52110
|
Hi @pedrobaeza, @victoralmau, |
dreispt
approved these changes
Dec 10, 2024
victoralmau
approved these changes
Dec 10, 2024
|
What a great day to merge this nice PR. Let's do it! |
|
Congratulations, your PR was merged at 733a9d9. Thanks a lot for contributing to OCA. ❤️ |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This test collides with the dms module. In this test an employee is being created with a name that already exists in another test. The employee's file directory is created with the name of this employee. As there is already an employee with that name, there is already a directory with that name and this is what causes the error. As the probability of 2 employees with the same name coinciding in the same company is very small, instead of intervening in the logic for the creation of the employee's directory, we change the name of the employee in the test so that it does not cause the error when executing this module together with dms.
In the hypothetical case of two employees with the same name within the same company, we would have to resort to using other tools, either by creating an additional module to modify the logic and add an employee identifier to the name of the directory.
Another option is to use the dms_field module.
cc @Tecnativa TT52110
@pedrobaeza @victoralmau please review