-
-
Notifications
You must be signed in to change notification settings - Fork 674
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[add] hr_employee_address_improved #357
Merged
feketemihai
merged 1 commit into
OCA:10.0
from
camptocamp:add-hr_employee_address_improved
Sep 12, 2017
Merged
[add] hr_employee_address_improved #357
feketemihai
merged 1 commit into
OCA:10.0
from
camptocamp:add-hr_employee_address_improved
Sep 12, 2017
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
simahawk
force-pushed
the
add-hr_employee_address_improved
branch
3 times, most recently
from
August 7, 2017 08:14
2e25f38
to
41dc5a2
Compare
gurneyalex
approved these changes
Aug 7, 2017
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
one tiny bitsy improvement suggested, but overall 👍
def post_init_hook(cr, pool): | ||
env = api.Environment(cr, SUPERUSER_ID, {}) | ||
partners_count = env['res.partner'].search_count([]) | ||
empls = env['hr.employee'].search([('address_home_id', '!=', False)]) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
can you add "active_test": False to the context of this search?
simahawk
force-pushed
the
add-hr_employee_address_improved
branch
from
August 7, 2017 09:35
41dc5a2
to
bcfba2f
Compare
leemannd
approved these changes
Sep 7, 2017
feketemihai
approved these changes
Sep 12, 2017
feketemihai
pushed a commit
to feketemihai/hr
that referenced
this pull request
Nov 14, 2017
nikul-serpentcs
pushed a commit
to nikul-serpentcs/hr
that referenced
this pull request
Jan 20, 2018
nikul-serpentcs
pushed a commit
to nikul-serpentcs/hr
that referenced
this pull request
Jan 20, 2018
Fix _onchange_employee() arguments OCA Transbot updated translations from Transifex OCA Transbot updated translations from Transifex [fix] `hr_employee_id` use deprecated `sequence.get_id()` (OCA#358) [add] hr_employee_address_improved (OCA#357) [ADD] hr_employee_category_parent (OCA#366) * [ADD] hr_employee_category_parent * [IMP] human readable name [UPD] addons table in README.md [ADD] setup.py [ADD] hr_holiday_notify_employee_manager: Notify by mail the manager of the employee requesting the leave. (OCA#331) OCA Transbot updated translations from Transifex [MIG] hr_holidays_notify_employee_manager: Migration to 10.0 [10.0][ADD] hr_holidays_settings [FIX] add company_id in view hr_worked_days_from_timesheet OCA Transbot updated translations from Transifex [ADD] hr_worked_days_from_timesheet v10 [IMP] Improved code [IMP] Improved code [MIG] hr_employee_legacy_id [FIX] update header [UPD] addons table in README.md [ADD] setup.py [MIG] 10.0 porting hr_skill [UPD] Move Skills menu into HR configuration and add widget m2m_tags in employee form view and add to contributors list [UPD] Update copyright [IMP] Add unit test to test nam_get function on hr_skill Refactor code for pep-8 Add group to Skill menu Fix imports & lost things in pull/300 [UPD] addons table in README.md [ADD] setup.py [MIG][9.0] hr_expense_analytic_plans module OCA Transbot updated translations from Transifex [MIG] hr_expense_analytic_distribution: Migration to 10.0 [REM] hr_expense_analytic_plans: Replaced by hr_expense_analytic_distribution [UPD] addons table in README.md [ADD] setup.py [FIX] Fix issue with 2 invoices on the same partner and the same total amount (OCA#237) On the same expense, when we have 2 or more lines with different invoices, and each invoices have the same total amount, reconcile is not possible. The fix is to exclude reconcile account.move.line, and the first time if we have more than one line to reconcile on the same amount, we keep the first. OCA Transbot updated translations from Transifex [MIG] hr_expense_invoice: Migration to 10.0 [UPD] addons table in README.md [ADD] setup.py Update view in holidays status, to remove duplicated field on company_id. (OCA#405) [FIX][hr_holidays_settings] Make 'Leave Types' view accessible (OCA#408) [MIG] hr_holidays_meeting_name (OCA#334) * Add hr_holidays_meeting_name module * Typo * [MIG] hr_holidays_meeting_name * [CHG] According upstream changes. * [CHG] Rewrite hr_holidays_meeting_name witout Odoo patch. Add tests. * [CHG] Ignore .eggs directory. [UPD] addons table in README.md OCA Transbot updated translations from Transifex [FIX] hr_employee_seniority permission problem normally hr.contract are only readable by Employee / Officer and Employee / Managers, not basic employees => we need compute_sudo to compute the employee's seniority otherwise the employee cannot display his own record. [FIX] employee seniority tests [UPD] addons table in README.md [FIX] holiday meeting name tests Change the date to avoid conflicts with the demo data of hr_holidays. [IMP] hr_public_holidays: Improve README [FIX] employee seniority search crash [imp] hr_employee_id: ease override w/ custom ID [UPD] addons table in README.md
sambarros
pushed a commit
to sambarros/hr
that referenced
this pull request
Jul 26, 2018
BSSFL-485: Custom sale order report (add field note)
i-vyshnevska
pushed a commit
to i-vyshnevska/hr
that referenced
this pull request
Mar 5, 2019
i-vyshnevska
pushed a commit
to i-vyshnevska/hr
that referenced
this pull request
Mar 12, 2019
quentingigon
pushed a commit
to quentingigon/hr
that referenced
this pull request
Oct 11, 2019
Mraimou
pushed a commit
to camptocamp/hr
that referenced
this pull request
Nov 25, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Excerpt from README:
When the HR modules are enabled and we have 1 employee for each users,
some parts of the UI become confusing because
we have several partners for the same person.
Assumption: we would like to exclude home addresses
from the list of available partners in m2o and m2m fields.
/cc @gurneyalex