Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[14.0]REF] Atualização da bibliotecas do Pre-commit: Método Super sem Parâmetros #2750

Conversation

mbcosta
Copy link
Contributor

@mbcosta mbcosta commented Oct 25, 2023

Method Super without parameters.

PR simples apesar de alterar diversos arquivos e módulos não deve afetar nenhum código, o método Super pode ser chamado sem Parâmetros.

Eu estou vendo a possibilidade de atualizar as bibliotecas do Pre-Commit no PR #2747 ( isso ainda está em debate por existir uma forma automatizada de fazer essa atualização, mas essa alteração já antecipa o que vai precisar ser feito quando houver a atualização ), essa validação está sendo feita nas recentes versões das bibliotecas do pre-commit https://github.com/OCA/l10n-brazil/actions/runs/6643339050/job/18050180768?pr=2747#step:7:63

cc @rvalyi @renatonlima @marcelsavegnago @mileo

… necessary for the new version of pre-commit.
@OCA-git-bot
Copy link
Contributor

Hi @ygcarvalh, @rvalyi, @luismalta, @felipezago, @lfdivino, @antoniospneto, @gabrielcardoso21, @mileo, @marcelsavegnago, @hendixcosta, @felipemotter, @renatonlima,
some modules you are maintaining are being modified, check this out!

@rvalyi
Copy link
Member

rvalyi commented Oct 26, 2023

/ocabot merge patch

@OCA-git-bot
Copy link
Contributor

On my way to merge this fine PR!
Prepared branch 14.0-ocabot-merge-pr-2750-by-rvalyi-bump-patch, awaiting test results.

OCA-git-bot added a commit that referenced this pull request Oct 26, 2023
Signed-off-by rvalyi
@OCA-git-bot
Copy link
Contributor

@rvalyi your merge command was aborted due to failed check(s), which you can inspect on this commit of 14.0-ocabot-merge-pr-2750-by-rvalyi-bump-patch.

After fixing the problem, you can re-issue a merge command. Please refrain from merging manually as it will most probably make the target branch red.

@rvalyi
Copy link
Member

rvalyi commented Oct 27, 2023

vamos ver se a falha no merge não foi ligada a isso OCA/oca-addons-repo-template#214

@rvalyi
Copy link
Member

rvalyi commented Oct 27, 2023

vamos ver se a falha no merge não foi ligada a isso OCA/oca-addons-repo-template#214

deu certo mesmo.

/ocabot merge patch

@OCA-git-bot
Copy link
Contributor

On my way to merge this fine PR!
Prepared branch 14.0-ocabot-merge-pr-2750-by-rvalyi-bump-patch, awaiting test results.

@OCA-git-bot OCA-git-bot merged commit f90615a into OCA:14.0 Oct 27, 2023
5 of 7 checks passed
@OCA-git-bot
Copy link
Contributor

Congratulations, your PR was merged at 11d667f. Thanks a lot for contributing to OCA. ❤️

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants