[12.0][ADD] payment_payfip #285
Conversation
ivantodorovich
force-pushed
the
12.0-add-payfip
branch
4 times, most recently
from
95efbd4 to
e6256cf
Compare
|
CI is broken because of other modules. |
|
@ivantodorovich Why this addon is not merged ? |
ivantodorovich
force-pushed
the
12.0-add-payfip
branch
from
e6256cf to
bef9249
Compare
|
rebased on top of your cleaning @legalsylvain 🙏 this is green now |
|
General question :
|
It's a french module, but not a localization module, so I wouldn't add
I kindof followed what's been done here: https://github.com/OCA/l10n-spain/tree/14.0/payment_redsys |
ivantodorovich
force-pushed
the
12.0-add-payfip
branch
from
bef9249 to
57eb11e
Compare
ivantodorovich
force-pushed
the
12.0-add-payfip
branch
from
57eb11e to
f2f562f
Compare
| To use this module you'll need to get your **Nº Client Payfip** | ||
|
|
||
| You can do so by following the steps described on | ||
| `the official website <https://www.payfip.gouv.fr/>`_. |
There was a problem hiding this comment.
@ivantodorovich
Maybe that page can be used too for the documentation :
https://www.collectivites-locales.gouv.fr/finances-locales/offre-de-paiement-en-ligne-payfip
|
|
||
| @api.multi | ||
| def payfip_get_form_action_url(self): | ||
| return "https://www.tipi.budget.gouv.fr/tpa/paiement.web" |
There was a problem hiding this comment.
@ivantodorovich
The url has changed : https://www.payfip.gouv.fr/tpa/paiementws.web
There was a problem hiding this comment.
Maybe an irconfig parameter could be great here, if the url change sometimes.
(Not a blocking point, can be done in a second step)
There was a problem hiding this comment.
Yes, no chance for us, they changed the URL the same year we started to work on the addon :/
| self.assertEqual(len(data_set), 1) | ||
| self.assertEqual( | ||
| data_set[0].get("data-action-url"), | ||
| "https://www.tipi.budget.gouv.fr/tpa/paiement.web", |
There was a problem hiding this comment.
@ivantodorovich
That url too : https://www.payfip.gouv.fr/tpa/paiementws.web
| or '' | ||
| ), | ||
| "urlcl": urls.url_join(self.get_base_url(), "/payment/payfip/return"), | ||
| "saisie": "X" if self.environment == "prod" else "T", |
There was a problem hiding this comment.
3 values are needed here :
- T for Test
- X for activation (when test are ok)
- W for real payment > I don't see the W value in the code.
|
@ivantodorovich |
|
There hasn't been any activity on this pull request in the past 4 months, so it has been marked as stale and it will be closed automatically if no further activity occurs in the next 30 days. |
github-actions
bot
added
the
stale
This module adds the payment acquirer PayFIP.