[16.0][MIG] l10n_fr_department and l10n_fr_department_oversea #399
Conversation
|
Requires #398 |
|
As it is a computed field, a migration script is not required, but it could save same time during migration. |
Indeed. But a little weird to raise the recompute of an existing field. And on res.partner table, it can take time. Better to use rename_fields of openupgradelib. |
| # In v16, this field was renamed from department_id to country_department_id | ||
| # to avoid a field name conflict with the module partner_contact_department | ||
| # from https://github.com/OCA/partner-contact |
There was a problem hiding this comment.
These comments belong to the commit message or to the PR itself.
They're only useful when reviewing/analyzing changes from previous code.
But they have no use at all in the present/future code
| @@ -1,6 +1,6 @@ | |||
| <?xml version="1.0" encoding="utf-8" ?> | |||
| <!-- | |||
| Copyright 2013-2020 GRAP (http://www.grap.coop) | |||
| Copyright 2013-2022 GRAP (http://www.grap.coop) | |||
There was a problem hiding this comment.
FTR you could save yourself from ever having to update these Copyright lines.
When reading the copyright comment, the dates are to be read as "starting.." (and legally it'll be valid for up to 70 years from that point)
eg: Copyright 2013 GRAP (http://www.grap.coop)
Means it's copyright is valid from 2013 to 2083.
There's no need at all to put an end date, that end up being just noisy diffs, and it's totally useless.
https://stackoverflow.com/questions/2390230/do-copyright-dates-need-to-be-updated
alexis-via
force-pushed
the
16.0-mig-l10n_fr_department
branch
from
7d8a28e to
28b12ee
Compare
|
I added and tested the migration script. Requires a recent version of openupgradelib to support the new system for translations. |
…epartment (Division of states in France)
…e information on all files. [ADD] Sql constraint on res_country_department.code field.
…for res_country_department model.
In order to get visibility on https://www.odoo.com/apps the OCA board has decided to add the OCA as author of all the addons maintained as part of the association.
Add Akretion in author list
Updated by "Update PO files to match POT (msgmerge)" hook in Weblate. Translation: l10n-france-14.0/l10n-france-14.0-l10n_fr_department Translate-URL: https://translation.odoo-community.org/projects/l10n-france-14-0/l10n-france-14-0-l10n_fr_department/
Unfuck the "Donald Trump" pull request: this is the real/serious work made by the anti-Donald Trump squad.
On install, ``_compute_department()`` method is triggered by the `post-init-hook` on every existing French partners, archived ones as well. This commit tries to improve performances by grouping partners by zipcode (if valid) to avoid huge loading times when installing the module.
alexis-via
force-pushed
the
16.0-mig-l10n_fr_department
branch
from
28b12ee to
d8c8637
Compare
|
/ocabot merge nobump |
|
What a great day to merge this nice PR. Let's do it! |
|
Congratulations, your PR was merged at 9624f52. Thanks a lot for contributing to OCA. ❤️ |
|
/ocabot migration l10n_fr_department |
|
/ocabot migration l10n_fr_department_oversea |
fix bug #384 : field department_id on res.partner has been renamed to country_department_id