[11.0][IMP] l10n_nl_xaf_auditfile_export: ease extensions #182
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tarteo
suggested changes
Jul 24, 2018
|
Yes, this module does not contain tests yes. I could add some tests in this PR. |
tarteo
approved these changes
Jul 26, 2018
RoelAdriaans
approved these changes
Jul 26, 2018
astirpe
force-pushed
the
11_imp_l10n_nl_xaf_auditfile_export
branch
from
f3229fc to
caf2725
Compare
astirpe
changed the title
1 task
StefanRijnhart
approved these changes
Jul 31, 2018
|
Thanks! |
astirpe
added a commit
to onesteinbv/l10n-netherlands
that referenced
this pull request
Oct 1, 2018
* Extract method to ease extensions * Add basic tests * Make filename field stored + code review * Add group in view for extra options
astirpe
added a commit
to onesteinbv/l10n-netherlands
that referenced
this pull request
Oct 18, 2018
* Extract method to ease extensions * Add basic tests * Make filename field stored + code review * Add group in view for extra options
hbrunn
pushed a commit
that referenced
this pull request
Nov 29, 2018
* Extract method to ease extensions * Add basic tests * Make filename field stored + code review * Add group in view for extra options
thomaspaulb
pushed a commit
to sunflowerit/l10n-netherlands
that referenced
this pull request
Dec 3, 2019
* Extract method to ease extensions * Add basic tests * Make filename field stored + code review * Add group in view for extra options
thomaspaulb
pushed a commit
to sunflowerit/l10n-netherlands
that referenced
this pull request
Dec 18, 2019
* Extract method to ease extensions * Add basic tests * Make filename field stored + code review * Add group in view for extra options
astirpe
added a commit
to onesteinbv/l10n-netherlands
that referenced
this pull request
Jan 17, 2020
* Extract method to ease extensions * Add basic tests * Make filename field stored + code review * Add group in view for extra options
astirpe
added a commit
to onesteinbv/l10n-netherlands
that referenced
this pull request
Feb 14, 2020
* Extract method to ease extensions * Add basic tests * Make filename field stored + code review * Add group in view for extra options
astirpe
added a commit
to onesteinbv/l10n-netherlands
that referenced
this pull request
Mar 19, 2020
* Extract method to ease extensions * Add basic tests * Make filename field stored + code review * Add group in view for extra options
jeroen-vet
pushed a commit
to jeroen-vet/l10n-netherlands
that referenced
this pull request
Feb 25, 2021
* Extract method to ease extensions * Add basic tests * Make filename field stored + code review * Add group in view for extra options
NL66278
pushed a commit
to Therp/l10n-netherlands
that referenced
this pull request
Oct 11, 2022
* Extract method to ease extensions * Add basic tests * Make filename field stored + code review * Add group in view for extra options
astirpe
added a commit
to onesteinbv/l10n-netherlands
that referenced
this pull request
Jan 17, 2023
* Extract method to ease extensions * Add basic tests * Make filename field stored + code review * Add group in view for extra options
NL66278
pushed a commit
to Therp/l10n-netherlands
that referenced
this pull request
Feb 22, 2023
* Extract method to ease extensions * Add basic tests * Make filename field stored + code review * Add group in view for extra options
Wodran14
pushed a commit
to DynAppsNV/l10n-netherlands
that referenced
this pull request
Mar 25, 2024
* Extract method to ease extensions * Add basic tests * Make filename field stored + code review * Add group in view for extra options
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
With this PR I'm proposing some small changes to ease the extention of
l10n_nl_xaf_auditfile_exportmodule._get_auditfile_template(), to allow to extend this module by modules making use of different qweb templates (forward port of [IMP][8.0] Extract method in l10n_nl_xaf_auditfile_export #78);auditfile_namestored, to allow the old generated exports to keep their original name;