-
-
Notifications
You must be signed in to change notification settings - Fork 56
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[14.0] l10n nl xaf audit file export reliability #388
base: 14.0
Are you sure you want to change the base?
[14.0] l10n nl xaf audit file export reliability #388
Conversation
7408750
to
efbd5b9
Compare
@NL66278 For clarity to other reviewers, could you edit the description of this issue and add a checkboxed list of PR's that you are forward-porting with this PR? Also, could you remove the first commit, because that one is already part of another PR. |
@thomaspaulb When the other PR's are merged, I could rebase this one. Or alternatively when this one is approved we can have all the improvements in one go. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Code review
9fd88aa
to
f6db79a
Compare
968ca92
to
46e9438
Compare
There hasn't been any activity on this pull request in the past 4 months, so it has been marked as stale and it will be closed automatically if no further activity occurs in the next 30 days. |
46e9438
to
7c4cd6f
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
it's unclear to me which problem this solves.
Then we have a database at hand which is very much specialized in locking things, so the correct way to prevent parallel execution would be something like
cr.execute(select id from xaf_auditfile_export where id=%s for update', (this.id,))
instead of some home brewed mechanism.
I like keeping failed auditfiles, but instead of a success flag I'd prefer introducing a state field [draft, done, fail] to be in line with other exports from this repo, like the vat export.
Finally, illegal characters should be fixed with a specialized widget for text output
Add more code to prevent server crashes and other problems due to auditfile export