Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[14.0] l10n nl xaf audit file export reliability #388

Open
wants to merge 7 commits into
base: 14.0
Choose a base branch
from

Conversation

NL66278
Copy link
Contributor

@NL66278 NL66278 commented Mar 22, 2023

Add more code to prevent server crashes and other problems due to auditfile export

@NL66278 NL66278 force-pushed the 14.0-l10n_nl_xaf_audit_file_export-reliability branch 4 times, most recently from 7408750 to efbd5b9 Compare March 23, 2023 10:13
@thomaspaulb
Copy link
Contributor

@NL66278 For clarity to other reviewers, could you edit the description of this issue and add a checkboxed list of PR's that you are forward-porting with this PR?

Also, could you remove the first commit, because that one is already part of another PR.

@NL66278 NL66278 changed the title [WIP][14.0] l10n nl xaf audit file export reliability [14.0] l10n nl xaf audit file export reliability Mar 30, 2023
@NL66278
Copy link
Contributor Author

NL66278 commented Mar 30, 2023

@thomaspaulb When the other PR's are merged, I could rebase this one. Or alternatively when this one is approved we can have all the improvements in one go.

Copy link

@ntsirintanis ntsirintanis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code review

@NL66278 NL66278 force-pushed the 14.0-l10n_nl_xaf_audit_file_export-reliability branch from 9fd88aa to f6db79a Compare March 30, 2023 14:02
@NL66278 NL66278 force-pushed the 14.0-l10n_nl_xaf_audit_file_export-reliability branch 2 times, most recently from 968ca92 to 46e9438 Compare May 8, 2023 13:18
Copy link

There hasn't been any activity on this pull request in the past 4 months, so it has been marked as stale and it will be closed automatically if no further activity occurs in the next 30 days.
If you want this PR to never become stale, please ask a PSC member to apply the "no stale" label.

@github-actions github-actions bot added the stale PR/Issue without recent activity, it'll be soon closed automatically. label Mar 24, 2024
@thomaspaulb thomaspaulb force-pushed the 14.0-l10n_nl_xaf_audit_file_export-reliability branch from 46e9438 to 7c4cd6f Compare March 25, 2024 08:20
Copy link
Member

@hbrunn hbrunn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

it's unclear to me which problem this solves.

Then we have a database at hand which is very much specialized in locking things, so the correct way to prevent parallel execution would be something like

cr.execute(select id from xaf_auditfile_export where id=%s for update', (this.id,))

instead of some home brewed mechanism.

I like keeping failed auditfiles, but instead of a success flag I'd prefer introducing a state field [draft, done, fail] to be in line with other exports from this repo, like the vat export.

Finally, illegal characters should be fixed with a specialized widget for text output

@NL66278 NL66278 added no stale Use this label to prevent the automated stale action from closing this PR/Issue. and removed stale PR/Issue without recent activity, it'll be soon closed automatically. labels Mar 25, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
no stale Use this label to prevent the automated stale action from closing this PR/Issue.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants