Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[RFC][ADD] l10n nl tax statement for V10 #70

Merged
merged 15 commits into from
Apr 20, 2017

Conversation

astirpe
Copy link
Member

@astirpe astirpe commented Mar 18, 2017

Introduction

Following the proposal of @StefanRijnhart discussed in PR #63, I would have to rewrite from scratch the module l10n_nl_tax_declaration_reporting in order to port it from V8 to V10. The proposal was to use an existing OCA module account_tax_balance as a basis for retrieving the tax lines to be included in the Dutch tax statement report. Indeed the module account_tax_balance does the job in an excellent way.

Here it is a proposal to implement a new module, that will replace l10n_nl_tax_declaration_reporting, introducing a different approach to generate and manage the BTW statements.

Why change the existing V8 approach

  • The Dutch BTW report on Odoo 8.0 uses the concept of Tax Code which is removed in Odoo V9 and later versions
  • Starting from Odoo V9, we base the Tax reports on the Tags concept; this implies a complete redesign of the module l10n_nl_tax_declaration_reporting being ported to V9 and V10

Status of the actual V8 module

  • The module l10n_nl_tax_declaration_reporting allows the user to create PDF documents containing the Dutch tax statement report based on a date range; the module doesn't provide anything else
  • A user who wants to just have a quick look to the report needs to generate and download a new PDF document; each time data in the system is added or changed, or just simply modifying the date range parameters, a new PDF document should be created and downloaded.

Analysis of needed functionalities

  • Would be nice a more handy and quick way to create and analyze the report, eg.: no need of creating a PDF document for just a quick analysis of the data
  • If a tax statement is created and sent to the Dutch Taxation Authority, It would be nice to have that statement stored in the system for future availability
  • If a tax statement is sent to the Dutch Taxation Authority and stored in the system, the document must be not changed nor updated; a concept of Status of the document (the 'statement' document) should be introduced
  • Adding the Status to the statements, introducing the concept of Workflow is consequential: a document can be modified in Draft, cannot be modified is already Posted
  • At the end the posted document should be transfered to the Dutch Taxation Authority that accepts the document in an electronic format (SBR/XBLR)
  • Some other accounting systems other than Odoo allow to include in the report being created, not only the ordinary data filtered by the selected date range, but also all the old data that was not included in the previous tax declarations; this is an useful feature that could be included in the new module

Features of the proposed new module

  • The new proposed module allows an accountant to create a Tax Statement document
  • The Tax Statement document accepts in input a date range and produces the report according with the Taxation Authority accepted format
  • The module uses the existing OCA module account_tax_balance as a base reporting engine
  • The calculation of the report is based on Tags set in the chart of tax accounts, like the default Dutch localization module containing the chart of accounts (module l10n_nl) which adds these tags automatically; the new module should be compliant with every chart of account having tags correctly configured
  • The Tax Statement document can be set to two (or more) states: the document in Draft can be updated, the document in Posted status cannot
  • The new module should be ready and open to every other improvements, so the idea is to keep it basic and simple for being extended easily

Future developments

  • The new module is predisposed for future implementation, eg.: exporting the tax statement in an SBR/XBLR format (see proposal XBRL : Taxonomy builder (proposal) edi#13, actually under development by Onestein)
  • Include in the report being created, not only the ordinary data filtered by the selected date range, but also all the old data that was not included in the previous tax declarations (work in progress...)

Request for Comments

Included with this RFC, I propose the module I'm actually developing.

Looking forward to read your comments!

@astirpe astirpe force-pushed the 10_add_l10n_nl_tax_statement branch from 6b16745 to 9316b97 Compare March 18, 2017 16:15
@jvOrsouw
Copy link

@astirpe Nice job! the module looks really nice and I enjoy the 'post' feature!

  • I noticed that tax 'l10n_nl.1_btw_ink_0_2' (BTW af te dragen verlegd (inkopen2)) with tag 'l10n_nl.tag_nl_34' (Voorbelasting (BTW) bis) was not shown in the report. The tax should be shown in categorie 5b.

@astirpe
Copy link
Member Author

astirpe commented Mar 20, 2017

@jvOrsouw thank you for the feedback! Should be fixed with the latest commit.

@nielsmiddeldorp
Copy link

👍

@jvOrsouw
Copy link

jvOrsouw commented Apr 7, 2017

please correct the calculation of 5a: this should be a the sum of 1a through 4b.

Copy link

@jvOrsouw jvOrsouw left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I've tested the taxes with debit and credit values for 5a and 5b (and the categories they consist of), and found that the taxes ends up in the right category, with the right amounts and that the sum of the taxes is calculated correctly in all cases.

👍

@hbrunn
Copy link
Member

hbrunn commented Apr 20, 2017

@nielsmiddeldorp @jvOrsouw please use the github review workflow next time, but I count your two thumbs up as approval and merge without reviewing myself

@hbrunn hbrunn merged commit c6bea7b into OCA:10.0 Apr 20, 2017
@astirpe astirpe deleted the 10_add_l10n_nl_tax_statement branch April 21, 2017 06:54
astirpe added a commit to onesteinbv/l10n-netherlands that referenced this pull request Dec 2, 2017
* Add module l10n_nl_tax_statement

* Update oca_dependencies and flake8

* Developing module

* Decoupled from l10n_nl + added config feature

* Fix missing tag (Voorbelasting (BTW) bis)

* Add printable PDF report

* Add onchange for filling statement name

* Update layout

* Add tests

* Set postgres V9.2 for running tests with date_range

* Add nl.po translation file

* Fix 5a sum

* Update domain according with updated account_tax_balance

* Fix calculation of lines + minor review

* Update steps regarding Usage in README.rst
hbrunn pushed a commit that referenced this pull request Jan 9, 2018
* Add module l10n_nl_tax_statement

* Update oca_dependencies and flake8

* Developing module

* Decoupled from l10n_nl + added config feature

* Fix missing tag (Voorbelasting (BTW) bis)

* Add printable PDF report

* Add onchange for filling statement name

* Update layout

* Add tests

* Set postgres V9.2 for running tests with date_range

* Add nl.po translation file

* Fix 5a sum

* Update domain according with updated account_tax_balance

* Fix calculation of lines + minor review

* Update steps regarding Usage in README.rst
astirpe added a commit to onesteinbv/l10n-netherlands that referenced this pull request Oct 4, 2018
* Add module l10n_nl_tax_statement

* Update oca_dependencies and flake8

* Developing module

* Decoupled from l10n_nl + added config feature

* Fix missing tag (Voorbelasting (BTW) bis)

* Add printable PDF report

* Add onchange for filling statement name

* Update layout

* Add tests

* Set postgres V9.2 for running tests with date_range

* Add nl.po translation file

* Fix 5a sum

* Update domain according with updated account_tax_balance

* Fix calculation of lines + minor review

* Update steps regarding Usage in README.rst
astirpe added a commit to onesteinbv/l10n-netherlands that referenced this pull request Oct 18, 2018
* Add module l10n_nl_tax_statement

* Update oca_dependencies and flake8

* Developing module

* Decoupled from l10n_nl + added config feature

* Fix missing tag (Voorbelasting (BTW) bis)

* Add printable PDF report

* Add onchange for filling statement name

* Update layout

* Add tests

* Set postgres V9.2 for running tests with date_range

* Add nl.po translation file

* Fix 5a sum

* Update domain according with updated account_tax_balance

* Fix calculation of lines + minor review

* Update steps regarding Usage in README.rst
hbrunn pushed a commit that referenced this pull request Jan 28, 2019
* Add module l10n_nl_tax_statement

* Update oca_dependencies and flake8

* Developing module

* Decoupled from l10n_nl + added config feature

* Fix missing tag (Voorbelasting (BTW) bis)

* Add printable PDF report

* Add onchange for filling statement name

* Update layout

* Add tests

* Set postgres V9.2 for running tests with date_range

* Add nl.po translation file

* Fix 5a sum

* Update domain according with updated account_tax_balance

* Fix calculation of lines + minor review

* Update steps regarding Usage in README.rst
astirpe added a commit to onesteinbv/l10n-netherlands that referenced this pull request Oct 10, 2019
* Add module l10n_nl_tax_statement

* Update oca_dependencies and flake8

* Developing module

* Decoupled from l10n_nl + added config feature

* Fix missing tag (Voorbelasting (BTW) bis)

* Add printable PDF report

* Add onchange for filling statement name

* Update layout

* Add tests

* Set postgres V9.2 for running tests with date_range

* Add nl.po translation file

* Fix 5a sum

* Update domain according with updated account_tax_balance

* Fix calculation of lines + minor review

* Update steps regarding Usage in README.rst
astirpe added a commit to onesteinbv/l10n-netherlands that referenced this pull request Oct 21, 2019
* Add module l10n_nl_tax_statement

* Update oca_dependencies and flake8

* Developing module

* Decoupled from l10n_nl + added config feature

* Fix missing tag (Voorbelasting (BTW) bis)

* Add printable PDF report

* Add onchange for filling statement name

* Update layout

* Add tests

* Set postgres V9.2 for running tests with date_range

* Add nl.po translation file

* Fix 5a sum

* Update domain according with updated account_tax_balance

* Fix calculation of lines + minor review

* Update steps regarding Usage in README.rst
astirpe added a commit to onesteinbv/l10n-netherlands that referenced this pull request Feb 26, 2020
* Add module l10n_nl_tax_statement

* Update oca_dependencies and flake8

* Developing module

* Decoupled from l10n_nl + added config feature

* Fix missing tag (Voorbelasting (BTW) bis)

* Add printable PDF report

* Add onchange for filling statement name

* Update layout

* Add tests

* Set postgres V9.2 for running tests with date_range

* Add nl.po translation file

* Fix 5a sum

* Update domain according with updated account_tax_balance

* Fix calculation of lines + minor review

* Update steps regarding Usage in README.rst
astirpe added a commit to onesteinbv/l10n-netherlands that referenced this pull request Mar 23, 2020
* Add module l10n_nl_tax_statement

* Update oca_dependencies and flake8

* Developing module

* Decoupled from l10n_nl + added config feature

* Fix missing tag (Voorbelasting (BTW) bis)

* Add printable PDF report

* Add onchange for filling statement name

* Update layout

* Add tests

* Set postgres V9.2 for running tests with date_range

* Add nl.po translation file

* Fix 5a sum

* Update domain according with updated account_tax_balance

* Fix calculation of lines + minor review

* Update steps regarding Usage in README.rst
astirpe added a commit to onesteinbv/l10n-netherlands that referenced this pull request Jul 30, 2020
* Add module l10n_nl_tax_statement

* Update oca_dependencies and flake8

* Developing module

* Decoupled from l10n_nl + added config feature

* Fix missing tag (Voorbelasting (BTW) bis)

* Add printable PDF report

* Add onchange for filling statement name

* Update layout

* Add tests

* Set postgres V9.2 for running tests with date_range

* Add nl.po translation file

* Fix 5a sum

* Update domain according with updated account_tax_balance

* Fix calculation of lines + minor review

* Update steps regarding Usage in README.rst
astirpe added a commit to onesteinbv/l10n-netherlands that referenced this pull request Oct 21, 2020
* Add module l10n_nl_tax_statement

* Update oca_dependencies and flake8

* Developing module

* Decoupled from l10n_nl + added config feature

* Fix missing tag (Voorbelasting (BTW) bis)

* Add printable PDF report

* Add onchange for filling statement name

* Update layout

* Add tests

* Set postgres V9.2 for running tests with date_range

* Add nl.po translation file

* Fix 5a sum

* Update domain according with updated account_tax_balance

* Fix calculation of lines + minor review

* Update steps regarding Usage in README.rst
astirpe added a commit to onesteinbv/l10n-netherlands that referenced this pull request Oct 21, 2020
* Add module l10n_nl_tax_statement

* Update oca_dependencies and flake8

* Developing module

* Decoupled from l10n_nl + added config feature

* Fix missing tag (Voorbelasting (BTW) bis)

* Add printable PDF report

* Add onchange for filling statement name

* Update layout

* Add tests

* Set postgres V9.2 for running tests with date_range

* Add nl.po translation file

* Fix 5a sum

* Update domain according with updated account_tax_balance

* Fix calculation of lines + minor review

* Update steps regarding Usage in README.rst
astirpe added a commit to onesteinbv/l10n-netherlands that referenced this pull request Oct 23, 2020
* Add module l10n_nl_tax_statement

* Update oca_dependencies and flake8

* Developing module

* Decoupled from l10n_nl + added config feature

* Fix missing tag (Voorbelasting (BTW) bis)

* Add printable PDF report

* Add onchange for filling statement name

* Update layout

* Add tests

* Set postgres V9.2 for running tests with date_range

* Add nl.po translation file

* Fix 5a sum

* Update domain according with updated account_tax_balance

* Fix calculation of lines + minor review

* Update steps regarding Usage in README.rst
astirpe added a commit to onesteinbv/l10n-netherlands that referenced this pull request Nov 2, 2020
* Add module l10n_nl_tax_statement

* Update oca_dependencies and flake8

* Developing module

* Decoupled from l10n_nl + added config feature

* Fix missing tag (Voorbelasting (BTW) bis)

* Add printable PDF report

* Add onchange for filling statement name

* Update layout

* Add tests

* Set postgres V9.2 for running tests with date_range

* Add nl.po translation file

* Fix 5a sum

* Update domain according with updated account_tax_balance

* Fix calculation of lines + minor review

* Update steps regarding Usage in README.rst
astirpe added a commit to onesteinbv/l10n-netherlands that referenced this pull request Nov 2, 2020
* Add module l10n_nl_tax_statement

* Update oca_dependencies and flake8

* Developing module

* Decoupled from l10n_nl + added config feature

* Fix missing tag (Voorbelasting (BTW) bis)

* Add printable PDF report

* Add onchange for filling statement name

* Update layout

* Add tests

* Set postgres V9.2 for running tests with date_range

* Add nl.po translation file

* Fix 5a sum

* Update domain according with updated account_tax_balance

* Fix calculation of lines + minor review

* Update steps regarding Usage in README.rst
astirpe added a commit to onesteinbv/l10n-netherlands that referenced this pull request Jan 12, 2021
* Add module l10n_nl_tax_statement

* Update oca_dependencies and flake8

* Developing module

* Decoupled from l10n_nl + added config feature

* Fix missing tag (Voorbelasting (BTW) bis)

* Add printable PDF report

* Add onchange for filling statement name

* Update layout

* Add tests

* Set postgres V9.2 for running tests with date_range

* Add nl.po translation file

* Fix 5a sum

* Update domain according with updated account_tax_balance

* Fix calculation of lines + minor review

* Update steps regarding Usage in README.rst
astirpe added a commit to onesteinbv/l10n-netherlands that referenced this pull request Jan 12, 2021
* Add module l10n_nl_tax_statement

* Update oca_dependencies and flake8

* Developing module

* Decoupled from l10n_nl + added config feature

* Fix missing tag (Voorbelasting (BTW) bis)

* Add printable PDF report

* Add onchange for filling statement name

* Update layout

* Add tests

* Set postgres V9.2 for running tests with date_range

* Add nl.po translation file

* Fix 5a sum

* Update domain according with updated account_tax_balance

* Fix calculation of lines + minor review

* Update steps regarding Usage in README.rst
tarteo pushed a commit to tarteo/l10n-netherlands that referenced this pull request May 10, 2022
* Add module l10n_nl_tax_statement

* Update oca_dependencies and flake8

* Developing module

* Decoupled from l10n_nl + added config feature

* Fix missing tag (Voorbelasting (BTW) bis)

* Add printable PDF report

* Add onchange for filling statement name

* Update layout

* Add tests

* Set postgres V9.2 for running tests with date_range

* Add nl.po translation file

* Fix 5a sum

* Update domain according with updated account_tax_balance

* Fix calculation of lines + minor review

* Update steps regarding Usage in README.rst
astirpe added a commit to onesteinbv/l10n-netherlands that referenced this pull request Jan 18, 2023
* Add module l10n_nl_tax_statement

* Update oca_dependencies and flake8

* Developing module

* Decoupled from l10n_nl + added config feature

* Fix missing tag (Voorbelasting (BTW) bis)

* Add printable PDF report

* Add onchange for filling statement name

* Update layout

* Add tests

* Set postgres V9.2 for running tests with date_range

* Add nl.po translation file

* Fix 5a sum

* Update domain according with updated account_tax_balance

* Fix calculation of lines + minor review

* Update steps regarding Usage in README.rst
astirpe added a commit to onesteinbv/l10n-netherlands that referenced this pull request Feb 23, 2023
* Add module l10n_nl_tax_statement

* Update oca_dependencies and flake8

* Developing module

* Decoupled from l10n_nl + added config feature

* Fix missing tag (Voorbelasting (BTW) bis)

* Add printable PDF report

* Add onchange for filling statement name

* Update layout

* Add tests

* Set postgres V9.2 for running tests with date_range

* Add nl.po translation file

* Fix 5a sum

* Update domain according with updated account_tax_balance

* Fix calculation of lines + minor review

* Update steps regarding Usage in README.rst
astirpe added a commit to onesteinbv/l10n-netherlands that referenced this pull request Feb 24, 2023
* Add module l10n_nl_tax_statement

* Update oca_dependencies and flake8

* Developing module

* Decoupled from l10n_nl + added config feature

* Fix missing tag (Voorbelasting (BTW) bis)

* Add printable PDF report

* Add onchange for filling statement name

* Update layout

* Add tests

* Set postgres V9.2 for running tests with date_range

* Add nl.po translation file

* Fix 5a sum

* Update domain according with updated account_tax_balance

* Fix calculation of lines + minor review

* Update steps regarding Usage in README.rst
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants