-
-
Notifications
You must be signed in to change notification settings - Fork 56
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[RFC][ADD] l10n nl tax statement for V10 #70
Conversation
6b16745
to
9316b97
Compare
@astirpe Nice job! the module looks really nice and I enjoy the 'post' feature!
|
@jvOrsouw thank you for the feedback! Should be fixed with the latest commit. |
👍 |
please correct the calculation of 5a: this should be a the sum of 1a through 4b. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I've tested the taxes with debit and credit values for 5a and 5b (and the categories they consist of), and found that the taxes ends up in the right category, with the right amounts and that the sum of the taxes is calculated correctly in all cases.
👍
@nielsmiddeldorp @jvOrsouw please use the github review workflow next time, but I count your two thumbs up as approval and merge without reviewing myself |
* Add module l10n_nl_tax_statement * Update oca_dependencies and flake8 * Developing module * Decoupled from l10n_nl + added config feature * Fix missing tag (Voorbelasting (BTW) bis) * Add printable PDF report * Add onchange for filling statement name * Update layout * Add tests * Set postgres V9.2 for running tests with date_range * Add nl.po translation file * Fix 5a sum * Update domain according with updated account_tax_balance * Fix calculation of lines + minor review * Update steps regarding Usage in README.rst
* Add module l10n_nl_tax_statement * Update oca_dependencies and flake8 * Developing module * Decoupled from l10n_nl + added config feature * Fix missing tag (Voorbelasting (BTW) bis) * Add printable PDF report * Add onchange for filling statement name * Update layout * Add tests * Set postgres V9.2 for running tests with date_range * Add nl.po translation file * Fix 5a sum * Update domain according with updated account_tax_balance * Fix calculation of lines + minor review * Update steps regarding Usage in README.rst
* Add module l10n_nl_tax_statement * Update oca_dependencies and flake8 * Developing module * Decoupled from l10n_nl + added config feature * Fix missing tag (Voorbelasting (BTW) bis) * Add printable PDF report * Add onchange for filling statement name * Update layout * Add tests * Set postgres V9.2 for running tests with date_range * Add nl.po translation file * Fix 5a sum * Update domain according with updated account_tax_balance * Fix calculation of lines + minor review * Update steps regarding Usage in README.rst
* Add module l10n_nl_tax_statement * Update oca_dependencies and flake8 * Developing module * Decoupled from l10n_nl + added config feature * Fix missing tag (Voorbelasting (BTW) bis) * Add printable PDF report * Add onchange for filling statement name * Update layout * Add tests * Set postgres V9.2 for running tests with date_range * Add nl.po translation file * Fix 5a sum * Update domain according with updated account_tax_balance * Fix calculation of lines + minor review * Update steps regarding Usage in README.rst
* Add module l10n_nl_tax_statement * Update oca_dependencies and flake8 * Developing module * Decoupled from l10n_nl + added config feature * Fix missing tag (Voorbelasting (BTW) bis) * Add printable PDF report * Add onchange for filling statement name * Update layout * Add tests * Set postgres V9.2 for running tests with date_range * Add nl.po translation file * Fix 5a sum * Update domain according with updated account_tax_balance * Fix calculation of lines + minor review * Update steps regarding Usage in README.rst
* Add module l10n_nl_tax_statement * Update oca_dependencies and flake8 * Developing module * Decoupled from l10n_nl + added config feature * Fix missing tag (Voorbelasting (BTW) bis) * Add printable PDF report * Add onchange for filling statement name * Update layout * Add tests * Set postgres V9.2 for running tests with date_range * Add nl.po translation file * Fix 5a sum * Update domain according with updated account_tax_balance * Fix calculation of lines + minor review * Update steps regarding Usage in README.rst
* Add module l10n_nl_tax_statement * Update oca_dependencies and flake8 * Developing module * Decoupled from l10n_nl + added config feature * Fix missing tag (Voorbelasting (BTW) bis) * Add printable PDF report * Add onchange for filling statement name * Update layout * Add tests * Set postgres V9.2 for running tests with date_range * Add nl.po translation file * Fix 5a sum * Update domain according with updated account_tax_balance * Fix calculation of lines + minor review * Update steps regarding Usage in README.rst
* Add module l10n_nl_tax_statement * Update oca_dependencies and flake8 * Developing module * Decoupled from l10n_nl + added config feature * Fix missing tag (Voorbelasting (BTW) bis) * Add printable PDF report * Add onchange for filling statement name * Update layout * Add tests * Set postgres V9.2 for running tests with date_range * Add nl.po translation file * Fix 5a sum * Update domain according with updated account_tax_balance * Fix calculation of lines + minor review * Update steps regarding Usage in README.rst
* Add module l10n_nl_tax_statement * Update oca_dependencies and flake8 * Developing module * Decoupled from l10n_nl + added config feature * Fix missing tag (Voorbelasting (BTW) bis) * Add printable PDF report * Add onchange for filling statement name * Update layout * Add tests * Set postgres V9.2 for running tests with date_range * Add nl.po translation file * Fix 5a sum * Update domain according with updated account_tax_balance * Fix calculation of lines + minor review * Update steps regarding Usage in README.rst
* Add module l10n_nl_tax_statement * Update oca_dependencies and flake8 * Developing module * Decoupled from l10n_nl + added config feature * Fix missing tag (Voorbelasting (BTW) bis) * Add printable PDF report * Add onchange for filling statement name * Update layout * Add tests * Set postgres V9.2 for running tests with date_range * Add nl.po translation file * Fix 5a sum * Update domain according with updated account_tax_balance * Fix calculation of lines + minor review * Update steps regarding Usage in README.rst
* Add module l10n_nl_tax_statement * Update oca_dependencies and flake8 * Developing module * Decoupled from l10n_nl + added config feature * Fix missing tag (Voorbelasting (BTW) bis) * Add printable PDF report * Add onchange for filling statement name * Update layout * Add tests * Set postgres V9.2 for running tests with date_range * Add nl.po translation file * Fix 5a sum * Update domain according with updated account_tax_balance * Fix calculation of lines + minor review * Update steps regarding Usage in README.rst
* Add module l10n_nl_tax_statement * Update oca_dependencies and flake8 * Developing module * Decoupled from l10n_nl + added config feature * Fix missing tag (Voorbelasting (BTW) bis) * Add printable PDF report * Add onchange for filling statement name * Update layout * Add tests * Set postgres V9.2 for running tests with date_range * Add nl.po translation file * Fix 5a sum * Update domain according with updated account_tax_balance * Fix calculation of lines + minor review * Update steps regarding Usage in README.rst
* Add module l10n_nl_tax_statement * Update oca_dependencies and flake8 * Developing module * Decoupled from l10n_nl + added config feature * Fix missing tag (Voorbelasting (BTW) bis) * Add printable PDF report * Add onchange for filling statement name * Update layout * Add tests * Set postgres V9.2 for running tests with date_range * Add nl.po translation file * Fix 5a sum * Update domain according with updated account_tax_balance * Fix calculation of lines + minor review * Update steps regarding Usage in README.rst
* Add module l10n_nl_tax_statement * Update oca_dependencies and flake8 * Developing module * Decoupled from l10n_nl + added config feature * Fix missing tag (Voorbelasting (BTW) bis) * Add printable PDF report * Add onchange for filling statement name * Update layout * Add tests * Set postgres V9.2 for running tests with date_range * Add nl.po translation file * Fix 5a sum * Update domain according with updated account_tax_balance * Fix calculation of lines + minor review * Update steps regarding Usage in README.rst
* Add module l10n_nl_tax_statement * Update oca_dependencies and flake8 * Developing module * Decoupled from l10n_nl + added config feature * Fix missing tag (Voorbelasting (BTW) bis) * Add printable PDF report * Add onchange for filling statement name * Update layout * Add tests * Set postgres V9.2 for running tests with date_range * Add nl.po translation file * Fix 5a sum * Update domain according with updated account_tax_balance * Fix calculation of lines + minor review * Update steps regarding Usage in README.rst
* Add module l10n_nl_tax_statement * Update oca_dependencies and flake8 * Developing module * Decoupled from l10n_nl + added config feature * Fix missing tag (Voorbelasting (BTW) bis) * Add printable PDF report * Add onchange for filling statement name * Update layout * Add tests * Set postgres V9.2 for running tests with date_range * Add nl.po translation file * Fix 5a sum * Update domain according with updated account_tax_balance * Fix calculation of lines + minor review * Update steps regarding Usage in README.rst
* Add module l10n_nl_tax_statement * Update oca_dependencies and flake8 * Developing module * Decoupled from l10n_nl + added config feature * Fix missing tag (Voorbelasting (BTW) bis) * Add printable PDF report * Add onchange for filling statement name * Update layout * Add tests * Set postgres V9.2 for running tests with date_range * Add nl.po translation file * Fix 5a sum * Update domain according with updated account_tax_balance * Fix calculation of lines + minor review * Update steps regarding Usage in README.rst
* Add module l10n_nl_tax_statement * Update oca_dependencies and flake8 * Developing module * Decoupled from l10n_nl + added config feature * Fix missing tag (Voorbelasting (BTW) bis) * Add printable PDF report * Add onchange for filling statement name * Update layout * Add tests * Set postgres V9.2 for running tests with date_range * Add nl.po translation file * Fix 5a sum * Update domain according with updated account_tax_balance * Fix calculation of lines + minor review * Update steps regarding Usage in README.rst
* Add module l10n_nl_tax_statement * Update oca_dependencies and flake8 * Developing module * Decoupled from l10n_nl + added config feature * Fix missing tag (Voorbelasting (BTW) bis) * Add printable PDF report * Add onchange for filling statement name * Update layout * Add tests * Set postgres V9.2 for running tests with date_range * Add nl.po translation file * Fix 5a sum * Update domain according with updated account_tax_balance * Fix calculation of lines + minor review * Update steps regarding Usage in README.rst
* Add module l10n_nl_tax_statement * Update oca_dependencies and flake8 * Developing module * Decoupled from l10n_nl + added config feature * Fix missing tag (Voorbelasting (BTW) bis) * Add printable PDF report * Add onchange for filling statement name * Update layout * Add tests * Set postgres V9.2 for running tests with date_range * Add nl.po translation file * Fix 5a sum * Update domain according with updated account_tax_balance * Fix calculation of lines + minor review * Update steps regarding Usage in README.rst
* Add module l10n_nl_tax_statement * Update oca_dependencies and flake8 * Developing module * Decoupled from l10n_nl + added config feature * Fix missing tag (Voorbelasting (BTW) bis) * Add printable PDF report * Add onchange for filling statement name * Update layout * Add tests * Set postgres V9.2 for running tests with date_range * Add nl.po translation file * Fix 5a sum * Update domain according with updated account_tax_balance * Fix calculation of lines + minor review * Update steps regarding Usage in README.rst
Introduction
Following the proposal of @StefanRijnhart discussed in PR #63, I would have to rewrite from scratch the module
l10n_nl_tax_declaration_reporting
in order to port it from V8 to V10. The proposal was to use an existing OCA moduleaccount_tax_balance
as a basis for retrieving the tax lines to be included in the Dutch tax statement report. Indeed the moduleaccount_tax_balance
does the job in an excellent way.Here it is a proposal to implement a new module, that will replace
l10n_nl_tax_declaration_reporting
, introducing a different approach to generate and manage the BTW statements.Why change the existing V8 approach
l10n_nl_tax_declaration_reporting
being ported to V9 and V10Status of the actual V8 module
l10n_nl_tax_declaration_reporting
allows the user to create PDF documents containing the Dutch tax statement report based on a date range; the module doesn't provide anything elseAnalysis of needed functionalities
Features of the proposed new module
account_tax_balance
as a base reporting engineFuture developments
Request for Comments
Included with this RFC, I propose the module I'm actually developing.
Looking forward to read your comments!