Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

New module l10n_nl_banks #92

Merged
merged 6 commits into from
Jul 4, 2017
Merged

New module l10n_nl_banks #92

merged 6 commits into from
Jul 4, 2017

Conversation

ploegvde
Copy link
Contributor

Simpel module i use to get all Dutch Banks.

hbrunn
hbrunn reviewed Jun 29, 2017
View reviewed changes
l10n_nl_banks/README.rst Outdated
Configuration
=============

#. No gonfiguration needed
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

c

hbrunn
hbrunn reviewed Jun 29, 2017
View reviewed changes
l10n_nl_banks/README.rst Outdated
Known issues / Roadmap
======================

#. None
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

remove empty sections

hbrunn
hbrunn requested changes Jun 29, 2017
View reviewed changes
Copy link
Member

@hbrunn hbrunn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

travis has some complaints. For the logo: If you painted that yourself, please include the source if any, otherwise add the source to the credit section

@hbrunn hbrunn added this to the 10.0 milestone Jun 29, 2017
astirpe
astirpe suggested changes Jun 29, 2017
View reviewed changes
Copy link
Member

@astirpe astirpe left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for this. Please check my review and also the travis warnings

l10n_nl_banks/README.rst Outdated
Dutch Banks
================

This module will import all Dutch bans with the BIC code
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Typo: bans -> banks

l10n_nl_banks/__manifest__.py Outdated
{
"name": "Dutch banks",
"version": "10.0.1.0.0",
"author": "Odoo Experts, Onestein, Odoo Community Association (OCA)",
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for this, but Onestein didn't work on this module, as far as I know. Should be removed from here.

l10n_nl_banks/data/nl_banks.xml Outdated
<odoo>
<data noupdate="1">

<record id="ABNA" model="res.bank">
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please indent by using spaces instead of tabs

l10n_nl_banks/data/nl_banks.xml Outdated
@@ -0,0 +1,222 @@
<?xml version="1.0" encoding="utf-8"?>
<odoo>
<data noupdate="1">
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You can use:

<odoo noupdate="1">

instead of:

<odoo>
	<data noupdate="1">

this way you can remove the element <data>

@hbrunn hbrunn merged commit 4fff494 into OCA:10.0 Jul 4, 2017
@ploegvde ploegvde deleted the l10n_nl_banks branch July 22, 2017 10:24
astirpe pushed a commit to onesteinbv/l10n-netherlands that referenced this pull request Jun 12, 2018
@ploegvde @astirpe
New module l10n_nl_banks (OCA#92)
569610d 
* New module l10n_nl_banks

* Remove blanc sections

* Icon credits

* OCA Requested changes

* Change module name

* Changes to comply with OCA
hbrunn pushed a commit that referenced this pull request Jul 3, 2018
@ploegvde @hbrunn
New module l10n_nl_banks (#92)
f1b3a6a 
* New module l10n_nl_banks

* Remove blanc sections

* Icon credits

* OCA Requested changes

* Change module name

* Changes to comply with OCA
astirpe pushed a commit to onesteinbv/l10n-netherlands that referenced this pull request Oct 2, 2018
@ploegvde @astirpe
New module l10n_nl_banks (OCA#92)
7b1438a 
* New module l10n_nl_banks

* Remove blanc sections

* Icon credits

* OCA Requested changes

* Change module name

* Changes to comply with OCA
hbrunn pushed a commit that referenced this pull request Oct 18, 2018
@ploegvde @hbrunn
New module l10n_nl_banks (#92)
67c669c 
* New module l10n_nl_banks

* Remove blanc sections

* Icon credits

* OCA Requested changes

* Change module name

* Changes to comply with OCA
lfreeke pushed a commit to lfreeke/l10n-netherlands that referenced this pull request Sep 30, 2019
@ploegvde @lfreeke
New module l10n_nl_banks (OCA#92)
8e1060e 
* New module l10n_nl_banks

* Remove blanc sections

* Icon credits

* OCA Requested changes

* Change module name

* Changes to comply with OCA
lfreeke pushed a commit to lfreeke/l10n-netherlands that referenced this pull request Feb 13, 2020
@ploegvde @lfreeke
New module l10n_nl_banks (OCA#92)
ce0b010 
* New module l10n_nl_banks

* Remove blanc sections

* Icon credits

* OCA Requested changes

* Change module name

* Changes to comply with OCA
bosd pushed a commit to bosd/l10n-netherlands that referenced this pull request Feb 27, 2021
@ploegvde @bosd
New module l10n_nl_banks (OCA#92)
18e1fed 
* New module l10n_nl_banks

* Remove blanc sections

* Icon credits

* OCA Requested changes

* Change module name

* Changes to comply with OCA
tarteo pushed a commit to tarteo/l10n-netherlands that referenced this pull request May 6, 2022
@ploegvde @tarteo
New module l10n_nl_banks (OCA#92)
2ef8a45 
* New module l10n_nl_banks

* Remove blanc sections

* Icon credits

* OCA Requested changes

* Change module name

* Changes to comply with OCA
astirpe pushed a commit to onesteinbv/l10n-netherlands that referenced this pull request Mar 7, 2023
@ploegvde @astirpe
New module l10n_nl_banks (OCA#92)
8e47c7c 
* New module l10n_nl_banks

* Remove blanc sections

* Icon credits

* OCA Requested changes

* Change module name

* Changes to comply with OCA
astirpe pushed a commit to astirpe/l10n-netherlands that referenced this pull request Feb 7, 2025
@ploegvde @astirpe
New module l10n_nl_banks (OCA#92)
3bdb060 
* New module l10n_nl_banks

* Remove blanc sections

* Icon credits

* OCA Requested changes

* Change module name

* Changes to comply with OCA
astirpe pushed a commit to astirpe/l10n-netherlands that referenced this pull request Feb 7, 2025
@ploegvde @astirpe
New module l10n_nl_banks (OCA#92)
2d667db 
* New module l10n_nl_banks

* Remove blanc sections

* Icon credits

* OCA Requested changes

* Change module name

* Changes to comply with OCA
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@hbrunn hbrunn hbrunn approved these changes

@astirpe astirpe astirpe approved these changes

Assignees
No one assigned
Labels
needs fixing
Projects
None yet
Milestone
10.0
Development

Successfully merging this pull request may close these issues.
3 participants
@ploegvde @hbrunn @astirpe