Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[17.0][MIG] l10n_es_aeat_mod115: Migration to 17.0 #3541

Merged
merged 59 commits into from
May 13, 2024

Conversation

Tisho99
Copy link
Contributor

@Tisho99 Tisho99 commented Apr 19, 2024

No description provided.

@Tisho99 Tisho99 force-pushed the 17.0-mig-l10n_es_aeat_mod115 branch 2 times, most recently from 6f1e944 to f7ee84a Compare April 22, 2024 07:53
@HaraldPanten
Copy link
Contributor

/ocabot migration l10n_es_aeat_mod115

@OCA-git-bot OCA-git-bot added this to the 17.0 milestone Apr 24, 2024
@OCA-git-bot OCA-git-bot mentioned this pull request Apr 24, 2024
48 tasks
@peluko00
Copy link
Contributor

Any update?

@Tisho99
Copy link
Contributor Author

Tisho99 commented Apr 26, 2024

@peluko00

No. However i haven't forgoted this PR.

When i have more time i will update this and finish the migration.

Maybe next week or in the spanish OCA days

@Tisho99 Tisho99 force-pushed the 17.0-mig-l10n_es_aeat_mod115 branch 2 times, most recently from 82c30b6 to 7db6729 Compare April 29, 2024 14:41
agaldona and others added 21 commits April 29, 2024 17:46
* Eliminar periodo específico y corregir exportación
* Cálculo de importes de impuestos por cadena en lugar de recordset
* Gestionar grupos de compañías
* Evitar problemas en campos related no readonly. Fixes OCA#290

Cuando se tienen campos related, aunque el valor no se cambie,
Odoo lanza una escritura en el objeto relacionado cada vez que se
guarda el objeto principal. En el caso de la moneda asociada a la
compañía, hace que aquellos usuarios que no tengan permiso para
modificar la compañía (la mayoría), falle en la creación del modelo.

* Mejor herencia de impuestos

El anterior método utilizado, al tener una clase y un many2one genérico,
no permitía poner los datos en múltiples modelos hijos, ya que se repetían
los IDs, y cogía los datos de un modelo en otros.

Con este nuevo sistema, se sigue utilizando una tabla, pero con doble
índice: el modelo y el ID, parecido a un campo reference, pero gestionado
por código propio en el método de cálculo.

El 303 está adaptado a este nuevo sistema, y se incluye un script de
migración que conserve los datos.
Currently translated at 94.3% (33 of 35 strings)

Translation: l10n-spain-11.0/l10n-spain-11.0-l10n_es_aeat_mod115
Translate-URL: https://translation.odoo-community.org/projects/l10n-spain-11-0/l10n-spain-11-0-l10n_es_aeat_mod115/ca/
* Standard procedure
* README by fragments
* Improve code a bit
* Expand tests for negative result
This way, we don't initially see all the subconfigs for each model and we can concentrate
on main export configurations. This is got through `active` field default behaviour.
Archived config are still directly searchable through the subconfig selector in the
configuration line.

All models export configs have been adapted to this new approach.
Currently translated at 100.0% (76 of 76 strings)

Translation: l10n-spain-12.0/l10n-spain-12.0-l10n_es_aeat_mod115
Translate-URL: https://translation.odoo-community.org/projects/l10n-spain-12-0/l10n-spain-12-0-l10n_es_aeat_mod115/es/
Currently translated at 100.0% (76 of 76 strings)

Translation: l10n-spain-12.0/l10n-spain-12.0-l10n_es_aeat_mod115
Translate-URL: https://translation.odoo-community.org/projects/l10n-spain-12-0/l10n-spain-12-0-l10n_es_aeat_mod115/ca/
@Tisho99 Tisho99 requested a review from manuelregidor May 7, 2024 09:11
Copy link
Contributor

@manuelregidor manuelregidor left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Technical review. LGTM

@OCA-git-bot
Copy link
Contributor

This PR has the approved label and has been created more than 5 days ago. It should therefore be ready to merge by a maintainer (or a PSC member if the concerned addon has no declared maintainer). 🤖

@ValentinVinagre
Copy link
Contributor

@Jesarregui

Copy link
Contributor

@Jesarregui Jesarregui left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Revisión funcional correcta. LGTM

Copy link
Contributor

@HaraldPanten HaraldPanten left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

SandraNetkia

This comment was marked as duplicate.

Copy link

@SandraNetkia SandraNetkia left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Revisión funcional correcta con validación de la exportación BOE sobre el entorno de pruebas de la AEAT.

@Tisho99 Tisho99 force-pushed the 17.0-mig-l10n_es_aeat_mod115 branch from 16df264 to 985dc61 Compare May 7, 2024 15:17
@Tisho99 Tisho99 requested a review from ValentinVinagre May 7, 2024 15:19
@ValentinVinagre
Copy link
Contributor

@Tisho99 revisa los tests 😄

@Tisho99 Tisho99 force-pushed the 17.0-mig-l10n_es_aeat_mod115 branch from 985dc61 to 59f30b0 Compare May 7, 2024 15:59
@Tisho99
Copy link
Contributor Author

Tisho99 commented May 7, 2024

The checks are fixed on the following PR:

OCA/community-data-files#198

@Tisho99 Tisho99 force-pushed the 17.0-mig-l10n_es_aeat_mod115 branch 2 times, most recently from 9d4f58f to 1a0cf26 Compare May 8, 2024 09:59
@HaraldPanten
Copy link
Contributor

/ocabot merge nobump

@OCA-git-bot
Copy link
Contributor

Hey, thanks for contributing! Proceeding to merge this for you.
Prepared branch 17.0-ocabot-merge-pr-3541-by-HaraldPanten-bump-nobump, awaiting test results.

@OCA-git-bot OCA-git-bot merged commit 910c1a9 into OCA:17.0 May 13, 2024
7 checks passed
@OCA-git-bot
Copy link
Contributor

Congratulations, your PR was merged at ba9508e. Thanks a lot for contributing to OCA. ❤️

@HaraldPanten HaraldPanten deleted the 17.0-mig-l10n_es_aeat_mod115 branch May 13, 2024 09:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.