Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[16.0][IMP] maintenance_equipment_sequence: remove duplicated field #438

Merged

Conversation

ThiagoMForgeFlow
Copy link

The serial number field is duplicated in the equipment tree view.

@ForgeFlow

@OCA-git-bot
Copy link
Contributor

Hi @AdriaGForgeFlow,
some modules you are maintaining are being modified, check this out!

Copy link
Contributor

@LoisRForgeFlow LoisRForgeFlow left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

Copy link

@TelmoSuarez TelmoSuarez left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This doesn't remove duplicated field, only hides it, maybe use position="move"?

@ThiagoMForgeFlow ThiagoMForgeFlow force-pushed the 16.0-imp-maintenance_equipment_sequence branch from 34db24c to eaf9878 Compare December 17, 2024 10:49
@ThiagoMForgeFlow
Copy link
Author

This doesn't remove duplicated field, only hides it, maybe use position="move"?

Thanks for the advice

@LoisRForgeFlow
Copy link
Contributor

@TelmoSuarez could you update your review?

@LoisRForgeFlow
Copy link
Contributor

@etobella merge? :)

@etobella
Copy link
Member

/ocabot merge patch

@OCA-git-bot
Copy link
Contributor

What a great day to merge this nice PR. Let's do it!
Prepared branch 16.0-ocabot-merge-pr-438-by-etobella-bump-patch, awaiting test results.

@OCA-git-bot OCA-git-bot merged commit 1ab3599 into OCA:16.0 Dec 18, 2024
7 checks passed
@OCA-git-bot
Copy link
Contributor

Congratulations, your PR was merged at 773b467. Thanks a lot for contributing to OCA. ❤️

@LoisRForgeFlow LoisRForgeFlow deleted the 16.0-imp-maintenance_equipment_sequence branch December 19, 2024 08:37
@LoisRForgeFlow
Copy link
Contributor

@ThiagoMForgeFlow could you fwport if needed?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants