[17.0][FIX] maintenance_plan: Use 'active_id' instead of 'id' in action to fix error #439
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…fix error The action 'hr_equipment_request_action_from_plan' failed because 'id' was not found. Replaced 'id' with 'active_id' to ensure the correct context value is used.
BernatObrador
changed the title
peluko00
approved these changes
Dec 18, 2024
|
This PR has the |
carlos-lopez-tecnativa
approved these changes
Jan 15, 2025
There was a problem hiding this comment.
Tested and confirmed that it resolves the issue mentioned in #414 (comment)
ping @victoralmau @pedrobaeza
|
There is also this other PR #437 that fixes this and something similar. |
Good catch! The other PR is more complete . I tested it, and it resolves both issues. Therefore, this one can be closed, and we can proceed with the other PR. |
|
Merging #437, as it's more complete, and it's even older. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The action 'hr_equipment_request_action_from_plan' failed because 'id' was not found. Replaced 'id' with 'active_id' to ensure the correct context value is used.
cc https://github.com/APSL 164938
@miquelalzanillas @lbarry-apsl @mpascuall @peluko00 @javierobcn @ppyczko please review