Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[IMP] mgmtsystem_nonconformity: Update cause #530

Merged
merged 1 commit into from
Sep 14, 2023
Merged

[IMP] mgmtsystem_nonconformity: Update cause #530

merged 1 commit into from
Sep 14, 2023

Conversation

yassine-rhimi
Copy link 

parent_path = fields.Char(index=True, unaccent=False)

@yassine-rhimi
Update mgmtsystem_nonconformity_cause.py
a14a8d4 
    parent_path = fields.Char(index=True, unaccent=False)
@max3903 max3903 changed the title Update mgmtsystem_nonconformity_cause.py [IMP] mgmtsystem_nonconformity: Update cause Sep 12, 2023
@max3903 max3903 added this to the 16.0 milestone Sep 12, 2023
@max3903 max3903 self-assigned this Sep 12, 2023
@yassine-rhimi
Copy link
Author

why this MR is not merging yet? Is there a problem?

@max3903
Copy link
Member

max3903 commented Sep 13, 2023

@yassine-rhimi There is no problem with your pull request.

As you wil read in the OCA Conventions here:
https://github.com/OCA/odoo-community.org/blob/master/website/Contribution/CONTRIBUTING.rst#review

we want to give some time to others to review your changes.

In the mean time, you can review the pull requests of others...

etobella
etobella approved these changes Sep 14, 2023
View reviewed changes
Copy link
Member

@etobella etobella left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/ocabot merge patch

@OCA-git-bot
Copy link
Contributor

On my way to merge this fine PR!
Prepared branch 16.0-ocabot-merge-pr-530-by-etobella-bump-patch, awaiting test results.

@OCA-git-bot OCA-git-bot merged commit eeb8f61 into OCA:16.0 Sep 14, 2023
5 checks passed
@OCA-git-bot
Copy link
Contributor

Congratulations, your PR was merged at da39eb1. Thanks a lot for contributing to OCA. ❤️

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@max3903 max3903 max3903 approved these changes

@ivantodorovich ivantodorovich ivantodorovich approved these changes

@etobella etobella etobella approved these changes

Assignees

@max3903 max3903

Labels
approved enhancement merged 🎉 needs review
Projects
None yet
Milestone
16.0
Development

Successfully merging this pull request may close these issues.
5 participants
@yassine-rhimi @max3903 @OCA-git-bot @ivantodorovich @etobella