[FIX] use lst_price for _compute_margin in product.product #193
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Hi @legalsylvain, |
anhvu-sg
force-pushed
the
16.0-product_standard_margin-bug-product-variants
branch
from
8101091 to
990ba8f
Compare
legalsylvain
reviewed
Jan 4, 2024
| @@ -5,7 +5,7 @@ | |||
| # License AGPL-3.0 or later (http://www.gnu.org/licenses/agpl.html). | |||
| { | |||
| "name": "Product Margin and Margin Rate", | |||
| "version": "16.0.1.0.1", | |||
| "version": "16.0.1.0.2", | |||
There was a problem hiding this comment.
This is unncessary. Will be done automatically, once merged.
anhvu-sg
force-pushed
the
16.0-product_standard_margin-bug-product-variants
branch
from
990ba8f to
137e3e5
Compare
@legalsylvain, I've made the necessary updates. Could you please review it? |
dreispt
approved these changes
Apr 6, 2024
|
/ocabot merge patch |
|
What a great day to merge this nice PR. Let's do it! |
|
Congratulations, your PR was merged at 43d07fb. Thanks a lot for contributing to OCA. ❤️ |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The margin calculation functions correctly for products without variants.
However, there is an issue with the calculation for products that have variants.
Expected behavior