Add missing requirements.txt generator in 13.0 #153
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
cc/ @carmenbianca |
sbidoul
force-pushed
the
13.0-add-missing-requirements.txt-generator
branch
2 times, most recently
from
08b36df
to
105ad93
Compare
sbidoul
force-pushed
the
13.0-add-missing-requirements.txt-generator
branch
from
105ad93
to
43a8757
Compare
|
I think the reason why this is not activated in 13.0 is because in this version, the external_dependencies manifest key is not using the pip package name, and thus, the requirements.txt will be invalid. |
|
In 13.0 pypi package names are accepted in external_dependencies. And even in previous versions, the external_dependencies_override must be correct in setup.py otherwise runboat won't work, so it's fine to generate it in 13.0 too. I think I simply forgot to update this file when I interoduced this generator. |
pedrobaeza
approved these changes
Sep 4, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.