[FIX] Support ecmaVersion 2022

[chienandalu]

Odoo officially supports ecmaVersion 2022 from v17: https://github.com/odoo/odoo/blame/9a11717c17b860ec2f1b2e228517c0d3945c474a/addons/web/tooling/_eslintrc.json#L9

Possible fixes:

• Support it globally
• Make an special template for Odoo >= 17

What do you think?

[pedrobaeza]

Please do it only for 17.0

[pedrobaeza]

I think you should limit the previous template, and please also check #258

[chienandalu]

I think you should limit the previous template, and please also check #258

That issue states that the new templating is used from eslint 9.3.0, but version 8.24.0 is being used right now.

oca-addons-repo-template/src/.pre-commit-config.yaml.jinja

Line 42 in b47dbcc

{%- set repo_rev.eslint = "v8.24.0" %}

[pedrobaeza]

Yes, but the idea is that you also update eslint in this shot (if there's no incompatibility).

[chienandalu]

Yes, but the idea is that you also update eslint in this shot (if there's no incompatibility).

Let my try it locally anyway

[chienandalu]

Let my try it locally anyway

Well, I'm finding some issues locally with how the new eslint config works in a modular way... I can't figure out how to make it work, I'm afraid.

How's that an issue in any case? Isn't it just a nice to have?

[pedrobaeza]

Yes, it was just a PoC. Then continue with the current esLint or bump it to the last compatible one.

[chienandalu]

Ok, tried locally and working

[pedrobaeza]

@sbidoul @yajo can you check?

[yajo]

It seems like both eslintrc files are pretty similar. Couldn't you just name this file {% if odoo_version > 12 %}.eslintrc.yml{% endif %}.jinja (notice the .jinja suffix) and template whatever you need inside of it?

[chienandalu]

That was the first approach 😅 https://github.com/OCA/oca-addons-repo-template/compare/55566fb29e0ed893c6f60689e7044d9c015c75bb..5d0a238db2efed04014ed876f06a2d5dae3b1c3e

[pedrobaeza]

If I read correctly the previous version, it was changing the ecmaVersion for all the versions, not only v17. Maybe I was wrong.

[chienandalu]

oh, you both are right 😄

[yajo]

I mean that you can put:

  ecmaVersion: {% if odoo_version < 17 %}2019{% else %}2022{% endif %}

In a single file and avoid having 2.

[chienandalu]

Done :)

[sbidoul]

LGTM. Code review only.

[OCA-git-bot]

This PR has the approved label and has been created more than 5 days ago. It should therefore be ready to merge by a maintainer (or a PSC member if the concerned addon has no declared maintainer). 🤖

[pedrobaeza]

Can you merge this and issue a new version? This can be applied massively to 17.0 branches. It shouldn't be too much problem, as we come from a massive update recently.