[16.0][ADD] partner_address_ok #1782
Conversation
norlinhenrik
force-pushed
the
16.0-add-partner_address_ok
branch
2 times, most recently
from
265129f
to
58f05f7
Compare
A valid postal address. |
Thanks !
|
|
Hi, as @legalsylvain already said, it should be False by default. |
|
On the PR for 14.0 I set default=True. |
norlinhenrik
force-pushed
the
16.0-add-partner_address_ok
branch
from
58f05f7
to
5056c79
Compare
|
I set default=False to be explicit. |
partner_address_ok/tests/__init__.py
Outdated
| @@ -0,0 +1,2 @@ | |||
| # License AGPL-3.0 or later (https://www.gnu.org/licenses/agpl.html). | |||
| from . import test_partner_contact_id | |||
There was a problem hiding this comment.
Hi, I don't think this is the correct test you're trying to import, please fix this.
There was a problem hiding this comment.
Thank you for finding this error. I have fixed it now.
norlinhenrik
force-pushed
the
16.0-add-partner_address_ok
branch
from
5056c79
to
25d65bd
Compare
| class ResPartner(models.Model): | ||
| _inherit = "res.partner" | ||
|
|
||
| address_ok = fields.Boolean( |
There was a problem hiding this comment.
I'm a bit perplexed.
It adds a boolean fields without adding any logic such as testing the validity of the address. We have something that exists in -> https://github.com/odoo/odoo/blob/17.0/addons/snailmail/models/snailmail_letter.py#L453
It could be achieved with tags on partners.
I would have prefered a field naming like is_valid_postal_address which is self explanatory.
NB: I will not block this PR. Feel free to take into account these points
There was a problem hiding this comment.
Thank you @leemannd for very good feedback!
There was a problem hiding this comment.
NB: another solution that was used in 12.0 was to add it into the type -> https://github.com/OCA/partner-contact/tree/12.0/partner_postal_address
But it may not fulfill your need.
No description provided.