[14.0] partner_helper: add strict mode that raise an error if address is too long #1790
Conversation
partner_helper/models/partner.py
Outdated
|
|
||
|
|
||
| def split_char(char, output_number, size): | ||
| words = char.split(" ") | ||
| def split_char(char, output_number, size, strict): |
There was a problem hiding this comment.
Isn't it better to set strict=False in signature in case some modules use this method directly ?
|
The name of this module is now https://github.com/OCA/partner-contact/tree/16.0/partner_address_split |
sebastienbeau
force-pushed
the
14.0-add-strict-mode
branch
from
ab4b981
to
62cfa0e
Compare
|
/ocabot merge patch |
|
On my way to merge this fine PR! |
|
@sebastienbeau your merge command was aborted due to failed check(s), which you can inspect on this commit of 14.0-ocabot-merge-pr-1790-by-sebastienbeau-bump-patch. After fixing the problem, you can re-issue a merge command. Please refrain from merging manually as it will most probably make the target branch red. |
|
/ocabot merge patch |
|
This PR looks fantastic, let's merge it! |
|
Congratulations, your PR was merged at ebcd65e. Thanks a lot for contributing to OCA. ❤️ |
Add an optional strict mode, so you can raise an error if the address can not be splitted correctly because it's too long
@bealdav @florian-dacosta