Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[16.0][ADD] pos_order_exclude_attribute_combination #949

Open
wants to merge 1 commit into
base: 16.0
Choose a base branch
from

Conversation

sandipvyas-osi
Copy link
Contributor

No description provided.

@github-actions
Copy link

There hasn't been any activity on this pull request in the past 4 months, so it has been marked as stale and it will be closed automatically if no further activity occurs in the next 30 days.
If you want this PR to never become stale, please ask a PSC member to apply the "no stale" label.

@github-actions github-actions bot added the stale PR/Issue without recent activity, it'll be soon closed automatically. label Jul 30, 2023
@github-actions github-actions bot closed this Sep 3, 2023
@dreispt dreispt reopened this Nov 24, 2023
@dreispt dreispt added no stale Use this label to prevent the automated stale action from closing this PR/Issue. and removed stale PR/Issue without recent activity, it'll be soon closed automatically. labels Nov 24, 2023
@legalsylvain legalsylvain added this to the 16.0 milestone Feb 21, 2024
@@ -0,0 +1,22 @@
.no_combination {
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It'd be nice to move these css classes under a global one, to limit their domain.

A rule of thumb when you're developing a PoS module, is to define the css classes under the .pos class, which is added to the topmost parent element in the PoS UI.

.pos {
    .no_combination {
        ...
    }
    ...
}

It's even better if you can specify even more.
In this case, you know the class will be used in the ProductConfiguratorPopup, whose top element has the product-configurator-popup class. So you could write it like this:

.pos {
    .product-configurator-popup {
        .no_combination {
            ...
        }
        ...
    }
}

@ivantodorovich
Copy link
Contributor

Unit tests would be nice, too ^^

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
no stale Use this label to prevent the automated stale action from closing this PR/Issue.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants