Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[13.0][MIG] product_packaging_dimension #551

Merged
merged 3 commits into from
Jan 28, 2020
Merged

[13.0][MIG] product_packaging_dimension #551

merged 3 commits into from
Jan 28, 2020

Conversation

grindtildeath
Copy link
Contributor

Forward port of #531

This was referenced Jan 8, 2020
Merged
Merged
Tonow-c2c
Tonow-c2c reviewed Jan 9, 2020
View reviewed changes
Copy link
Contributor

@Tonow-c2c Tonow-c2c left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

comment idem as comment idem as https://github.com/OCA/product-attribute/pull/551/files#diff-7204ef8da825976a99b3672ada1c75c8

@simahawk
Copy link
Contributor

simahawk commented Jan 9, 2020

@grindtildeath what about this OCA/OCB@25616b9 ?

@grindtildeath
Copy link
Contributor Author

@simahawk The commit is from 2016 so it seems the issues is always the same.
IMO, let's not rely on a modified lib and use a field name that prevents any JS issue.

@guewen
Copy link
Member

guewen commented Jan 10, 2020 •
edited
Loading

what about this OCA/OCB@25616b9 ?

AFAIS this is a different part of the code, the issue reported in odoo/odoo#41353 being about onchanges and the correction above is in reload_record.

simahawk
simahawk approved these changes Jan 10, 2020
View reviewed changes
Copy link
Contributor

@simahawk simahawk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@grindtildeath please squash :)

@grindtildeath grindtildeath force-pushed the 13.0-mig-product_packaging_dimension branch from 14a0a32 to f98aad7 Compare January 13, 2020 16:07
@gurneyalex
Copy link
Member

/ocabot merge

@OCA-git-bot
Copy link
Contributor

On my way to merge this fine PR!
Prepared branch 13.0-ocabot-merge-pr-551-by-gurneyalex-bump-no, awaiting test results.

OCA-git-bot added a commit that referenced this pull request Jan 28, 2020
@OCA-git-bot
Merge PR #551 into 13.0
e1b37da 
Signed-off-by gurneyalex
@OCA-git-bot OCA-git-bot merged commit f98aad7 into OCA:13.0 Jan 28, 2020
@OCA-git-bot
Copy link
Contributor

Congratulations, your PR was merged at d16eecb. Thanks a lot for contributing to OCA. ❤️

@clementmbr clementmbr mentioned this pull request Mar 20, 2020
Merged
@jgrandguillaume jgrandguillaume mentioned this pull request May 28, 2020
Closed
62 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Tonow-c2c Tonow-c2c Tonow-c2c left review comments

@guewen guewen guewen approved these changes

@simahawk simahawk simahawk approved these changes

Assignees
No one assigned
Labels
approved merged 🎉
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
6 participants
@grindtildeath @simahawk @guewen @gurneyalex @OCA-git-bot @Tonow-c2c