Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[15.0] [MIG] sale_order_line_variant_description #276

Merged

Conversation

OSevangelist
Copy link

No description provided.

tafaRU and others added 16 commits November 12, 2022 12:33
Currently translated at 100.0% (7 of 7 strings)

Translation: product-variant-10.0/product-variant-10.0-sale_order_line_variant_description
Translate-URL: https://translation.odoo-community.org/projects/product-variant-10-0/product-variant-10-0-sale_order_line_variant_description/pt/
Currently translated at 100.0% (7 of 7 strings)

Translation: product-variant-10.0/product-variant-10.0-sale_order_line_variant_description
Translate-URL: https://translation.odoo-community.org/projects/product-variant-10-0/product-variant-10-0-sale_order_line_variant_description/nl/
Copy link

@Christian-RB Christian-RB left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@OSevangelist OSevangelist mentioned this pull request Nov 14, 2022
9 tasks
@OSevangelist
Copy link
Author

It seems that class 'wrapt' cannot be imported using Python 3.11 and that causes the mandatory pre-commit tests to fail on this PR. The issue is explained for instance here GrahamDumpleton/wrapt#196

Maybe someone has an idea how to fix that, @sbidoul ? I am happy to do it myself but i have no clue where to get that fixed in our tool chain to be consistent across repositories. Thanks for the help @azoellner to identify the issue

@sbidoul
Copy link
Member

sbidoul commented Nov 14, 2022

Try pipx run copier -f update. There is a fair chance this is already fixed in the latest project template.

@OSevangelist
Copy link
Author

@sbidoul that seems to have worked. thanks for the help and sorry for the time it took me to apply them. I an gonna merge this trivial change now

@OSevangelist
Copy link
Author

/ocabot merge

@OCA-git-bot
Copy link
Contributor

Hi @OSevangelist. Your command failed:

Required option bumpversion_mode for command merge. Possible values : major, minor, patch, nobump.

Ocabot commands

  • ocabot merge major|minor|patch|nobump
  • ocabot rebase
  • ocabot migration {MODULE_NAME}

More information

@OSevangelist
Copy link
Author

/ocabot merge major

@OCA-git-bot
Copy link
Contributor

On my way to merge this fine PR!
Prepared branch 15.0-ocabot-merge-pr-276-by-OSevangelist-bump-major, awaiting test results.

@OCA-git-bot OCA-git-bot merged commit cc278c3 into OCA:15.0 Nov 23, 2022
@OCA-git-bot
Copy link
Contributor

Congratulations, your PR was merged at fba2795. Thanks a lot for contributing to OCA. ❤️

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

9 participants