Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[12.0] project_template: Comparing apples and oranges #564

Closed
alexey-pelykh opened this issue Aug 12, 2019 · 3 comments
Closed

[12.0] project_template: Comparing apples and oranges #564

alexey-pelykh opened this issue Aug 12, 2019 · 3 comments

Comments

@alexey-pelykh
Copy link
Contributor

project/project_template/models/project.py

Line 20 in c6aab70

if new_project.subtask_project_id != new_project.id: 

2019-08-12 20:25:01,516 5820 WARNING openerp_test odoo.models: Comparing apples and oranges: project.project(135,) == 135
@alexey-pelykh
Copy link
Contributor Author

Won't next line cause issues as well?

@hbrunn
Copy link
Member

hbrunn commented Aug 13, 2019

no, because of https://github.com/OCA/OCB/blob/12.0/odoo/fields.py#L2137

@alexey-pelykh
Copy link
Contributor Author

oh, good to know!

skeller1 pushed a commit to skeller1/project that referenced this issue Nov 15, 2020
@pedrobaeza @skeller1
[FIX] project_template: Comparing apples and oranges
219fea1 
Fixes OCA#564
Yoshiro009 pushed a commit to ecosoft-odoo/project that referenced this issue Nov 20, 2020
@pedrobaeza @Yoshiro009
[FIX] project_template: Comparing apples and oranges
59aa56d 
Fixes OCA#564
yweng8111 pushed a commit to elego/project that referenced this issue Mar 6, 2021
@pedrobaeza @yweng8111
[FIX] project_template: Comparing apples and oranges
ec7e5cb 
Fixes OCA#564
aisopuro pushed a commit to avoinsystems/project-oca that referenced this issue Mar 5, 2024
@pedrobaeza @aisopuro
[FIX] project_template: Comparing apples and oranges
fc73940 
Fixes OCA#564
aisopuro pushed a commit to avoinsystems/project-oca that referenced this issue Mar 6, 2024
@pedrobaeza @aisopuro
[FIX] project_template: Comparing apples and oranges
8a433ec 
Fixes OCA#564
stenlyk pushed a commit to stenlyk/stenlyk-17.0-mig-project_template that referenced this issue Jul 19, 2024
@pedrobaeza @stenlyk
[FIX] project_template: Comparing apples and oranges
3f94774 
Fixes OCA#564
aisopuro pushed a commit to avoinsystems/project-oca that referenced this issue Nov 21, 2024
@pedrobaeza @aisopuro
[FIX] project_template: Comparing apples and oranges
b6aabb3 
Fixes OCA#564
michaelslade54 added a commit to michaelslade54/project that referenced this issue Feb 7, 2025
@michaelslade54 @patrickrwilson
@OCA-git-bot @oca-travis @pedrobaeza @oca-transbot @pedrocs-exo @gregory-moka @sysadminmatmoz @primes2h @AlfadilTabar @ygol @skeller1 @ibuioli @Yvesldff @simonstromb @Mantux11 @marylla @badbole @mymage @adrianojprado @Jan-Onestein @weblate @stenlyk
17.0 mig project template (#5)
78edba5 
* [ADD] Project Template Module

Adding new Project Template Module

[FIX] PEP8 Errors

Revert "[FIX] PEP8 Errors"

This reverts commit 90f9cd9.

[FIX] Fixed PEP8 Formatting

First upload tests showed some lint issues which this commit has the fixes for.

[FIX] Fixed LINT Issue

Removed unreachable code that was not needed.

[FIX] RunBot Warning

Fixed runbot warning about @Class to hasclass

[UPD] Suggested Changes

Updated based on suggested changes on other submitted modules.

[UPD] Manifest and Readme

Updated Manifest and Readme based on comments on other module pr's.

[UPD] Suggested Changes

Updated code based on suggested code changes from reviewer.

[FIX] Creation Error

Fixed create project error when creating project via configuration/projects menu

[UPD] Menu and Bool Change

Removed Template Menu (Filter option still there) and moved Bool up below name. (From reviewer suggestions)

[UPD] Kanban Menu

Removed button, added link to kanban menu. Start of tests

[UPD] Remove project_milestone code

Removed the project_milestone code and will create a separate module for that purpose.

* [UPD] README.rst

* [UPD] Update project_template.pot

* [UPD] README.rst

* [FIX] project_template: Comparing apples and oranges

Fixes OCA#564

* Added translation using Weblate (Spanish)

* Translated using Weblate (Spanish)

Currently translated at 100.0% (7 of 7 strings)

Translation: project-12.0/project-12.0-project_template
Translate-URL: https://translation.odoo-community.org/projects/project-12-0/project-12-0-project_template/es/

* [UPD] Update project_template.pot

* Update translation files

Updated by "Update PO files to match POT (msgmerge)" hook in Weblate.

Translation: project-12.0/project-12.0-project_template
Translate-URL: https://translation.odoo-community.org/projects/project-12-0/project-12-0-project_template/

* [FIX] new_name error

There is an error if the template name gets modified so needed to add a new else statement for the new_name.

* [UPD] Add to Test

* project_template 12.0.1.0.1

* Added translation using Weblate (Portuguese)

* Translated using Weblate (Portuguese)

Currently translated at 100.0% (7 of 7 strings)

Translation: project-12.0/project-12.0-project_template
Translate-URL: https://translation.odoo-community.org/projects/project-12-0/project-12-0-project_template/pt/

* Added translation using Weblate (French)

* Translated using Weblate (French)

Currently translated at 85.7% (6 of 7 strings)

Translation: project-12.0/project-12.0-project_template
Translate-URL: https://translation.odoo-community.org/projects/project-12-0/project-12-0-project_template/fr/

* Added translation using Weblate (Slovenian)

* Translated using Weblate (Slovenian)

Currently translated at 100.0% (7 of 7 strings)

Translation: project-12.0/project-12.0-project_template
Translate-URL: https://translation.odoo-community.org/projects/project-12-0/project-12-0-project_template/sl/

* Added translation using Weblate (Italian)

* Translated using Weblate (Italian)

Currently translated at 14.3% (1 of 7 strings)

Translation: project-12.0/project-12.0-project_template
Translate-URL: https://translation.odoo-community.org/projects/project-12-0/project-12-0-project_template/it/

* [IMP] project_template: black, isort, prettier

* [MIG] project_template: Migration to 13.0

* [UPD] Update project_template.pot

* [UPD] README.rst

* Update translation files

Updated by "Update PO files to match POT (msgmerge)" hook in Weblate.

Translation: project-13.0/project-13.0-project_template
Translate-URL: https://translation.odoo-community.org/projects/project-13-0/project-13-0-project_template/

* Added translation using Weblate (Hebrew)

* Translated using Weblate (Hebrew)

Currently translated at 100.0% (7 of 7 strings)

Translation: project-13.0/project-13.0-project_template
Translate-URL: https://translation.odoo-community.org/projects/project-13-0/project-13-0-project_template/he/

* [MIG] project_template: Migration to 14.0

* [UPD] Update project_template.pot

* [UPD] README.rst

* project_template 14.0.1.1.0

* Added translation using Weblate (Spanish (Argentina))

* Translated using Weblate (Spanish (Argentina))

Currently translated at 100.0% (10 of 10 strings)

Translation: project-14.0/project-14.0-project_template
Translate-URL: https://translation.odoo-community.org/projects/project-14-0/project-14-0-project_template/es_AR/

* Translated using Weblate (French)

Currently translated at 100.0% (7 of 7 strings)

Translation: project-14.0/project-14.0-project_template
Translate-URL: https://translation.odoo-community.org/projects/project-14-0/project-14-0-project_template/fr/

* Added translation using Weblate (French (France))

* Translated using Weblate (French (France))

Currently translated at 70.0% (7 of 10 strings)

Translation: project-14.0/project-14.0-project_template
Translate-URL: https://translation.odoo-community.org/projects/project-14-0/project-14-0-project_template/fr_FR/

* Added translation using Weblate (German)

* Translated using Weblate (German)

Currently translated at 100.0% (10 of 10 strings)

Translation: project-14.0/project-14.0-project_template
Translate-URL: https://translation.odoo-community.org/projects/project-14-0/project-14-0-project_template/de/

* Added translation using Weblate (Swedish)

* Translated using Weblate (Swedish)

Currently translated at 100.0% (10 of 10 strings)

Translation: project-14.0/project-14.0-project_template
Translate-URL: https://translation.odoo-community.org/projects/project-14-0/project-14-0-project_template/sv/

* [MIG] project_template: migration to 15.0

Since in  original odoo `15.0` version project subtasks
has been deleted so changes also done in this module.
We don't need project subtasks anymore because odoo don't have it.

* [UPD] Update project_template.pot

* [UPD] README.rst

* [16.0][MIG] project_template: Migration

* [UPD] Update project_template.pot

* [UPD] README.rst

* Translated using Weblate (German)

Currently translated at 100.0% (10 of 10 strings)

Translation: project-16.0/project-16.0-project_template
Translate-URL: https://translation.odoo-community.org/projects/project-16-0/project-16-0-project_template/de/

* Added translation using Weblate (Croatian)

* Translated using Weblate (Croatian)

Currently translated at 100.0% (7 of 7 strings)

Translation: project-16.0/project-16.0-project_template
Translate-URL: https://translation.odoo-community.org/projects/project-16-0/project-16-0-project_template/hr/

* Translated using Weblate (Italian)

Currently translated at 100.0% (7 of 7 strings)

Translation: project-16.0/project-16.0-project_template
Translate-URL: https://translation.odoo-community.org/projects/project-16-0/project-16-0-project_template/it/

* Added translation using Weblate (Portuguese (Brazil))

* Translated using Weblate (Portuguese (Brazil))

Currently translated at 100.0% (7 of 7 strings)

Translation: project-16.0/project-16.0-project_template
Translate-URL: https://translation.odoo-community.org/projects/project-16-0/project-16-0-project_template/pt_BR/

* [UPD] README.rst

* Added translation using Weblate (Dutch)

* Translated using Weblate (Dutch)

Currently translated at 85.7% (6 of 7 strings)

Translation: project-16.0/project-16.0-project_template
Translate-URL: https://translation.odoo-community.org/projects/project-16-0/project-16-0-project_template/nl/

* Update translation files

Updated by "Update PO files to match POT (msgmerge)" hook in Weblate.

Translation: project-16.0/project-16.0-project_template
Translate-URL: https://translation.odoo-community.org/projects/project-16-0/project-16-0-project_template/

* [IMP] project_template: pre-commit auto fixes

* [MIG] project_template: Migration to 17.0

---------

Co-authored-by: Patrick Wilson <36892066+patrickrwilson@users.noreply.github.com>
Co-authored-by: OCA-git-bot <oca-git-bot@odoo-community.org>
Co-authored-by: oca-travis <oca+oca-travis@odoo-community.org>
Co-authored-by: Pedro M. Baeza <pedro.baeza@tecnativa.com>
Co-authored-by: María Asunción Daza <mariaasuncion.daza@guadaltech.es>
Co-authored-by: OCA Transbot <transbot@odoo-community.org>
Co-authored-by: Pedro Castro Silva <pedrocs@exo.pt>
Co-authored-by: Grégory Moka Tourisme <gregory@mokatourisme.fr>
Co-authored-by: Matjaz Mozetic <matjaz@matmoz.si>
Co-authored-by: Sergio Zanchetta <primes2h@gmail.com>
Co-authored-by: alfadil <alfadil.tabar@gmail.com>
Co-authored-by: Yves Goldberg <admin@ygol.com>
Co-authored-by: skeller1 <MiStK@gmx.de>
Co-authored-by: Ignacio Buioli <ibuioli@gmail.com>
Co-authored-by: Yves Le Doeuff <yld@alliasys.fr>
Co-authored-by: Álvaro Estébanez <alvaro.estebanez@braintec-group.com>
Co-authored-by: Simon S <simon.stromberg@vertel.se>
Co-authored-by: Mantux11 <mantas@vialaurea.lt>
Co-authored-by: oca-ci <oca-ci@odoo-community.org>
Co-authored-by: Maria Sparenberg <maria.sparenberg@gmx.net>
Co-authored-by: Bole <bole@dajmi5.com>
Co-authored-by: mymage <stefano.consolaro@mymage.it>
Co-authored-by: Adriano Prado <adrianojprado@gmail.com>
Co-authored-by: Jan Tapper [Onestein] <j.tapper@onestein.nl>
Co-authored-by: Weblate <noreply@weblate.org>
Co-authored-by: Stanislav Kurinec <stenly.kurinec@gmail.com>
StefanRijnhart pushed a commit to StefanRijnhart/project that referenced this issue Feb 12, 2025
@pedrobaeza @StefanRijnhart
[FIX] project_template: Comparing apples and oranges
47e401c 
Fixes OCA#564
StefanRijnhart pushed a commit to StefanRijnhart/project that referenced this issue Feb 12, 2025
@pedrobaeza @StefanRijnhart
[FIX] project_template: Comparing apples and oranges
292b415 
Fixes OCA#564
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@alexey-pelykh @hbrunn