[MIG/REM] purchase_order_line_packaging_qty: Makes it uninstallable

[rousseldenis]

Keep it in this version uninstallable for records.

[rousseldenis]

@MiquelRForgeFlow @LoisRForgeFlow @ChrisOForgeFlow

I've added tests to check if all functionalities of this module have been implemented in Odoo. But made it uninstallable.

People needs to 'just' update product_packaging > product_packaging_id field.

The only thing that misses is the creation of purchase order line from procurement.

But IMHO that one should not be part of this module and should be done in another one. I'll do it.

[lmignon]

@rousseldenis Thank you for the migration and the proposed approach. IMO we should not merge this one since it's deprecated and useless. The move of remaining logic into an other addon is a good idea.

[LoisRForgeFlow]

Makes sense 👍

[OCA-git-bot]

This PR has the approved label and has been created more than 5 days ago. It should therefore be ready to merge by a maintainer (or a PSC member if the concerned addon has no declared maintainer). 🤖

[HviorForgeFlow]

@rousseldenis what to do here?

[dreispt]

/ocabot merge nobump

[OCA-git-bot]

This PR looks fantastic, let's merge it!
Prepared branch 16.0-ocabot-merge-pr-1672-by-dreispt-bump-nobump, awaiting test results.

[OCA-git-bot]

@dreispt your merge command was aborted due to failed check(s), which you can inspect on this commit of 16.0-ocabot-merge-pr-1672-by-dreispt-bump-nobump.

After fixing the problem, you can re-issue a merge command. Please refrain from merging manually as it will most probably make the target branch red.

[rafaelbn]

@yajo ping

/ocabot merge patch

[OCA-git-bot]

This PR looks fantastic, let's merge it!
Prepared branch 16.0-ocabot-merge-pr-1672-by-rafaelbn-bump-patch, awaiting test results.

[rafaelbn]

/ocabot migration purchase_order_line_packaging_qty

[OCA-git-bot]

@rafaelbn your merge command was aborted due to failed check(s), which you can inspect on this commit of 16.0-ocabot-merge-pr-1672-by-rafaelbn-bump-patch.

After fixing the problem, you can re-issue a merge command. Please refrain from merging manually as it will most probably make the target branch red.

[dreispt]

/ocabot merge patch

[OCA-git-bot]

Hey, thanks for contributing! Proceeding to merge this for you.
Prepared branch 16.0-ocabot-merge-pr-1672-by-dreispt-bump-patch, awaiting test results.

[OCA-git-bot]

@dreispt your merge command was aborted due to failed check(s), which you can inspect on this commit of 16.0-ocabot-merge-pr-1672-by-dreispt-bump-patch.

After fixing the problem, you can re-issue a merge command. Please refrain from merging manually as it will most probably make the target branch red.

[yajo]

It seems one test is failing:

2023-12-02 17:21:29,452 385 INFO odoo odoo.addons.purchase_order_line_packaging_qty.tests.test_purchase_order_line_packaging_qty: ====================================================================== 
2023-12-02 17:21:29,452 385 ERROR odoo odoo.addons.purchase_order_line_packaging_qty.tests.test_purchase_order_line_packaging_qty: FAIL: TestPurchaseOrderLinePackagingQty.test_product_packaging_qty_inverse
Traceback (most recent call last):
  File "/__w/purchase-workflow/purchase-workflow/purchase_order_line_packaging_qty/tests/test_purchase_order_line_packaging_qty.py", line 87, in test_product_packaging_qty_inverse
    with Form(order) as order_form:
  File "/opt/odoo/odoo/tests/common.py", line 2259, in __exit__
    self.save()
  File "/opt/odoo/odoo/tests/common.py", line 2272, in save
    values = self._values_to_save()
  File "/opt/odoo/odoo/tests/common.py", line 2299, in _values_to_save
    return self._values_to_save_(
  File "/opt/odoo/odoo/tests/common.py", line 2337, in _values_to_save_
    raise AssertionError("{} is a required field ({})".format(f, view['modifiers'][f]))
AssertionError: order_type is a required field ({'readonly': [('state', 'in', ['purchase', 'done', 'cancel'])], 'required': [(1, '=', 1)]})

Could you please rebase and see if it fails now, then fix it?

[hspl-niharika]

@rousseldenis Thanx for migration
@pedrobaeza It's good. I thin you can merge this

[yajo]

I didn't read #1672 (comment) carefully. It seems to me like this should be handled in a migration script in https://github.com/OCA/openupgrade

[github-actions]

There hasn't been any activity on this pull request in the past 4 months, so it has been marked as stale and it will be closed automatically if no further activity occurs in the next 30 days.
If you want this PR to never become stale, please ask a PSC member to apply the "no stale" label.