Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[16.0][mig] purchase_order_no_zero_price: Migration to 16.0 #1836

Merged
merged 7 commits into from
May 16, 2023
Merged

[16.0][mig] purchase_order_no_zero_price: Migration to 16.0 #1836

merged 7 commits into from
May 16, 2023

Conversation

dsolanki-initos
Copy link
Contributor

No description provided.

@dsolanki-initos dsolanki-initos force-pushed the 16.0-mig-purchase_order_no_zero_price branch from 9763412 to 85f49f8 Compare April 6, 2023 12:54
@PavarunCh
Copy link

I noticed that there are a lot of commits, Please squash commits.

@dsolanki-initos
Copy link
Contributor Author

dsolanki-initos commented May 12, 2023 •
edited
Loading

I noticed that there are a lot of commits, Please squash commits.

@PavarunCh, I did only two commits (pre-commit and migration), the remaining are coming from the patch of version 15.

@PavarunCh
Copy link

I apologize for the misunderstanding.

@dsolanki-initos
Copy link
Contributor Author

I apologize for the misunderstanding.

Okay, No worries, Could you please review this PR?

PavarunCh
PavarunCh approved these changes May 16, 2023
View reviewed changes
Copy link

@PavarunCh PavarunCh left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍
Functional tested

HviorForgeFlow
HviorForgeFlow approved these changes May 16, 2023
View reviewed changes
Copy link
Member

@HviorForgeFlow HviorForgeFlow left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code review LGTM 👍

@HviorForgeFlow
Copy link
Member

/ocabot migration purchase_order_no_zero_price

@HviorForgeFlow
Copy link
Member

/ocabot merge nobump

@OCA-git-bot
Copy link
Contributor

This PR has the approved label and has been created more than 5 days ago. It should therefore be ready to merge by a maintainer (or a PSC member if the concerned addon has no declared maintainer). 🤖

1 similar comment
@OCA-git-bot
Copy link
Contributor

This PR has the approved label and has been created more than 5 days ago. It should therefore be ready to merge by a maintainer (or a PSC member if the concerned addon has no declared maintainer). 🤖

@OCA-git-bot OCA-git-bot added this to the 16.0 milestone May 16, 2023
@OCA-git-bot OCA-git-bot mentioned this pull request May 16, 2023
Open
53 tasks
@OCA-git-bot
Copy link
Contributor

What a great day to merge this nice PR. Let's do it!
Prepared branch 16.0-ocabot-merge-pr-1836-by-HviorForgeFlow-bump-nobump, awaiting test results.

@OCA-git-bot OCA-git-bot merged commit 597bc0d into OCA:16.0 May 16, 2023
@OCA-git-bot
Copy link
Contributor

Congratulations, your PR was merged at 4fe459d. Thanks a lot for contributing to OCA. ❤️

@HviorForgeFlow
Copy link
Member

/ocabot migration purchase_order_no_zero_price

rousseldenis
rousseldenis reviewed Feb 6, 2024
View reviewed changes
purchase_order_no_zero_price/models/purchase_order_line.py
# to help ensure proper Stock Valuation
# when receiving the products
# Also supports `purchase_triple_discount` module
no_price_lines = self.filtered(
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@HviorForgeFlow @dsolanki-initos IMHO this should be configurable either on the company level, either on product one as it breaks standard behavior.

Modules that are not aware of this one (no dependency) could fail.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@rousseldenis rousseldenis rousseldenis left review comments

@PavarunCh PavarunCh PavarunCh approved these changes

@HviorForgeFlow HviorForgeFlow HviorForgeFlow approved these changes

Assignees
No one assigned
Labels
approved merged 🎉 ready to merge
Projects
None yet
Milestone
16.0
Development

Successfully merging this pull request may close these issues.
6 participants
@dsolanki-initos @PavarunCh @HviorForgeFlow @OCA-git-bot @rousseldenis @Nikul-OSI