Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[16.0][MIG] purchase_order_product_recommendation: Migration to version 16.0 #1861

Merged

Conversation

Yadier-Tecnativa
Copy link
Contributor

@Tecnativa TT42423

chienandalu and others added 30 commits April 27, 2023 23:48
- Add flag to be able to load all the products with supplier infos for
ther current customer
- If you have multiple warehouses, you can also constrain the recommendations to
the deliveries of specific ones.
…in supplierinfo

Must be commercial partner, not possible contacts put in the purchase order.
- Give the proper context when the wh filter is active to get the right
quantities available for those warehouses.
- When the wizard had a lot of lines, the price_unit computation had a
very poor performance whenenever we changed the qty to order (maybe due
to some ORM issue). Changing to an initial computation and then to a
computation on the onchange method, gets rid of the problem.
Updated by "Update PO files to match POT (msgmerge)" hook in Weblate.

Translation: purchase-workflow-12.0/purchase-workflow-12.0-purchase_order_product_recommendation
Translate-URL: https://translation.odoo-community.org/projects/purchase-workflow-12-0/purchase-workflow-12-0-purchase_order_product_recommendation/
…default code to avoid crash tests with product_code_unique module installed
- Extract domain build to an independent method for easy extension by
third modules
- Extract product filter to an independent method for easy extension.
- New product internal category filter.
- New "Show all products" filter that allows to easily show all
purchable products.
- Make tests extensible by other modules
… or not purchasable products

It includes a tests that exercises the patch.
After commit odoo/odoo@4625f3d
the warehouse is taken into account when computing the quantities.

As we are limiting the test by warehouse, the final value should be updated to the new
correctly computed.
…duct code

Added product name and product code on wizard lines for allow ordering by both
regardless of how it is displayed in display_name
@Yadier-Tecnativa Yadier-Tecnativa force-pushed the 16.0-mig-purchase_order_product_recommendation branch from 7085492 to 478bc0b Compare May 3, 2023 13:42
@Yadier-Tecnativa
Copy link
Contributor Author

ping @sergio-teruel and @pedrobaeza

@pedrobaeza
Copy link
Member

/ocabot migration purchase_order_product_recommendation

@OCA-git-bot OCA-git-bot added this to the 16.0 milestone May 3, 2023
@OCA-git-bot OCA-git-bot mentioned this pull request May 3, 2023
53 tasks
@Yadier-Tecnativa Yadier-Tecnativa force-pushed the 16.0-mig-purchase_order_product_recommendation branch from 478bc0b to 8933992 Compare May 3, 2023 20:25
Copy link
Contributor Author

@Yadier-Tecnativa Yadier-Tecnativa left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Change the width to fill all the space.

Copy link
Contributor

@pilarvargas-tecnativa pilarvargas-tecnativa left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM :)

@OCA-git-bot
Copy link
Contributor

This PR has the approved label and has been created more than 5 days ago. It should therefore be ready to merge by a maintainer (or a PSC member if the concerned addon has no declared maintainer). 🤖

@Yadier-Tecnativa Yadier-Tecnativa force-pushed the 16.0-mig-purchase_order_product_recommendation branch from 8933992 to 7424cca Compare May 4, 2023 12:34
@pedrobaeza
Copy link
Member

/ocabot merge nobump

@OCA-git-bot
Copy link
Contributor

Hey, thanks for contributing! Proceeding to merge this for you.
Prepared branch 16.0-ocabot-merge-pr-1861-by-pedrobaeza-bump-nobump, awaiting test results.

@OCA-git-bot OCA-git-bot merged commit 149a634 into OCA:16.0 May 4, 2023
@OCA-git-bot
Copy link
Contributor

Congratulations, your PR was merged at 9a43e61. Thanks a lot for contributing to OCA. ❤️

@sergio-teruel
Copy link
Contributor

ping @Juangomezzurita

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.