Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[16.0][MIG] purchase_security #1902

Merged
merged 16 commits into from
Jun 12, 2023

Conversation

dalonsod
Copy link
Contributor

@dalonsod dalonsod commented Jun 7, 2023

Includes still unmerged #1898

Made changes due to groups_id previous usage in views

joao-p-marques and others added 15 commits June 7, 2023 10:45
Create "Purchase (own orders)" group.
Restrict access to POs to those in the group.
Add tests.

TT26488
Currently translated at 100.0% (1 of 1 strings)

Translation: purchase-workflow-13.0/purchase-workflow-13.0-purchase_security
Translate-URL: https://translation.odoo-community.org/projects/purchase-workflow-13-0/purchase-workflow-13-0-purchase_security/it/
When a Purchase User (own orders) create or edit an order, if changes
Representative user to another and save it, an access error is raised.
With this change, those users cannot change the default Representative,
then orders are initially assigned to them, and no errors were fired.
With this improvement, order lines are also restricted for Own Reponsible Users,
and this addon becomes more compatible with e.g. purchase_order_line_menu.
@dalonsod dalonsod force-pushed the 16.0-mig-purchase_security2 branch from 1823a7c to 1735eca Compare June 7, 2023 10:56
@dalonsod dalonsod force-pushed the 16.0-mig-purchase_security2 branch from 1735eca to daaef5b Compare June 7, 2023 11:23
@dalonsod
Copy link
Contributor Author

dalonsod commented Jun 7, 2023

@HviorForgeFlow @pilarvargas-tecnativa could you review? Thanks!!

Copy link
Contributor

@pilarvargas-tecnativa pilarvargas-tecnativa left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thanks :)

@HviorForgeFlow
Copy link
Member

/ocabot merge nobump

@OCA-git-bot
Copy link
Contributor

Hey, thanks for contributing! Proceeding to merge this for you.
Prepared branch 16.0-ocabot-merge-pr-1902-by-HviorForgeFlow-bump-nobump, awaiting test results.

@OCA-git-bot OCA-git-bot merged commit 3e0def7 into OCA:16.0 Jun 12, 2023
@OCA-git-bot
Copy link
Contributor

Congratulations, your PR was merged at 3283342. Thanks a lot for contributing to OCA. ❤️

@pedrobaeza
Copy link
Member

/ocabot migration purchase_security

@OCA-git-bot OCA-git-bot added this to the 16.0 milestone Jun 12, 2023
@OCA-git-bot OCA-git-bot mentioned this pull request Jun 12, 2023
53 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

8 participants