Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[16.0][IMP] purchase_blanket_order: Code refactor #2194

Closed

Conversation

victoralmau
Copy link
Member

@victoralmau victoralmau commented Mar 1, 2024

Related to #2193

Changes done:

  • Removed constrains from date_planned. Implemented _compute_date_planned() to avoid inconsistencies.
  • Set blanket_order_line field as compute store.
  • Removed onchange_product_id().
  • Removed _compute_price_unit_and_date_planned_and_name().
  • Simplify onchange_blanket_order_line()
  • Improve _get_assigned_bo_line()
  • Change to setUpClass() in tests
  • purchase_only_by_packaging: Improve _compute_product_qty() to be compatible with purchase_blanket_order

@Tecnativa

- Removed constrains from date_planned. Implemented _compute_date_planned() to avoid inconsistencies.
- Set blanket_order_line field as compute store.
- Removed onchange_product_id().
- Removed _compute_price_unit_and_date_planned_and_name().
- Simplify onchange_blanket_order_line()
- Improve _get_assigned_bo_line()
- Change to setUpClass() in tests

TT46595
@victoralmau victoralmau force-pushed the 16.0-imp-purchase_blanket_order-refactor branch from f19d809 to 5dd59ef Compare March 1, 2024 10:04
@victoralmau victoralmau marked this pull request as ready for review March 1, 2024 10:08
@victoralmau
Copy link
Member Author

Changes are included directly in #2193

@victoralmau victoralmau closed this Mar 1, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant