[17.0][MIG] purchase_order_secondary_unit: Migration to 17.0 #2319

mmrondon · 2024-06-27T04:18:52Z

No description provided.

mmrondon · 2024-07-23T23:04:36Z

Depending PR:

[1560] [17.0][MIG] product_secondary_unit product-attribute#1560

alan196

Functional Review 👍

dalonsod

@mmrondon at last, this addon has been merged for v16 (see #2216) and has some improvements that come from v15 and aren't still available here. Could you take a look?

cc @sergio-teruel

sergio-teruel · 2024-11-14T09:47:53Z

Please @mmrondon Can yo sure that all commits from older version are in your PR..?
Thanks

dalonsod · 2024-11-25T09:59:34Z

Hello @mmrondon will you resume this PR soon? Thanks!

peluko00 · 2024-11-26T11:42:33Z

Hi @mmrondon, can you squash commits into one please?

…nits

TT27363

…en no product_id

…_unit mixin model from product-attribute repository.

…order reports

…n confirmed purchase

…purchases TT45090

…condary_uom_qty is filled

Fix a bug when calling super's `_compute_product_qty()` was skipping the compute helper from the mixin. @moduon MT-3483 Co-authored-by: Andrea Cattalani <22261939+anddago78@users.noreply.github.com>

… qty set to 1 Co-authored-by: David Alonso // Solvos <david.alonso@solvos.es>

…ndary quantity fields optional TT49686

…secondary uom without product in sale order line TT51683

Updated by "Update PO files to match POT (msgmerge)" hook in Weblate. Translation: purchase-workflow-16.0/purchase-workflow-16.0-purchase_order_secondary_unit Translate-URL: https://translation.odoo-community.org/projects/purchase-workflow-16-0/purchase-workflow-16-0-purchase_order_secondary_unit/

Currently translated at 100.0% (11 of 11 strings) Translation: purchase-workflow-16.0/purchase-workflow-16.0-purchase_order_secondary_unit Translate-URL: https://translation.odoo-community.org/projects/purchase-workflow-16-0/purchase-workflow-16-0-purchase_order_secondary_unit/it/

dalonsod

@mmrondon could take a look at the comments, and the changes you've added in migration commit in general? It seems that you've preserved original migration commit files changes after you've update commit history, and some changes added in recently added commits have been lost.

dalonsod · 2024-11-28T10:51:43Z

purchase_order_secondary_unit/views/purchase_order_views.xml

                    groups="uom.group_uom"
-                    optional="show"


Please don't remove this, as it was added in an recent commit, when updating commit history

dalonsod · 2024-11-28T10:51:52Z

purchase_order_secondary_unit/views/purchase_order_views.xml

                    groups="uom.group_uom"
-                    optional="show"


The same as above

dalonsod · 2024-11-28T10:56:34Z

purchase_order_secondary_unit/views/purchase_order_views.xml

+                <field
+                    name="secondary_uom_qty"
+                    class="oe_inline oe_no_button"
+                    groups="uom.group_uom"
+                    readonly="state in ['done', 'cancel']"
+                />
+                <field
+                    name="secondary_uom_id"
+                    class="oe_inline"
+                    domain="['|', ('product_id', '=', product_id),
+                                '&amp;', ('product_tmpl_id.product_variant_ids', 'in', [product_id]),
+                                         ('product_id', '=', False)]"
+                    options="{'no_create': True}"
+                    groups="uom.group_uom"
+                    readonly="state in ['purchase','done', 'cancel']"
+                    required="secondary_uom_qty != 0.0"
+                />


It seems that some later changes have been lost in this commit:

Move whole code to a <t> node.

Improvements in secondary_uom_id domain added by ee8f610

dalonsod · 2024-11-28T10:56:59Z

purchase_order_secondary_unit/views/product_views.xml

+                <field
+                    name="purchase_secondary_uom_id"
+                    options="{'no_create': True}"
+                    groups="uom.group_uom"
+                />


The same as below with <t> node

[IMP] purchase_order_secondary_unit: pre-commit auto fixes [IMP] purchase_order_secondary_unit: pre-commit auto fixes [DON'T MERGE] test-requirements.txt [Don't MERGE] Remove dependency [MIG] purchase_order_secondary_unit: Fix issue on test [IMP] purchase_order_secondary_unit: pre-commit auto fixes [IMP] purchase_order_secondary_unit: Restore commit history from version 16.0

mmrondon · 2024-11-28T22:08:54Z

hello @dalonsod sorry for that, already modified

dalonsod

There are still some things to be fixed in commit history, please check

dalonsod · 2024-11-29T17:56:17Z

purchase_order_secondary_unit/views/product_views.xml

@@ -12,6 +12,7 @@
                    <field
                        name="purchase_secondary_uom_id"
                        options="{'no_create': True}"
+                        groups="uom.group_uom"


This is redundant, the field is placed into a <t> that have already groups attribute

dalonsod · 2024-11-29T17:56:31Z

purchase_order_secondary_unit/views/purchase_order_views.xml

@@ -15,16 +15,19 @@
                    <field
                        name="secondary_uom_qty"
                        class="oe_inline oe_no_button"
-                        attrs="{'readonly': [('state', 'in', ('done', 'cancel'))]}"
+                        groups="uom.group_uom"


The same as above

dalonsod · 2024-11-29T17:56:39Z

purchase_order_secondary_unit/views/purchase_order_views.xml

                        options="{'no_create': True}"
-                        attrs="{'readonly': [('state', 'in', ('purchase', 'done', 'cancel'))], 'required': [('secondary_uom_qty', '!=', 0.0)]}"
+                        groups="uom.group_uom"


The same as above

dalonsod · 2024-11-29T18:00:17Z

purchase_order_secondary_unit/views/purchase_order_views.xml

                    />
                    <field
                        name="secondary_uom_id"
                        class="oe_inline"
-                        domain="product_id and ['|', ('product_id', '=', product_id),
+                        domain="['|', ('product_id', '=', product_id),


domain definition is still the old one, changes added by ee8f610 are lost, please check diff at this point.

dalonsod · 2024-12-09T08:47:12Z

Hello @mmrondon would you resume this PR and attend pending comments? Thanks!

dalonsod · 2024-12-17T15:48:59Z

Superseded by #2492

mmrondon force-pushed the 17.0-mig-purchase_order_secondary_unit branch from 66ede93 to ef3d474 Compare July 23, 2024 23:01

mmrondon force-pushed the 17.0-mig-purchase_order_secondary_unit branch from 59ff20b to 6af60e8 Compare July 23, 2024 23:54

mmrondon force-pushed the 17.0-mig-purchase_order_secondary_unit branch from 6af60e8 to 6f4471c Compare September 26, 2024 21:46

mmrondon force-pushed the 17.0-mig-purchase_order_secondary_unit branch 3 times, most recently from 463db35 to 45ec32e Compare October 9, 2024 22:26

alan196 approved these changes Oct 29, 2024

View reviewed changes

dalonsod suggested changes Nov 14, 2024

View reviewed changes

sergio-teruel and others added 18 commits November 27, 2024 13:35

purchase_order_secondary_unit: New module to allow buy in secondary u…

41d44fc

…nits

[MIG] purchase_order_secondary_unit v11 to v12

ce195eb

[IMP] purchase_order_secondary_unit: black, isort

8ad6fd3

[MIG] purchase_order_secondary_unit: Migration to 13.0

53cb0c5

[IMP] purchase_order_secondary_unit: more clear string field

c813c6e

TT27363

[13.0][FIX] purchase_order_secondary_unit, error selecting 2nd_uom wh…

5b6c7f0

…en no product_id

[MIG] purchase_order_secondary_unit: Migration to 14.0

555728f

Added translation using Weblate (Japanese)

082faba

Added translation using Weblate (French)

e53f93c

[IMP] purchase_order_secondary_unit: Less code. Use product_secondary…

3f76c1f

…_unit mixin model from product-attribute repository.

[FIX] po_secondary_unit: Drop 0 qty test check on pol with secondary UoM

5ff6f01

Added translation using Weblate (German)

aa91dc9

[IMP] purchase_order_secondary_unit: black, isort, prettier

594b4d1

[15.0][MIG] purchase_order_secondary_unit: Migration to 15.0

bf4867f

[IMP] purchase_order_secondary_unit: Compatibility with product variants

e47822f

[FIX] purchase_order_secondary_unit: Split tests

f08d731

[IMP] purchase_order_secondary_unit: Add secondary units to purchase …

2bb348f

…order reports

[FIX] purchase_order_secondary_unit: User can changes secondary uom i…

7aa243c

…n confirmed purchase

pilarvargas-tecnativa and others added 12 commits November 27, 2024 13:35

[FIX] purchase_order_secondary_unit: Set product unit of measure for …

26a9585

…purchases TT45090

[IMP] purchase_order_secondary_unit: Require secondary_uom_id when se…

8294b11

…condary_uom_qty is filled

[MIG] purchase_order_secondary_unit: Migration to v16

2a27fa1

[FIX] purchase_order_secondary_unit: bug calling super()

c5983a2

Fix a bug when calling super's `_compute_product_qty()` was skipping the compute helper from the mixin. @moduon MT-3483 Co-authored-by: Andrea Cattalani <22261939+anddago78@users.noreply.github.com>

[FIX] purchase_order_secondary_unit: precompute for some fields & sec…

4055083

… qty set to 1 Co-authored-by: David Alonso // Solvos <david.alonso@solvos.es>

[IMP] purchase_order_secondary_unit: make the secondary unit and seco…

8c0fa81

…ndary quantity fields optional TT49686

[FIX] purchase_order_secondary_unit: Error when user try to select a …

11b06ce

…secondary uom without product in sale order line TT51683

[UPD] Update purchase_order_secondary_unit.pot

96a635c

[BOT] post-merge updates

4dbd6ef

Added translation using Weblate (Italian)

d17af47

mmrondon force-pushed the 17.0-mig-purchase_order_secondary_unit branch from 45ec32e to b1b632f Compare November 27, 2024 19:52

dalonsod suggested changes Nov 28, 2024

View reviewed changes

mmrondon force-pushed the 17.0-mig-purchase_order_secondary_unit branch from b1b632f to 4dd8a17 Compare November 28, 2024 22:02

dalonsod suggested changes Nov 29, 2024

View reviewed changes

dalonsod mentioned this pull request Dec 17, 2024

[17.0][MIG] purchase_order_secondary_unit: Migration to 17.0 #2492

Merged

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

[17.0][MIG] purchase_order_secondary_unit: Migration to 17.0 #2319

[17.0][MIG] purchase_order_secondary_unit: Migration to 17.0 #2319

mmrondon commented Jun 27, 2024

mmrondon commented Jul 23, 2024 •

edited

Loading

alan196 left a comment

dalonsod left a comment

sergio-teruel commented Nov 14, 2024 •

edited

Loading

dalonsod commented Nov 25, 2024

peluko00 commented Nov 26, 2024

dalonsod left a comment

dalonsod Nov 28, 2024

dalonsod Nov 28, 2024

dalonsod Nov 28, 2024

dalonsod Nov 28, 2024

mmrondon commented Nov 28, 2024

dalonsod left a comment

dalonsod Nov 29, 2024

dalonsod Nov 29, 2024

dalonsod Nov 29, 2024

dalonsod Nov 29, 2024

dalonsod commented Dec 9, 2024

dalonsod commented Dec 17, 2024

[17.0][MIG] purchase_order_secondary_unit: Migration to 17.0 #2319

Are you sure you want to change the base?

[17.0][MIG] purchase_order_secondary_unit: Migration to 17.0 #2319

Conversation

mmrondon commented Jun 27, 2024

mmrondon commented Jul 23, 2024 • edited Loading

alan196 left a comment

Choose a reason for hiding this comment

dalonsod left a comment

Choose a reason for hiding this comment

sergio-teruel commented Nov 14, 2024 • edited Loading

dalonsod commented Nov 25, 2024

peluko00 commented Nov 26, 2024

dalonsod left a comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

mmrondon commented Nov 28, 2024

dalonsod left a comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

dalonsod commented Dec 9, 2024

dalonsod commented Dec 17, 2024

mmrondon commented Jul 23, 2024 •

edited

Loading

sergio-teruel commented Nov 14, 2024 •

edited

Loading