Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[16.0] [MIG] rma #336

Closed
wants to merge 115 commits into from
Closed

[16.0] [MIG] rma #336

wants to merge 115 commits into from

Conversation

Murtaza-OSI
Copy link

No description provided.

Ernesto Tejeda and others added 30 commits December 28, 2022 10:46
[UPD] Update rma.pot

Update translation files

Updated by "Update PO files to match POT (msgmerge)" hook in Weblate.

Translation: rma-12.0/rma-12.0-rma
Translate-URL: https://translation.odoo-community.org/projects/rma-12-0/rma-12-0-rma/
…flow + Translated using Weblate (Spanish)

[FIX] rma: views permissions

Regular users don't have permissions to rma models, so we should avoid
loading views that lead to permission errors.

TT24986

rma 12.0.1.1.0

Update translation files

Updated by "Update PO files to match POT (msgmerge)" hook in Weblate.

Translation: rma-12.0/rma-12.0-rma
Translate-URL: https://translation.odoo-community.org/projects/rma-12-0/rma-12-0-rma/

[FIX] rma: portal views access errors

- Portal mail thread needs token config.
- Unpublished products will raise AccessError on RMAs portal views for
portal users due to record rules.
- Ensure active_id when getting actions in rma, since we could come from
a context that pollutes the expected active rma id.

[IMP] rma: teams flow

- If no RMA Team is set, we'll assign a default one to the new RMA.
- A sequence is now used to search for the top team and assign it.
- No default user is assigned when it's not in the context (i.e. portal
rmas).

[UPD] Update rma.pot

rma 12.0.1.2.0

Update translation files

Updated by "Update PO files to match POT (msgmerge)" hook in Weblate.

Translation: rma-12.0/rma-12.0-rma
Translate-URL: https://translation.odoo-community.org/projects/rma-12-0/rma-12-0-rma/

Translated using Weblate (Spanish)

Currently translated at 96.2% (253 of 263 strings)

Translation: rma-12.0/rma-12.0-rma
Translate-URL: https://translation.odoo-community.org/projects/rma-12-0/rma-12-0-rma/es/
- Fix thrown error when trying to download a picking from the portal.
- Add the hook method to prepare RMA values ​​from the return pick wizard.
- Add the access rule for portal users.
- Show the portal 'Request RMAs' button on the sales page only to users
related to the sales order.

[UPD] Update rma.pot

rma 12.0.1.3.0

Update translation files

Updated by "Update PO files to match POT (msgmerge)" hook in Weblate.

Translation: rma-12.0/rma-12.0-rma
Translate-URL: https://translation.odoo-community.org/projects/rma-12-0/rma-12-0-rma/
Currently translated at 100.0% (263 of 263 strings)

Translation: rma-12.0/rma-12.0-rma
Translate-URL: https://translation.odoo-community.org/projects/rma-12-0/rma-12-0-rma/es/
- Avoid permission blockings on users who doesn't have RMA permissions.
- Add activities view on RMA list.

[UPD] Update rma.pot

rma 12.0.1.3.1
Update translation files

Updated by "Update PO files to match POT (msgmerge)" hook in Weblate.

Translation: rma-12.0/rma-12.0-rma
Translate-URL: https://translation.odoo-community.org/projects/rma-12-0/rma-12-0-rma/
- Now it's possible to open several RMAs in a sale order from the portal
- A new comment button has been added to allow the portal user to enter
relevant information like serial numbers o issue description.
- If the requested operation isn't set no RMA will be opened
- The RMA product qty is now a numeric control with limits according to
the qty available to return

[FIX] rma,rma_sale: fix linter errors

[UPD] Update rma.pot

rma 12.0.1.4.0

Update translation files

Updated by "Update PO files to match POT (msgmerge)" hook in Weblate.

Translation: rma-12.0/rma-12.0-rma
Translate-URL: https://translation.odoo-community.org/projects/rma-12-0/rma-12-0-rma/
Not indicating account.invoice, it takes the default that is the vendor bill view.
We force the suitable one.
…ype use existing lot by default.

[IMP] rma: set rma to received on invoice delete.

Remove 'waiting_refund' rma state.
RMAs go from received to refunded.
When the linked refund is deleted the rma is set to received.

[UPD] Update rma.pot

rma 12.0.1.4.2

Update translation files

Updated by "Update PO files to match POT (msgmerge)" hook in Weblate.

Translation: rma-12.0/rma-12.0-rma
Translate-URL: https://translation.odoo-community.org/projects/rma-12-0/rma-12-0-rma/

[IMP] rma: incoming picking type use existing lot by default.

rma 12.0.1.4.3
…ngs:

[FIX+IMP] rma: usability

* IMP - Now the description will be an html son we can show rich styles
in the customers report.
* FIX - On locked sale orders it was need to unlock them to be able to open an RMA.
* IMP - Make the description label visible in the backend form so the
user can easily spot it.
* IMP - Added date and deadline filters.
* IMP - Added pending RMAs filter.
* IMP - Added late RMAs filter.
* IMP - Added danger decoration in tree view

rma 12.0.1.5.0

[UPD] Update rma.pot

Update translation files

Updated by "Update PO files to match POT (msgmerge)" hook in Weblate.

Translation: rma-12.0/rma-12.0-rma
Translate-URL: https://translation.odoo-community.org/projects/rma-12-0/rma-12-0-rma/

Translated using Weblate (Spanish)

Currently translated at 100.0% (268 of 268 strings)

Translation: rma-12.0/rma-12.0-rma
Translate-URL: https://translation.odoo-community.org/projects/rma-12-0/rma-12-0-rma/es/

[FIX] rma: return permissions

When a user with no stock manager permissions was doing the return, an
access error would raise.

rma 12.0.1.5.1

[FIX] rma: multicompany returns

The move was created with the default company

[UPD] Update rma.pot

rma 12.0.1.5.2

Update translation files

Updated by "Update PO files to match POT (msgmerge)" hook in Weblate.

Translation: rma-12.0/rma-12.0-rma
Translate-URL: https://translation.odoo-community.org/projects/rma-12-0/rma-12-0-rma/

[FIX] rma: non rma users confirm

The sudo had to be before calling the records

rma 12.0.1.5.3

[FIX] rma: pass company as record to procurement

This upstream commit expects `company_id` as a record instead of as an
integer id: odoo/odoo@836ff55

rma 12.0.1.5.4

[FIX] rma: internal users portal

Internal users with no RMA permissions got an access error when entering
the portal

[UPD] Update rma.pot

rma 12.0.1.6.0

Update translation files

Updated by "Update PO files to match POT (msgmerge)" hook in Weblate.

Translation: rma-12.0/rma-12.0-rma
Translate-URL: https://translation.odoo-community.org/projects/rma-12-0/rma-12-0-rma/
Updated by "Update PO files to match POT (msgmerge)" hook in Weblate.

Translation: rma-13.0/rma-13.0-rma
Translate-URL: https://translation.odoo-community.org/projects/rma-13-0/rma-13-0-rma/
Updated by "Update PO files to match POT (msgmerge)" hook in Weblate.

Translation: rma-13.0/rma-13.0-rma
Translate-URL: https://translation.odoo-community.org/projects/rma-13-0/rma-13-0-rma/
Currently translated at 6.7% (18 of 270 strings)

Translation: rma-13.0/rma-13.0-rma
Translate-URL: https://translation.odoo-community.org/projects/rma-13-0/rma-13-0-rma/ro/
Currently translated at 7.4% (20 of 270 strings)

Translation: rma-13.0/rma-13.0-rma
Translate-URL: https://translation.odoo-community.org/projects/rma-13-0/rma-13-0-rma/ro/
Currently translated at 40.3% (109 of 270 strings)

Translation: rma-13.0/rma-13.0-rma
Translate-URL: https://translation.odoo-community.org/projects/rma-13-0/rma-13-0-rma/ro/
Currently translated at 62.2% (168 of 270 strings)

Translation: rma-13.0/rma-13.0-rma
Translate-URL: https://translation.odoo-community.org/projects/rma-13-0/rma-13-0-rma/ro/
Currently translated at 1.8% (5 of 270 strings)

Translation: rma-13.0/rma-13.0-rma
Translate-URL: https://translation.odoo-community.org/projects/rma-13-0/rma-13-0-rma/zh_CN/
When a sale line has a phantom product (mrp kits) the RMA would not be
possible as the wizard couldn't pair the components moves with the
product in the line. With this approach, we can at least return the
spare components of the original kit line.

We also need some hooks to intervine in the main methods, like in
invoicing.
Nikolaus Weingartmair and others added 9 commits December 28, 2022 10:46
Currently translated at 100.0% (354 of 354 strings)

Translation: rma-15.0/rma-15.0-rma
Translate-URL: https://translation.odoo-community.org/projects/rma-15-0/rma-15-0-rma/de/
The product replacement could explode into several moves like in the
case of MRP BoM kits.

TT40194
Currently translated at 99.4% (346 of 348 strings)

Translation: rma-15.0/rma-15.0-rma
Translate-URL: https://translation.odoo-community.org/projects/rma-15-0/rma-15-0-rma/it/
Currently translated at 100.0% (348 of 348 strings)

Translation: rma-15.0/rma-15.0-rma
Translate-URL: https://translation.odoo-community.org/projects/rma-15-0/rma-15-0-rma/it/
@rousseldenis
Copy link
Contributor

/ocabot migration rma

@rousseldenis
Copy link
Contributor

@Murtaza-OSI Thanks for this. Could you follow migration guide (especially full process) ? https://github.com/OCA/maintainer-tools/wiki/Migration-to-version-16.0

Your commit message for pre-commit fixes should be renamed

@Murtaza-OSI Murtaza-OSI force-pushed the 16.0-MIG-rma branch 3 times, most recently from 131162b to b5a7287 Compare February 14, 2023 10:04
@pablontura
Copy link

Functional review. If I try to replace a product or access the RMA smartbutton in the original shipment, I get these errors:

reemplazo
Smartbutton

@rousseldenis
Copy link
Contributor

@Murtaza-OSI Could you fix tests ?

@agyamuta
Copy link

@Murtaza-OSI Could you fix tests ?

@Murtaza-OSI can you please check on this and fix? Thank you.

@Murtaza-OSI
Copy link
Author

Functional review. If I try to replace a product or access the RMA smartbutton in the original shipment, I get these errors:

reemplazo Smartbutton

Issue fix pls check

@QubiQBcn
Copy link

Functional review. If I try to replace a product or access the RMA smartbutton in the original shipment, I get these errors:
reemplazo Smartbutton

Issue fix pls check

The smartbutton is now working, but I keep getting the same error when doing a replace...

ErrorRMA

@agyamuta
Copy link

agyamuta commented Jun 1, 2023

@Murtaza-OSI can you please work on this again? Thanks.

@pedrobaeza
Copy link
Member

Superseded by the CI-green PR and with heavy refactoring #361. Please review it.

@pedrobaeza pedrobaeza closed this Aug 24, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.