Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[15.0][IMP] base_user_role: users validation #251

Closed

Conversation

polqubiq
Copy link

Add a restriction to make sure the Administrator user isn't included in the Users of the Roles.
This helps avoid problems that come up when you add the admin user there, like replacing all permissions based on the role's groups.

@OCA-git-bot
Copy link
Contributor

Hi @sebalix, @novawish, @jcdrubay,
some modules you are maintaining are being modified, check this out!

Copy link
Contributor

@legalsylvain legalsylvain left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

set a role to the admin user can be a valid use case.

Such extra restriction should be done in a custom module IMO.

@polqubiq polqubiq force-pushed the 15.0-imp-base_user_role_users_validation branch from 823941a to 89067fa Compare November 21, 2023 09:14
@polqubiq
Copy link
Author

set a role to the admin user can be a valid use case.

Such extra restriction should be done in a custom module IMO.

Okay, it makes sense.

@polqubiq polqubiq closed this Nov 21, 2023
SiesslPhillip pushed a commit to grueneerde/OCA-server-backend that referenced this pull request Nov 20, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants