Add new module: materialized sql view #110

petrus-v · 2015-01-09T17:05:46Z

Hi,

I'm Pierre Verkest from Anybox, I'm pretty new in OCA and not sure about
the workflow to add new modules. Anyway this is a module we developed
on bitbucket.

I'm glad to contribute and dive into OCA tools and thanks @legalsylvain who
ask us to push this materialized_sql_view module here.

If you want to know more about this module you can read materialized_sql_view
module description in __openerp__.py.

I had to separate tests in an other module as I would tested the module with a
real model but wouldn't see it on production servers.

I already prepare a branch running under v7
I guess if it's like odoo workflow I haven't to make a PR on both branches (7.0 and 8.0) ?

I was surprised some tested pass in Travis, like this one:
https://travis-ci.org/petrus-v/server-tools/builds/46459751 based on this
commit: petrus-v@ab614ed
which should failed.

regards,

coveralls · 2015-01-09T17:34:43Z

Coverage increased (+11.1%) when pulling 53ae7ee on petrus-v:8.0-materialized_sql_view into 271e515 on OCA:8.0.

clonedagain · 2015-01-09T20:05:32Z

materialized_sql_view/__openerp__.py

+# =============================================================================
+{
+    'name': 'Materialized Sql View',
+    'version': '0.0.1',


I think 0.1 would suffice.

clonedagain · 2015-01-09T20:36:11Z

That looks nice. I wonder if you couldn't simplify the code by dropping the legacy postgresql option. PG 9.3 has been available for quite some time and is the version recommanded by odoo SA.

coveralls · 2015-01-09T21:26:51Z

Coverage increased (+11.1%) when pulling e916338 on petrus-v:8.0-materialized_sql_view into 271e515 on OCA:8.0.

petrus-v · 2015-01-09T22:26:22Z

@clonedagain,
Yes it could be easier if we had to support only one PG version, but we made it because we need it for our customer. Unfortunately we don't manage hosting for him, and it can take a while to make a plan with three parts (customer/hoster/IT integrator).

I could say with experience, companies (mainly true bigger they are) are afraid about change when we talk about their tool whose all employees depends so I'm sure I will find PG9.2 on servers for a couple years!

As you can see, if the PG cluster version is upgraded the module take care about it and will drop and recreate the view against the good version.

I hope the effort to maintain multi PG version will be benefit for the community we have also ideas to enhance this module which could explain some choices:

PG9.4 which was released in December introduce a new option CONCURRENTLY which could be easily introduce in this module by patterns we had chosen.
using different strategies to refresh materialized view
Display on the UI the last refresh date until data was collected
Provide a dependency refresh engine (in case of some materialized view depend of some other)

Thanks for your review, I already push the version to 0.1 as recommended.

petrus-v · 2015-01-10T21:08:19Z

I had not seen that @legalsylvain made the issue #101 before asking us by email which is related to this PR.

yvaucher · 2015-01-16T17:14:45Z

materialized_sql_view/__openerp__.py

+    'name': 'Materialized Sql View',
+    'version': '0.1',
+    'category': 'Tools',
+    'description': """


In v8.0 description can be put in README.rst to be visible both in github and on Odoo

You can find a sample here:
https://github.com/OCA/maintainers-tools/blob/master/template/module/README.rst

Thanks for having created README.rst

Now you just need to remove description key from __openerp__.py

yvaucher · 2015-01-16T17:15:58Z

fr.po is there but pot file is missing

hbrunn · 2015-02-02T08:48:10Z

@clonedagain current CentOS ships with postgresql 9.2, so I think it's definitely worthwhile to support that. The code looks good to me, after the README.rst issue and the missing pot file is fixed, I think this is good to merge.

legalsylvain · 2015-02-02T08:53:38Z

👍 (Code review, No test.)

petrus-v · 2015-02-02T09:25:24Z

Sorry I'm quite busy actually, sure I will take in consideration your advices. I also have to push a fixe that we figure out using it on production (a use case when it's crash by space missing on the Postgresql temp directory partition ) !

I'll do it this week!

petrus-v · 2015-02-02T23:02:12Z

My apologies to reviewers I've just realized it's probably not fair to add capabilities (commit cbbdc16) after your reviews on the module.

clonedagain · 2015-02-03T08:51:21Z

@petrus-v I think it's OK to improve before merging, as long as you notify the reviewers. I prefer that than a new PR.

yvaucher · 2015-02-03T08:54:10Z

Restarted 3rd job of travis. Due to an error when pulling dependencies:

ImportError: No module named pytz

Not the first time I see this.

yvaucher · 2015-02-03T08:56:01Z

BTW @petrus-v don't mind squashing those pep8 / pylint commit. That doesn't help much in history.

petrus-v · 2015-02-17T11:04:38Z

I've just rebase the PR to have a look what's happen!

StefanRijnhart · 2015-06-02T15:42:54Z

Looks good (no test). Is travis just not completing its job or has it just been restarted?

nbessi · 2015-06-02T16:05:30Z

materialized_sql_view/__openerp__.py

+    'name': 'Materialized Sql View',
+    'version': '0.1',
+    'category': 'Tools',
+    'author': 'Pierre Verkest',


Please put OCA in the author as second author

when updating modules containing materialized sql view, _sql_mat_view_name wasn't defined, so the sql view was always recreated on updating

In some case it could result in the situation where the materialized sql view or the sql view are not exist anymore, so it'll failed on the next refresh by trying delete rows on an nonexistent table. We met this issue on pg9.2 when we refresh a view that needs to write 4GB temporary files on FS without enough free space. After add space on the partition click on the refresh button was not able to re-create the materialized view as well. Now we can

we have to fix that issue in a proper way in the concerned module

mandatory attributes

also rename too long method name

Cedric-Pigeon · 2016-10-12T14:01:00Z

@petrus-v Do you plan to finish this PR ? Thanks.

petrus-v · 2016-10-12T14:29:43Z

@Cedric-Pigeon I've done some works last code sprint!

I'm gonna push it right now, helps is welcome however! Today I only use version 7!

…th-setup [ADD] change module version to oca pre-requisites and add setup

gurneyalex

could you fix the two small issues and rebase the PR?

gurneyalex · 2017-05-20T13:26:17Z

test_materialized_sql_view/tests/test_abstract_materialized_sql_view.py

+        sql = self.demo_matview_mdl.sql_view_definition
+        self.demo_matview_mdl._sql_view_definition = None
+        with self.assertRaises(ValueError):
+            self.demo_matview_mdl.sql_view_definition


use

sql = self.demo_matview_mdl.sql_view_definition

gurneyalex · 2017-05-20T13:29:42Z

test_materialized_sql_view/tests/test_abstract_materialized_sql_view.py

+
+    def setUp(self):
+        super(AbstractMaterializedSqlViewTester, self).setUp()
+        self.demo_matview_mdl = self.env['test.materialized.view'].with_context(


line too long (79 char max)

pedrobaeza · 2018-04-28T22:53:51Z

This has been stalled for a long time. It's an interesting idea, but it seems unfinished. If someone wants to revive this, please open a new PR.

legalsylvain · 2018-05-13T11:58:48Z

materialized view can now be generated by bi_sql_editor OCA module.

Syncing from upstream OCA/server-tools (10.0)

clonedagain reviewed Jan 9, 2015
View reviewed changes

yvaucher reviewed Jan 16, 2015
View reviewed changes

hbrunn added 8.0 needs review labels Feb 2, 2015

legalsylvain mentioned this pull request Feb 2, 2015

Framework Module for Materialized view #101

Closed

petrus-v force-pushed the 8.0-materialized_sql_view branch from 7e2e4e9 to 00f32e5 Compare February 17, 2015 11:01

max3903 removed the 8.0 label Feb 17, 2015

max3903 added this to the 8.0 milestone Feb 17, 2015

petrus-v force-pushed the 8.0-materialized_sql_view branch from 00f32e5 to 2b59a21 Compare June 2, 2015 13:39

nbessi reviewed Jun 2, 2015
View reviewed changes

Pierre Verkest added 19 commits October 4, 2016 16:08

use openerp transactionCase

b7ddd88

remove anybox.testing.openerp dependency

098049b

Fix utest launching from openerp unitest tools

c2aa47f

Add documentation in the module description

d9feee5

fix version 0.1

fdd4860

Move doc to README.rst

1c148b9

add translation

b627517

Forgot to initialize attributes

99ebdaa

when updating modules containing materialized sql view, _sql_mat_view_name wasn't defined, so the sql view was always recreated on updating

flake8

7accefd

Completly remove description in __openerp__.py

8859391

remove mail depends in test module

67624d2

we have to fix that issue in a proper way in the concerned module

add OCA author

1fc393a

None as default value

18f5fbc

use property decorator to properly manage default and

3f5765f

mandatory attributes

Raise ValueError instead orm_except

26cefd6

Do not drop view in CASCADE

a5bca66

start moving v8 API

ba1da1f

Update according OCA template

6f90424

also rename too long method name

refactoring + fix some issues

0da27bc

petrus-v force-pushed the 8.0-materialized_sql_view branch from 4437caa to 0da27bc Compare October 12, 2016 14:38

Cédric Pigeon and others added 2 commits April 25, 2017 16:42

[ADD] change module version to oca pre-requisites and add setup

a81ecee

Merge pull request #4 from Cedric-Pigeon/8.0-materialized_sql_view-wi…

75f2ad5

…th-setup [ADD] change module version to oca pre-requisites and add setup

gurneyalex requested changes May 20, 2017

View reviewed changes

pedrobaeza closed this Apr 28, 2018

SiesslPhillip pushed a commit to grueneerde/OCA-server-tools that referenced this pull request Nov 20, 2024

Merge pull request OCA#110 from OCA/10.0

83d06e3

Syncing from upstream OCA/server-tools (10.0)

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Add new module: materialized sql view #110

Add new module: materialized sql view #110

petrus-v commented Jan 9, 2015

coveralls commented Jan 9, 2015

clonedagain Jan 9, 2015

clonedagain commented Jan 9, 2015

coveralls commented Jan 9, 2015

petrus-v commented Jan 9, 2015

petrus-v commented Jan 10, 2015

yvaucher Jan 16, 2015

yvaucher Feb 3, 2015

yvaucher commented Jan 16, 2015

hbrunn commented Feb 2, 2015

legalsylvain commented Feb 2, 2015

petrus-v commented Feb 2, 2015

petrus-v commented Feb 2, 2015

clonedagain commented Feb 3, 2015

yvaucher commented Feb 3, 2015

yvaucher commented Feb 3, 2015

petrus-v commented Feb 17, 2015

StefanRijnhart commented Jun 2, 2015

nbessi Jun 2, 2015

Cedric-Pigeon commented Oct 12, 2016

petrus-v commented Oct 12, 2016

gurneyalex left a comment

gurneyalex May 20, 2017

gurneyalex May 20, 2017

pedrobaeza commented Apr 28, 2018

legalsylvain commented May 13, 2018 •

edited

Loading

Add new module: materialized sql view #110

Add new module: materialized sql view #110

Conversation

petrus-v commented Jan 9, 2015

coveralls commented Jan 9, 2015

clonedagain Jan 9, 2015

Choose a reason for hiding this comment

clonedagain commented Jan 9, 2015

coveralls commented Jan 9, 2015

petrus-v commented Jan 9, 2015

petrus-v commented Jan 10, 2015

yvaucher Jan 16, 2015

Choose a reason for hiding this comment

yvaucher Feb 3, 2015

Choose a reason for hiding this comment

yvaucher commented Jan 16, 2015

hbrunn commented Feb 2, 2015

legalsylvain commented Feb 2, 2015

petrus-v commented Feb 2, 2015

petrus-v commented Feb 2, 2015

clonedagain commented Feb 3, 2015

yvaucher commented Feb 3, 2015

yvaucher commented Feb 3, 2015

petrus-v commented Feb 17, 2015

StefanRijnhart commented Jun 2, 2015

nbessi Jun 2, 2015

Choose a reason for hiding this comment

Cedric-Pigeon commented Oct 12, 2016

petrus-v commented Oct 12, 2016

gurneyalex left a comment

Choose a reason for hiding this comment

gurneyalex May 20, 2017

Choose a reason for hiding this comment

gurneyalex May 20, 2017

Choose a reason for hiding this comment

pedrobaeza commented Apr 28, 2018

legalsylvain commented May 13, 2018 • edited Loading

legalsylvain commented May 13, 2018 •

edited

Loading