Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[16.0][MIG] auto_backup #2712

Merged
merged 50 commits into from
Dec 1, 2023
Merged

[16.0][MIG] auto_backup #2712

merged 50 commits into from
Dec 1, 2023

Conversation

tafaRU
Copy link
Member

@tafaRU tafaRU commented Sep 11, 2023

Superseeds #2514 and #2651

@tafaRU tafaRU marked this pull request as ready for review September 11, 2023 12:38
@tafaRU
Copy link
Member Author

tafaRU commented Sep 11, 2023

@manuelcalerosolis @dalonsod would you mind reviewing this? Here I have only made a standard migration and squash the Bot commits. Thank you in advance.

This was referenced Sep 11, 2023
Closed
Closed
@manuelcalerosolis
Copy link

It's ok for me.

Thanks

@thomaspaulb
Copy link
Contributor

/ocabot migration auto_backup

@OCA-git-bot OCA-git-bot added this to the 16.0 milestone Oct 6, 2023
@OCA-git-bot OCA-git-bot mentioned this pull request Oct 6, 2023
Open
33 tasks
@thomaspaulb
Copy link
Contributor

@tafaRU please fix pre-commit

Yenthe666 and others added 20 commits December 1, 2023 16:50
@Yenthe666 @tafaRU
Update english pot file
a29a588 
Added all the new fields and sentences. This will be the template for
translations.
@archetipo @tafaRU
Open FTP session on the last moment possible
23c6261 
Used to open  fp = open(file_path,'wb') a few lines before it was needed. This shouldn't be too much of a problem but opening and closing it right after eachother keeps the session open for less time and there are less chances on failure.
@tafaRU
[auto_backup] Refactor.
3295a72 
- Follow template README.
- Remove HTML README.
- Move models to models folder.
- Model and view file names follow guidelines.
- Unused methods cleanup.
- Remove unneeded `.pot` file.
- Fix permissons.
- Follow PEP8 in names everywhere.
- Set more descriptive field names.
- Disable backups for other databases, for security.
- Remove db name from generated file, for easier cleanup.
- EAFP logic everywhere.
- More descriptive name.
- Data files moved to YAML, with cleaner ir.cron record creation.
- Add permissions for db.backup model.
- Icons.
- Update tests with new format.
- Storage method is a selectable, for easier extensibility.
- Instead of custom mailing, it just has a mail thread where you can subscribe.
- Should fix almost all comments in OCA#203.
- Reduce headers.

This respects the upstream license choice (GPL/AGPL) but reduces
verbosity.

It would be ideal to have everything under AGPL though.
@archetipo @tafaRU
FIX License type
4c92b20
@jabibi @tafaRU
[FIX] auto_backup: bad reference to field sftp_private_key (OCA#423)
4393b3e 
Bump module version to 8.0.1.0.1
@bealdav @tafaRU
[FIX] logger db_backup for pysftp (OCA#419)
4d82d1f
@sbidoul @tafaRU
[FIX] remove en.po that was erroneously created by transbot
4b82862
@lasley @tafaRU
[MIG] auto_backup: Migrate to v9
98d4864 
* Add self.ensure_ones
* Add test coverage
@Yenthe666 @tafaRU
[auto_backup] FIX: failure type notification
fc6e8ab 
Fixes OCA#710
@astirpe @tafaRU
[10.0][auto_backup] Menu entry moved (OCA#735)
18aa6c6 
* [10.0][auto_backup] Menu entry moved

* Update version in manifest
@eLBati @tafaRU
FIX sftp unlink path (OCA#767)
df31a9e
@astirpe @tafaRU
Fix icon Test SFTP Connection (OCA#825)
cc77768
@astirpe @tafaRU
[11.0][MIG] auto_backup
56f1564
@sbidoul @tafaRU
[FIX] syntax error in nl.po
37e1664
@JosDeGraeve @tafaRU
Translated using Weblate (Dutch)
5bd35b6 
Currently translated at 58.2% (32 of 55 strings)

Translation: server-tools-11.0/server-tools-11.0-auto_backup
Translate-URL: https://translation.odoo-community.org/projects/server-tools-11-0/server-tools-11-0-auto_backup/nl/
@pedrobaeza @tafaRU
[FIX] auto_backup: Fix NL translation
17da338
@foutoucour @tafaRU
auto_backup: allow to change the format of backup (OCA#1333)
507b351
@aitorbouzas @tafaRU
[MIG] auto_backup: Migration to 12.0
73c4e91 
Added test coverage
Added requirements.txt for pysftp
Added in the roadmap the exact version of pysftp for this to work (0.2.8)
Added in the roadmap the problem with list_db=False
Adapted calls to message_post
@tafaRU
Translated using Weblate (Portuguese (Brazil))
d3fd32b 
Currently translated at 17.5% (14 of 80 strings)

Translation: server-tools-12.0/server-tools-12.0-auto_backup
Translate-URL: https://translation.odoo-community.org/projects/server-tools-12-0/server-tools-12-0-auto_backup/pt_BR/
@liweijie0812 @tafaRU
Translated using Weblate (Chinese (Simplified))
f400347 
Currently translated at 26.2% (21 of 80 strings)

Translation: server-tools-12.0/server-tools-12.0-auto_backup
Translate-URL: https://translation.odoo-community.org/projects/server-tools-12-0/server-tools-12-0-auto_backup/zh_CN/
primes2h and others added 18 commits December 1, 2023 16:50
@primes2h @tafaRU
Translated using Weblate (Italian)
f95b3bd 
Currently translated at 86.0% (74 of 86 strings)

Translation: server-tools-14.0/server-tools-14.0-auto_backup
Translate-URL: https://translation.odoo-community.org/projects/server-tools-14-0/server-tools-14-0-auto_backup/it/
@primes2h @tafaRU
Translated using Weblate (Italian)
e9612e7 
Currently translated at 89.5% (77 of 86 strings)

Translation: server-tools-14.0/server-tools-14.0-auto_backup
Translate-URL: https://translation.odoo-community.org/projects/server-tools-14-0/server-tools-14-0-auto_backup/it/
@primes2h @tafaRU
Translated using Weblate (Italian)
7c8ee59 
Currently translated at 94.1% (81 of 86 strings)

Translation: server-tools-14.0/server-tools-14.0-auto_backup
Translate-URL: https://translation.odoo-community.org/projects/server-tools-14-0/server-tools-14-0-auto_backup/it/
@extrememicro @tafaRU
Translated using Weblate (Catalan)
bbad458 
Currently translated at 9.3% (8 of 86 strings)

Translation: server-tools-14.0/server-tools-14.0-auto_backup
Translate-URL: https://translation.odoo-community.org/projects/server-tools-14-0/server-tools-14-0-auto_backup/ca/
@ibuioli @tafaRU
Translated using Weblate (Spanish (Argentina))
ad9d8e5 
Currently translated at 100.0% (86 of 86 strings)

Translation: server-tools-14.0/server-tools-14.0-auto_backup
Translate-URL: https://translation.odoo-community.org/projects/server-tools-14-0/server-tools-14-0-auto_backup/es_AR/
@rbellanova @tafaRU
Translated using Weblate (Italian)
ba420ad 
Currently translated at 94.1% (81 of 86 strings)

Translation: server-tools-14.0/server-tools-14.0-auto_backup
Translate-URL: https://translation.odoo-community.org/projects/server-tools-14-0/server-tools-14-0-auto_backup/it/
@badbole @tafaRU
Translated using Weblate (Croatian)
a111661 
Currently translated at 50.0% (43 of 86 strings)

Translation: server-tools-14.0/server-tools-14.0-auto_backup
Translate-URL: https://translation.odoo-community.org/projects/server-tools-14-0/server-tools-14-0-auto_backup/hr/
@anhvu-sg @tafaRU
[15][MIG] 🎉 Migrate auto_backup
189d10d
@ibuioli @tafaRU
Translated using Weblate (Spanish (Argentina))
cedfa08 
Currently translated at 100.0% (86 of 86 strings)

Translation: server-tools-15.0/server-tools-15.0-auto_backup
Translate-URL: https://translation.odoo-community.org/projects/server-tools-15-0/server-tools-15-0-auto_backup/es_AR/
@mymage @tafaRU
Translated using Weblate (Italian)
40004da 
Currently translated at 86.0% (74 of 86 strings)

Translation: server-tools-15.0/server-tools-15.0-auto_backup
Translate-URL: https://translation.odoo-community.org/projects/server-tools-15-0/server-tools-15-0-auto_backup/it/
@francesco-ooops @tafaRU
Translated using Weblate (Italian)
87e9a80 
Currently translated at 86.0% (74 of 86 strings)

Translation: server-tools-15.0/server-tools-15.0-auto_backup
Translate-URL: https://translation.odoo-community.org/projects/server-tools-15-0/server-tools-15-0-auto_backup/it/
@mymage @tafaRU
Translated using Weblate (Italian)
8b4682c 
Currently translated at 86.0% (74 of 86 strings)

Translation: server-tools-15.0/server-tools-15.0-auto_backup
Translate-URL: https://translation.odoo-community.org/projects/server-tools-15-0/server-tools-15-0-auto_backup/it/
@weblate @tafaRU
Update translation files
a22184b 
Updated by "Update PO files to match POT (msgmerge)" hook in Weblate.

Translation: server-tools-15.0/server-tools-15.0-auto_backup
Translate-URL: https://translation.odoo-community.org/projects/server-tools-15-0/server-tools-15-0-auto_backup/
@ibuioli @tafaRU
Translated using Weblate (Spanish (Argentina))
9bf5bb0 
Currently translated at 100.0% (80 of 80 strings)

Translation: server-tools-15.0/server-tools-15.0-auto_backup
Translate-URL: https://translation.odoo-community.org/projects/server-tools-15-0/server-tools-15-0-auto_backup/es_AR/
@StefanRijnhart @tafaRU
[FIX] Pin cryptography to keep compatibility with Odoo's pyopenssl==1…
5ae7981 
…9.0.0

Same as odoo/odoo#99829
@francesco-ooops @tafaRU
Translated using Weblate (Italian)
c0c395c 
Currently translated at 90.0% (72 of 80 strings)

Translation: server-tools-15.0/server-tools-15.0-auto_backup
Translate-URL: https://translation.odoo-community.org/projects/server-tools-15-0/server-tools-15-0-auto_backup/it/
@mymage @tafaRU
Translated using Weblate (Italian)
b009ac4 
Currently translated at 90.0% (72 of 80 strings)

Translation: server-tools-15.0/server-tools-15.0-auto_backup
Translate-URL: https://translation.odoo-community.org/projects/server-tools-15-0/server-tools-15-0-auto_backup/it/
@mymage @tafaRU
Translated using Weblate (Italian)
ba2a52f 
Currently translated at 84.7% (72 of 85 strings)

Translation: server-tools-15.0/server-tools-15.0-auto_backup
Translate-URL: https://translation.odoo-community.org/projects/server-tools-15-0/server-tools-15-0-auto_backup/it/
@tafaRU
Copy link
Member Author

tafaRU commented Dec 1, 2023

@thomaspaulb pre-commit fixed!

@rvalyi rvalyi merged commit 191e56b into OCA:16.0 Dec 1, 2023
5 checks passed
@thomaspaulb
Copy link
Contributor

@rvalyi You should use the ocabot for merging...

@rvalyi
Copy link
Member

rvalyi commented Dec 1, 2023 •
edited
Loading

Wow! Guys that's bad I believe I merged this by accident with my cell phone in my pocket. I absolutely didn't try to merge it on purpose...

What is the best way to fix this?
cc @pedrobaeza @thomaspaulb

@rvalyi
Copy link
Member

rvalyi commented Dec 1, 2023 •
edited
Loading

Fortunately it seems it was quite close for merge at least. I'm looking better at the PR... reverting things on 16.0 is an option too if we do it fast, it would screw people who pulled meanwhile, so eventually it will be better to keep it. Again much sorry for this. We all get our cell phone do weird things in our pockets, but that's the very first try I got mine click on a merge button...

@pedrobaeza
Copy link
Member

One possibility is to revert the pull request, and do it again, but if the code is correct, no problem in keeping it this way. The bot will put extra commits, and tonight the wheel will be created.

@thomaspaulb
Copy link
Contributor

Yes this was ready for merge, well then lets keep it like this.

@tafaRU tafaRU deleted the 16.0-mig-auto_backup branch December 5, 2023 10:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
16.0
Development

Successfully merging this pull request may close these issues.