[ADD] mass_mailing_batch #1172
Closed
[ADD] mass_mailing_batch #1172
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
SirTakobi
force-pushed
the
10.0-add-mass_mailing_batch
branch
4 times, most recently
from
a7aed14 to
5c54758
Compare
eLBati
suggested changes
Jun 21, 2023
| batch_size = self.env['ir.config_parameter'] \ | ||
| .sudo() \ | ||
| .get_param( | ||
| 'mass_mailing_batch.size', |
There was a problem hiding this comment.
@SirTakobi I would name this parameter mass_mailing.batch_size
There was a problem hiding this comment.
Thanks for the review!
I prefer to keep the module name in the parameter key, in order to avoid clashing with other parameter names.
If you really don't like the key right now, maybe I could change it to mass_mailing_batch.batch_size, what do you think?
eLBati
approved these changes
Jun 22, 2023
|
There hasn't been any activity on this pull request in the past 4 months, so it has been marked as stale and it will be closed automatically if no further activity occurs in the next 30 days. |
github-actions
bot
added
the
stale
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
CI will be fixed after OCA/oca-addons-repo-template#199