Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[8.0][IMP][mail_tracking] Speed installation time and discard concurrent events #82

Merged
merged 6 commits into from
Sep 9, 2016

Conversation

antespi
Copy link
Contributor

@antespi antespi commented Sep 1, 2016

Several improvements after using mail_tracking_* addons in production environment:

  • Remove post_init_hook: When installing these addons there's no mail_tracking_mail objects in DB, so there's no point to relate them to any res.partner
  • Add pre_init_hook: Create and set a value to compute + store columns (and email_score column), before installing this addon
  • Remove compute and api.depends on email_score fields
  • Do not save concurrent open or click events:
    • If there's two concurrent open events (events received with a delta time less than 10 seconds) only the first one will be saved, the second one will be discarded
    • If there's two concurrent click events (events received with a delta time less than 5 seconds, and referred to the same URL) only the first one will be saved, the second one will be discarded.
  • Propagate bounce event to mass_mailing stats
  • Improvements on mail_tracking_mailgun proposed by @yajo after merging

@Tecnativa

@antespi antespi changed the title [IMP] Speed installation time and discard concurrent events [8.0][IMP][mail_tracking] Speed installation time and discard concurrent events Sep 1, 2016
@rafaelbn
Copy link
Member

rafaelbn commented Sep 2, 2016

Hi @antespi , runbot and travis fails

@antespi antespi force-pushed the 8.0-mail_tracking_imp branch from b7f9826 to d8b02fc Compare September 2, 2016 01:04
@antespi antespi force-pushed the 8.0-mail_tracking_imp branch from d8b02fc to a7e9615 Compare September 2, 2016 01:52
@@ -13,6 +13,9 @@

_logger = logging.getLogger(__name__)

EVENT_OPEN_DELTA = 10
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Comment that this is in seconds

@antespi
Copy link
Contributor Author

antespi commented Sep 2, 2016

@pedrobaeza Comments fixed or answered, thanks

@pedrobaeza
Copy link
Member

👍

1 similar comment
@carlosdauden
Copy link
Contributor

👍

@pedrobaeza pedrobaeza merged commit d420cef into OCA:8.0 Sep 9, 2016
@pedrobaeza pedrobaeza deleted the 8.0-mail_tracking_imp branch September 9, 2016 11:30
antespi added a commit to Tecnativa/social that referenced this pull request Sep 12, 2016
…ent events (OCA#82)

[IMP] mail_tracking: Speed installation time, discard concurrent events and other fixes
antespi added a commit to Tecnativa/social that referenced this pull request Sep 13, 2016
…ent events (OCA#82)

[IMP] mail_tracking: Speed installation time, discard concurrent events and other fixes
pedrobaeza pushed a commit to Tecnativa/social that referenced this pull request Sep 16, 2016
…ent events (OCA#82)

[IMP] mail_tracking: Speed installation time, discard concurrent events and other fixes
pedrobaeza pushed a commit to Tecnativa/social that referenced this pull request Sep 16, 2016
…ent events (OCA#82)

[IMP] mail_tracking: Speed installation time, discard concurrent events and other fixes
antespi added a commit to Tecnativa/social that referenced this pull request Sep 19, 2016
…ent events (OCA#82)

[IMP] mail_tracking: Speed installation time, discard concurrent events and other fixes
pedrobaeza pushed a commit to Tecnativa/social that referenced this pull request Sep 20, 2016
…ent events (OCA#82)

[IMP] mail_tracking: Speed installation time, discard concurrent events and other fixes
pedrobaeza pushed a commit to Tecnativa/social that referenced this pull request Sep 20, 2016
…ent events (OCA#82)

[IMP] mail_tracking: Speed installation time, discard concurrent events and other fixes
pedrobaeza pushed a commit to Tecnativa/social that referenced this pull request Sep 20, 2016
…ent events (OCA#82)

[IMP] mail_tracking: Speed installation time, discard concurrent events and other fixes
cubells pushed a commit to Tecnativa/social that referenced this pull request Jan 3, 2017
[IMP] mail_tracking: Speed installation time, discard concurrent events and other fixes
hvgollar pushed a commit to dynapps/social that referenced this pull request Dec 19, 2022
…ent events (OCA#82)

[IMP] mail_tracking: Speed installation time, discard concurrent events and other fixes
sergio-teruel pushed a commit to Tecnativa/social that referenced this pull request Feb 1, 2023
…ent events (OCA#82)

[IMP] mail_tracking: Speed installation time, discard concurrent events and other fixes
alan196 pushed a commit to Jarsa/social that referenced this pull request Feb 20, 2023
…ent events (OCA#82)

[IMP] mail_tracking: Speed installation time, discard concurrent events and other fixes
alan196 pushed a commit to Jarsa-dev/social that referenced this pull request Feb 20, 2023
…ent events (OCA#82)

[IMP] mail_tracking: Speed installation time, discard concurrent events and other fixes
maq-adhoc pushed a commit to adhoc-dev/social that referenced this pull request Mar 6, 2023
…ent events (OCA#82)

[IMP] mail_tracking: Speed installation time, discard concurrent events and other fixes
mathieudelva pushed a commit to mathieudelva/social that referenced this pull request May 23, 2023
…ent events (OCA#82)

[IMP] mail_tracking: Speed installation time, discard concurrent events and other fixes
alan196 pushed a commit to Jarsa/social that referenced this pull request Jun 16, 2023
…ent events (OCA#82)

[IMP] mail_tracking: Speed installation time, discard concurrent events and other fixes
alan196 pushed a commit to Jarsa-dev/social that referenced this pull request Jul 20, 2023
…ent events (OCA#82)

[IMP] mail_tracking: Speed installation time, discard concurrent events and other fixes
payen000 pushed a commit to vauxoo-dev/social that referenced this pull request Sep 5, 2023
…ent events (OCA#82)

[IMP] mail_tracking: Speed installation time, discard concurrent events and other fixes
payen000 pushed a commit to vauxoo-dev/social that referenced this pull request Sep 25, 2023
…ent events (OCA#82)

[IMP] mail_tracking: Speed installation time, discard concurrent events and other fixes
nguyenminhchien pushed a commit to nguyenminhchien/social that referenced this pull request Oct 20, 2023
…ent events (OCA#82)

[IMP] mail_tracking: Speed installation time, discard concurrent events and other fixes
chienandalu pushed a commit to Tecnativa/social that referenced this pull request Oct 31, 2023
…ent events (OCA#82)

[IMP] mail_tracking: Speed installation time, discard concurrent events and other fixes
chienandalu pushed a commit to Tecnativa/social that referenced this pull request Nov 2, 2023
…ent events (OCA#82)

[IMP] mail_tracking: Speed installation time, discard concurrent events and other fixes
trisdoan pushed a commit to trisdoan/social that referenced this pull request Mar 15, 2024
…ent events (OCA#82)

[IMP] mail_tracking: Speed installation time, discard concurrent events and other fixes
chienandalu pushed a commit to Tecnativa/social that referenced this pull request May 14, 2024
…ent events (OCA#82)

[IMP] mail_tracking: Speed installation time, discard concurrent events and other fixes
chienandalu pushed a commit to Tecnativa/social that referenced this pull request May 30, 2024
…ent events (OCA#82)

[IMP] mail_tracking: Speed installation time, discard concurrent events and other fixes
trisdoan pushed a commit to trisdoan/social that referenced this pull request May 31, 2024
…ent events (OCA#82)

[IMP] mail_tracking: Speed installation time, discard concurrent events and other fixes
chienandalu pushed a commit to Tecnativa/social that referenced this pull request Jul 5, 2024
…ent events (OCA#82)

[IMP] mail_tracking: Speed installation time, discard concurrent events and other fixes
chienandalu pushed a commit to Tecnativa/social that referenced this pull request Jul 11, 2024
…ent events (OCA#82)

[IMP] mail_tracking: Speed installation time, discard concurrent events and other fixes
trisdoan pushed a commit to trisdoan/social that referenced this pull request Sep 23, 2024
…ent events (OCA#82)

[IMP] mail_tracking: Speed installation time, discard concurrent events and other fixes
trisdoan pushed a commit to trisdoan/social that referenced this pull request Sep 23, 2024
…ent events (OCA#82)

[IMP] mail_tracking: Speed installation time, discard concurrent events and other fixes
trisdoan pushed a commit to trisdoan/social that referenced this pull request Sep 27, 2024
…ent events (OCA#82)

[IMP] mail_tracking: Speed installation time, discard concurrent events and other fixes
trisdoan pushed a commit to trisdoan/social that referenced this pull request Oct 2, 2024
…ent events (OCA#82)

[IMP] mail_tracking: Speed installation time, discard concurrent events and other fixes
trisdoan pushed a commit to trisdoan/social that referenced this pull request Oct 3, 2024
…ent events (OCA#82)

[IMP] mail_tracking: Speed installation time, discard concurrent events and other fixes
trisdoan pushed a commit to trisdoan/social that referenced this pull request Oct 3, 2024
…ent events (OCA#82)

[IMP] mail_tracking: Speed installation time, discard concurrent events and other fixes
trisdoan pushed a commit to trisdoan/social that referenced this pull request Oct 3, 2024
…ent events (OCA#82)

[IMP] mail_tracking: Speed installation time, discard concurrent events and other fixes
trisdoan pushed a commit to trisdoan/social that referenced this pull request Oct 10, 2024
…ent events (OCA#82)

[IMP] mail_tracking: Speed installation time, discard concurrent events and other fixes
trisdoan pushed a commit to trisdoan/social that referenced this pull request Oct 23, 2024
…ent events (OCA#82)

[IMP] mail_tracking: Speed installation time, discard concurrent events and other fixes
trisdoan pushed a commit to trisdoan/social that referenced this pull request Nov 12, 2024
…ent events (OCA#82)

[IMP] mail_tracking: Speed installation time, discard concurrent events and other fixes
SiesslPhillip pushed a commit to grueneerde/OCA-social that referenced this pull request Nov 20, 2024
Syncing from upstream OCA/social (11.0)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants