-
-
Notifications
You must be signed in to change notification settings - Fork 42
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[FIX] stock_available_mrp: increment potencial_qty to immediately_usable_qty instead of replacing it #32
base: 16.0
Are you sure you want to change the base?
Conversation
d397b81
to
401f05b
Compare
…ble_qty instead of replacing it
401f05b
to
0d299a1
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
As I could verify, the value now is correct because it takes the stock on hand of the warehouse plus the potential to calculate the stock on hand (additionally, the system uses the outgoing and incoming stock to get the final value). I will explain it with an example:
I have a product (5019) which has a BoM (bunch of materials) to produce 240 units. and it has enough stock to produce only one BoM, exactly 240 units. of the final product As we can see, the Available to Promise (Disponible para prometer) was calculated taking The expected result is: The result is: LGTM |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
More info: #32 (comment)
This PR has the |
Could you please review this? Thank you |
When no potential quantities are available, the immediate usable quantity should not be set to zero. Instead, the potential quantity should be added to the immediate usable quantity, rather than replacing it. This ensures that the stock calculation reflects both values accurately, rather than incorrectly disregarding the potential quantity.