Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[16.0][MIG] stock_barcodes_picking_batch: Migration to version 16.0 #633

Merged
merged 12 commits into from
Jan 9, 2025
Merged

[16.0][MIG] stock_barcodes_picking_batch: Migration to version 16.0 #633

merged 12 commits into from
Jan 9, 2025

Conversation

sergio-teruel
Copy link
Contributor

@sergio-teruel sergio-teruel commented Jul 29, 2024 •
edited
Loading

@sergio-teruel sergio-teruel marked this pull request as draft July 29, 2024 10:27
@sergio-teruel sergio-teruel force-pushed the 16.0-mig-stock_barcodes_picking_batch branch 2 times, most recently from e05722c to 381596c Compare July 29, 2024 16:37
@sergio-teruel sergio-teruel marked this pull request as ready for review July 29, 2024 16:37
@sergio-teruel sergio-teruel mentioned this pull request Jul 29, 2024
Open
1 task
@sergio-teruel sergio-teruel force-pushed the 16.0-mig-stock_barcodes_picking_batch branch from 381596c to 16dd4c8 Compare August 2, 2024 13:05
chienandalu
chienandalu suggested changes Sep 4, 2024
View reviewed changes
stock_barcodes_picking_batch/wizard/stock_barcodes_read_picking_batch_views.xml Outdated
<templates>
<t t-name="kanban-box">
<div
t-att-class="'oe_kanban_color_alert' + (record.is_pending.raw_value == false ? ' bg-success' : '')"
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Avoid dark green on green so the info is more readable

Suggested change
t-att-class="'oe_kanban_color_alert' + (record.is_pending.raw_value == false ? ' bg-success' : '')"
t-att-class="'oe_kanban_color_alert' + (record.is_pending.raw_value == false ? ' bg-success text-white' : '')"

Also I suspect that oe_kanban_color_alert doesn't have any effect...

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Done!!

@sergio-teruel sergio-teruel force-pushed the 16.0-mig-stock_barcodes_picking_batch branch from 16dd4c8 to cf3d70c Compare September 5, 2024 11:54
@pedrobaeza
Copy link
Member

/ocabot migration stock_barcodes_picking_batch

@OCA-git-bot OCA-git-bot added this to the 16.0 milestone Sep 5, 2024
@OCA-git-bot OCA-git-bot mentioned this pull request Sep 5, 2024
Open
13 tasks
@github-actions GitHub Actions
Copy link

github-actions bot commented Jan 5, 2025

There hasn't been any activity on this pull request in the past 4 months, so it has been marked as stale and it will be closed automatically if no further activity occurs in the next 30 days.
If you want this PR to never become stale, please ask a PSC member to apply the "no stale" label.

@github-actions github-actions bot added the stale PR/Issue without recent activity, it'll be soon closed automatically. label Jan 5, 2025
CarlosRoca13
CarlosRoca13 approved these changes Jan 8, 2025
View reviewed changes
Copy link
Contributor

@CarlosRoca13 CarlosRoca13 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please rebase

sergio-teruel and others added 11 commits January 8, 2025 08:29
@sergio-teruel @carlosdauden
[ADD] stock_barcodes_picking_batch: New module
1a4384d
@carlosdauden
[UPD] Update stock_barcodes_picking_batch.pot
6307f07
@OCA-git-bot @carlosdauden
[UPD] README.rst
f47b492
@sergio-teruel @carlosdauden
[IMP] stock_barcodes_picking_batch: black, isort
9da3d46
@sergio-teruel @carlosdauden
[MIG] stock_barcodes_picking_batch: Migration to v15.0
43912a8
@carlosdauden
[UPD] Update stock_barcodes_picking_batch.pot
1d16222
@weblate @carlosdauden
Update translation files
ef20c8e 
Updated by "Update PO files to match POT (msgmerge)" hook in Weblate.

Translation: stock-logistics-barcode-15.0/stock-logistics-barcode-15.0-stock_barcodes_picking_batch
Translate-URL: https://translation.odoo-community.org/projects/stock-logistics-barcode-15-0/stock-logistics-barcode-15-0-stock_barcodes_picking_batch/
@Ivorra78 @carlosdauden
Translated using Weblate (Spanish)
906408b 
Currently translated at 100.0% (48 of 48 strings)

Translation: stock-logistics-barcode-15.0/stock-logistics-barcode-15.0-stock_barcodes_picking_batch
Translate-URL: https://translation.odoo-community.org/projects/stock-logistics-barcode-15-0/stock-logistics-barcode-15-0-stock_barcodes_picking_batch/es/
@sergio-teruel @carlosdauden
[FIX] stock_barcodes_picking_batch: Validation button not displayed
993d7fb 
Remove unused code
@sergio-teruel @carlosdauden
[FIX] stock_barcodes_picking_batch: Pending moves ordered by destinat…
50b2278 
…ion location in internal operations

TT47189
@OCA-git-bot @carlosdauden
[BOT] post-merge updates
9aad6aa
@carlosdauden carlosdauden force-pushed the 16.0-mig-stock_barcodes_picking_batch branch from cf3d70c to 6aa1e04 Compare January 8, 2025 07:29
@carlosdauden
Copy link
Contributor

Rebased

rousseldenis
rousseldenis reviewed Jan 8, 2025
View reviewed changes
Copy link
Contributor

@rousseldenis rousseldenis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Maybe increasing coverage could be great

stock_barcodes_picking_batch/wizard/stock_barcodes_read_picking_batch.py Outdated Show resolved Hide resolved
@sergio-teruel sergio-teruel force-pushed the 16.0-mig-stock_barcodes_picking_batch branch from 6aa1e04 to e22fa7f Compare January 9, 2025 09:00
@sergio-teruel sergio-teruel force-pushed the 16.0-mig-stock_barcodes_picking_batch branch from e22fa7f to 0899ff6 Compare January 9, 2025 09:06
chienandalu
chienandalu approved these changes Jan 9, 2025
View reviewed changes
Copy link
Member

@chienandalu chienandalu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@OCA-git-bot
Copy link
Contributor

This PR has the approved label and has been created more than 5 days ago. It should therefore be ready to merge by a maintainer (or a PSC member if the concerned addon has no declared maintainer). 🤖

@pedrobaeza
Copy link
Member

/ocabot merge nobump

@OCA-git-bot
Copy link
Contributor

What a great day to merge this nice PR. Let's do it!
Prepared branch 16.0-ocabot-merge-pr-633-by-pedrobaeza-bump-nobump, awaiting test results.

@OCA-git-bot OCA-git-bot merged commit 31d6807 into OCA:16.0 Jan 9, 2025
7 checks passed
@OCA-git-bot
Copy link
Contributor

Congratulations, your PR was merged at 286b429. Thanks a lot for contributing to OCA. ❤️

@pedrobaeza pedrobaeza deleted the 16.0-mig-stock_barcodes_picking_batch branch January 9, 2025 12:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@rousseldenis rousseldenis rousseldenis left review comments

@CarlosRoca13 CarlosRoca13 CarlosRoca13 approved these changes

@carlosdauden carlosdauden carlosdauden approved these changes

@chienandalu chienandalu chienandalu approved these changes

Assignees
No one assigned
Labels
approved merged 🎉 ready to merge stale PR/Issue without recent activity, it'll be soon closed automatically.
Projects
None yet
Milestone
16.0
Development

Successfully merging this pull request may close these issues.
9 participants
@sergio-teruel @pedrobaeza @carlosdauden @OCA-git-bot @chienandalu @rousseldenis @CarlosRoca13 @weblate @Ivorra78