[WMS][12.0] Add stock_reserve_packaging - Alpha version #695
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
guewen
force-pushed
the
12.0-wms-stock-reserve-package
branch
from
1a81dc1 to
f809de2
Compare
guewen
changed the title
guewen
force-pushed
the
12.0-wms-stock-reserve-package
branch
2 times, most recently
from
a75eb3c to
b9e2b72
Compare
|
Extraction of the methods for master: odoo/odoo#36385 |
|
The build error should be fixed by OCA/product-attribute#500 |
Reservation by complete packaging first, then apply the removal strategy.
guewen
force-pushed
the
12.0-wms-stock-reserve-package
branch
from
b9e2b72 to
627af97
Compare
guewen
added a commit
to guewen/odoo
that referenced
this pull request
Sep 3, 2019
In order to allow more advanced behaviours from extension addons. For instance, an addon to reserve full packaging (e.g. a pallet) before considering the removal strategy (OCA/stock-logistics-warehouse#695). As this special strategy is based on the ordered quantity, it cannot be added to the _gather() or _get_removal_strategy() methods which do not know the quantity. The reservation happens in an override of _update_reserved_quantity(), and many lines of code have to be duplicated. Extracting these 2 methods will allow to reduce duplication.
jgrandguillaume
approved these changes
Sep 5, 2019
|
Now handled as a removal strategy in reservation rules (#683). Closing, any interested people: feel free to reopen. |
32 tasks
62 tasks
manuelcalerosolis
pushed a commit
to xtendoo-corporation/stock-logistics-warehouse
that referenced
this pull request
Oct 31, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Reservation by complete packaging first, then apply the removal
strategy.
This is the first working version. When working on the other modules touching
the removal strategies, we may need to make a common base, but until then, we
aren't sure of what the lowest common denominator is (first: get a working
version, two: refactor; we are clearly at step one :).
Also, I had to duplicate many lines from the stock module to get this working.
I'll open a PR on master to have better abstractions on the next release, hopefully.
Related to #621 and #685