[WMS][12.0] Add stock_move_location_dest_constraint_tag - alpha version #698
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
grindtildeath
changed the title
grindtildeath
commented
Sep 5, 2019
stock_move_location_dest_constraint_tag/models/stock_location.py
Outdated
Show resolved
Hide resolved
grindtildeath
force-pushed
the
12.0_add_stock_move_location_dest_constraint_tags
branch
from
1057db9 to
554a88c
Compare
32 tasks
…onstraint_tags Fix demo data, wrong model name
| @@ -0,0 +1,53 @@ | |||
| <?xml version="1.0" encoding="UTF-8"?> | |||
| <odoo> | |||
There was a problem hiding this comment.
should use odoo noupdate="1"
| @@ -0,0 +1,14 @@ | |||
| <?xml version="1.0" encoding="UTF-8"?> | |||
| <odoo> | |||
There was a problem hiding this comment.
noupdate="1" is missing for all demo files
| @@ -0,0 +1,13 @@ | |||
| # Copyright 2019 Camptocamp SA | |||
| # License AGPL-3.0 or later (https://www.gnu.org/licenses/agpl) | |||
| from odoo import models, fields | |||
There was a problem hiding this comment.
import should be in alphabetical order
from odoo import fields, models
| @@ -0,0 +1,12 @@ | |||
| # Copyright 2019 Camptocamp SA | |||
| # License AGPL-3.0 or later (https://www.gnu.org/licenses/agpl) | |||
| from odoo import models, fields | |||
| @@ -0,0 +1,13 @@ | |||
| # Copyright 2019 Camptocamp SA | |||
| # License AGPL-3.0 or later (https://www.gnu.org/licenses/agpl) | |||
| from odoo import models, fields | |||
| @@ -0,0 +1,37 @@ | |||
| # Copyright 2019 Camptocamp SA | |||
| # License AGPL-3.0 or later (https://www.gnu.org/licenses/agpl) | |||
| from odoo import models, fields, _ | |||
There was a problem hiding this comment.
It should be from odoo import _, fields, models
gurneyalex
reviewed
Sep 19, 2019
There was a problem hiding this comment.
I'm concerned about a few issues here:
- with this implementation, the Customers location needs to be updated with every possible tag, otherwise you will never be able to deliver a SO
- same for PACK and OUT locations of a WH
- there is no domain update in the choice of a destination location to help the user choose an appropriate location.
|
@gurneyalex I agree with you. We need to review all this put away design at a whole. The POC prooved it works, but it's not optimal. |
62 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This module implements destination location constraint on stock move line.
When installed stock moves will only be allowed if the destination location
includes the same tags as defined on the product or its product category.
N.B.: If tags are defined on the product, tags defined on its product category
will not be considered
Related to #691
Requires: