[WIP][WMS][12.0] stock_minimum_shelf_life #723
Conversation
damdam-s
force-pushed
the
stock_mininum_shelf_life
branch
from
323b71f to
7b394c8
Compare
damdam-s
force-pushed
the
stock_mininum_shelf_life
branch
from
5e1c484 to
1bb3e5b
Compare
| class ResCompany(models.Model): | ||
| _inherit = 'res.company' | ||
|
|
||
| minimum_shelf_life = fields.Integer( |
There was a problem hiding this comment.
@jgrandguillaume In case of fresh products, isn't it a too big window (days instead) ?
|
|
||
| def _action_assign(self): | ||
| proc_sales_moves = self.filtered( | ||
| lambda m: m.picking_id.group_id.sale_id |
There was a problem hiding this comment.
@jgrandguillaume are you sure that this should be limited to stock moves for sales to customers? What about checking it also in production orders, so that you don't accept to consume products that have a certain shelf life limit? This is very important, for example, for food processing.
Al alternative could be that the user defines in settings when they want to check minimum shelf life:
- Shipping to customers (destination location in the stock move is type customer)
- Consuming products for production (destination location in the stock move is type production)
There was a problem hiding this comment.
@jbeficent I agree with you, this is a very good remark.
Will take this into account.
There was a problem hiding this comment.
Not so easy because if in pick pack ship setup, then the pick make the reservation.. so it's not a customer one yet..
| class ResConfigSettings(models.TransientModel): | ||
| _inherit = 'res.config.settings' | ||
|
|
||
| minimum_shelf_life = fields.Integer( |
There was a problem hiding this comment.
@jgrandguillaume In SAP is documented as 'minimum_remaining_shelf_life'. That would be better understood? Also, why document it at company level? Why not maintain it at product and product category levels?
|
@damdam-s @jgrandguillaume What's the status of this ? |
|
There hasn't been any activity on this pull request in the past 4 months, so it has been marked as stale and it will be closed automatically if no further activity occurs in the next 30 days. |
github-actions
bot
added
the
stale
implements #722