Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[14.0][MIG] rental_base #4

Merged
merged 6 commits into from
Jan 17, 2022
Merged

[14.0][MIG] rental_base #4

merged 6 commits into from
Jan 17, 2022

Conversation

chandni299
Copy link
Contributor

No description provided.

@chandni299 chandni299 force-pushed the 14.0-mig-rental_base_cpatel branch 5 times, most recently from d727308 to 7e152b5 Compare January 3, 2022 09:23
@chandni299
Copy link
Contributor Author

chandni299 commented Jan 3, 2022 •
edited
Loading

@oca-transbot @oca-travis @OCA-git-bot any idea on why runboat fails here https://runboat.odoo-community.org/webui/build.html?name=b62886261-c8da-4781-825e-150164f9e036? It would be very helpful. Thanks!

marylla
marylla approved these changes Jan 13, 2022
View reviewed changes
Copy link

@marylla marylla left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I made a functional review. It works as expected. 👍

Menus

  • check the existence of rental menus

Test procedure

  • create a new storable product that can be rent
  • create the related rental service
  • create a new sale order of type rental
  • add a sale order line and choose the rental service
    • check the adapted form view of sale order line
  • add the start and end date of rental
    • check the amount of time that is sold
  • confirm the order
    • check outgoing and incoming deliveries and their planned dates
  • change the start and / or end date of sale order line (even though it is confirmed) by using button "update times"
    • check the planned dates of outgoing and / or incoming delivery

@chandni299 chandni299 force-pushed the 14.0-mig-rental_base_cpatel branch from ebc82f5 to 5fc1250 Compare January 14, 2022 08:47
yweng8111
yweng8111 approved these changes Jan 14, 2022
View reviewed changes
Copy link
Contributor

@yweng8111 yweng8111 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

well done

@OCA-git-bot
Copy link
Contributor

This PR has the approved label and has been created more than 5 days ago. It should therefore be ready to merge by a maintainer (or a PSC member if the concerned addon has no declared maintainer). 🤖

@chandni299
Copy link
Contributor Author

Thank you for your reviews @marylla @yweng8111 👍

@marylla marylla merged commit 1271fcb into OCA:14.0 Jan 17, 2022
SoporteOperu pushed a commit to SoporteOperu/vertical-rental that referenced this pull request Feb 14, 2023
@chandni299 @oca-travis
@oca-transbot @chandni300 @pegonzalezspesol
[14.0][MIG] rental_base (OCA#4)
bc65d68 
* selectively add some files from the v12 branch

* initial add of several rental modules

* [UPD] Update rental_base.pot

* Update translation files

Updated by "Update PO files to match POT (msgmerge)" hook in Weblate.

Translation: vertical-rental-12.0/vertical-rental-12.0-rental_base
Translate-URL: https://translation.odoo-community.org/projects/vertical-rental-12-0/vertical-rental-12-0-rental_base/

* [IMP] rental_base: black, isort, prettier

* [MIG] rental_base: Migration to 14.0

Co-authored-by: Maria Sparenberg <maria.sparenberg@elegosoft.com>
Co-authored-by: oca-travis <oca+oca-travis@odoo-community.org>
Co-authored-by: OCA Transbot <transbot@odoo-community.org>
Co-authored-by: cpatel <cpatel@elegosoft.com>
daramousk pushed a commit to daramousk/vertical-rental that referenced this pull request May 24, 2023
@chandni299 @oca-travis
@oca-transbot @chandni300 @daramousk
[14.0][MIG] rental_base (OCA#4)
9875fad 
* selectively add some files from the v12 branch

* initial add of several rental modules

* [UPD] Update rental_base.pot

* Update translation files

Updated by "Update PO files to match POT (msgmerge)" hook in Weblate.

Translation: vertical-rental-12.0/vertical-rental-12.0-rental_base
Translate-URL: https://translation.odoo-community.org/projects/vertical-rental-12-0/vertical-rental-12-0-rental_base/

* [IMP] rental_base: black, isort, prettier

* [MIG] rental_base: Migration to 14.0

Co-authored-by: Maria Sparenberg <maria.sparenberg@elegosoft.com>
Co-authored-by: oca-travis <oca+oca-travis@odoo-community.org>
Co-authored-by: OCA Transbot <transbot@odoo-community.org>
Co-authored-by: cpatel <cpatel@elegosoft.com>
daramousk pushed a commit to daramousk/vertical-rental that referenced this pull request May 26, 2023
@chandni299 @oca-travis
@oca-transbot @chandni300 @daramousk
[14.0][MIG] rental_base (OCA#4)
4cec465 
* selectively add some files from the v12 branch

* initial add of several rental modules

* [UPD] Update rental_base.pot

* Update translation files

Updated by "Update PO files to match POT (msgmerge)" hook in Weblate.

Translation: vertical-rental-12.0/vertical-rental-12.0-rental_base
Translate-URL: https://translation.odoo-community.org/projects/vertical-rental-12-0/vertical-rental-12-0-rental_base/

* [IMP] rental_base: black, isort, prettier

* [MIG] rental_base: Migration to 14.0

Co-authored-by: Maria Sparenberg <maria.sparenberg@elegosoft.com>
Co-authored-by: oca-travis <oca+oca-travis@odoo-community.org>
Co-authored-by: OCA Transbot <transbot@odoo-community.org>
Co-authored-by: cpatel <cpatel@elegosoft.com>
coffeinisfun pushed a commit to elego/vertical-rental that referenced this pull request Feb 19, 2024
@chandni299 @oca-travis
@oca-transbot @chandni300
[14.0][MIG] rental_base (OCA#4)
43ca8b8 
* selectively add some files from the v12 branch

* initial add of several rental modules

* [UPD] Update rental_base.pot

* Update translation files

Updated by "Update PO files to match POT (msgmerge)" hook in Weblate.

Translation: vertical-rental-12.0/vertical-rental-12.0-rental_base
Translate-URL: https://translation.odoo-community.org/projects/vertical-rental-12-0/vertical-rental-12-0-rental_base/

* [IMP] rental_base: black, isort, prettier

* [MIG] rental_base: Migration to 14.0

Co-authored-by: Maria Sparenberg <maria.sparenberg@elegosoft.com>
Co-authored-by: oca-travis <oca+oca-travis@odoo-community.org>
Co-authored-by: OCA Transbot <transbot@odoo-community.org>
Co-authored-by: cpatel <cpatel@elegosoft.com>
adasatorres pushed a commit to BinhexTeam/vertical-rental that referenced this pull request Sep 16, 2024
@chandni299 @oca-travis
@oca-transbot @chandni300 @adasatorres
[14.0][MIG] rental_base (OCA#4)
8cd0404 
* selectively add some files from the v12 branch

* initial add of several rental modules

* [UPD] Update rental_base.pot

* Update translation files

Updated by "Update PO files to match POT (msgmerge)" hook in Weblate.

Translation: vertical-rental-12.0/vertical-rental-12.0-rental_base
Translate-URL: https://translation.odoo-community.org/projects/vertical-rental-12-0/vertical-rental-12-0-rental_base/

* [IMP] rental_base: black, isort, prettier

* [MIG] rental_base: Migration to 14.0

Co-authored-by: Maria Sparenberg <maria.sparenberg@elegosoft.com>
Co-authored-by: oca-travis <oca+oca-travis@odoo-community.org>
Co-authored-by: OCA Transbot <transbot@odoo-community.org>
Co-authored-by: cpatel <cpatel@elegosoft.com>
edescalona pushed a commit to BinhexTeam/vertical-rental that referenced this pull request Nov 27, 2024
@chandni299 @oca-travis
@oca-transbot @chandni300 @edescalona
[14.0][MIG] rental_base (OCA#4)
9fa8782 
* selectively add some files from the v12 branch

* initial add of several rental modules

* [UPD] Update rental_base.pot

* Update translation files

Updated by "Update PO files to match POT (msgmerge)" hook in Weblate.

Translation: vertical-rental-12.0/vertical-rental-12.0-rental_base
Translate-URL: https://translation.odoo-community.org/projects/vertical-rental-12-0/vertical-rental-12-0-rental_base/

* [IMP] rental_base: black, isort, prettier

* [MIG] rental_base: Migration to 14.0

Co-authored-by: Maria Sparenberg <maria.sparenberg@elegosoft.com>
Co-authored-by: oca-travis <oca+oca-travis@odoo-community.org>
Co-authored-by: OCA Transbot <transbot@odoo-community.org>
Co-authored-by: cpatel <cpatel@elegosoft.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@yweng8111 yweng8111 yweng8111 approved these changes

@marylla marylla marylla approved these changes

Assignees
No one assigned
Labels
approved ready to merge
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
7 participants
@chandni299 @OCA-git-bot @marylla @yweng8111 @oca-travis @oca-transbot @chandni300