Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[16.0][IMP] web_refresher: Charge t-inherit-mode extension views just after the main #2804

Merged
merged 1 commit into from
Apr 24, 2024

Conversation

CarlosRoca13
Copy link
Contributor

By doing this, the extension view is charged just after the main, so if some other views are using this other, to make a primary one, like project is doing for project.task control_panel, the refresher will continue be shown.

Before the patch:
image

After the patch:
image

cc @Tecnativa TT48551

ping @chienandalu @pedrobaeza

@CarlosRoca13 CarlosRoca13 force-pushed the 16.0-IMP-web_refresher-charge_order branch from e983cbd to a0ad476 Compare April 23, 2024 12:13
Copy link
Member

@chienandalu chienandalu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great! 👍

@pedrobaeza pedrobaeza added this to the 16.0 milestone Apr 23, 2024
… the main

By doing this, the extension view is charged just after the main, so
if some other views are using this other, to make a primary one,
like project is doing for project.task control_panel, the refresher
will continue be shown.
@CarlosRoca13 CarlosRoca13 force-pushed the 16.0-IMP-web_refresher-charge_order branch from a0ad476 to 171c27d Compare April 24, 2024 05:37
@CarlosRoca13
Copy link
Contributor Author

Added

Copy link
Member

@pedrobaeza pedrobaeza left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/ocabot merge minor

@OCA-git-bot
Copy link
Contributor

Hey, thanks for contributing! Proceeding to merge this for you.
Prepared branch 16.0-ocabot-merge-pr-2804-by-pedrobaeza-bump-minor, awaiting test results.

@OCA-git-bot OCA-git-bot merged commit 12d6756 into OCA:16.0 Apr 24, 2024
5 checks passed
@OCA-git-bot
Copy link
Contributor

Congratulations, your PR was merged at 19c94c8. Thanks a lot for contributing to OCA. ❤️

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants