Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

rework extensions overview #29

Closed
wants to merge 1 commit into from
Closed

Conversation

pwinckles
Copy link
Contributor

This PR is intended as a discussion point for ways to improve the current extensions overview. My primary goal was improved clarity, but also included are my own takes on resolving #22 and #23. I understand if there's no interest in merging, but perhaps some ideas will come out of it.

Copy link
Contributor

@bcail bcail left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks OK to me.

@neilsjefferies
Copy link
Member

Some good stuff here. Editors think it might be good to split into smaller PR's. More details to follow in reviews...!

@pwinckles
Copy link
Contributor Author

Some good stuff here. Editors think it might be good to split into smaller PR's. More details to follow in reviews...!

@neilsjefferies I took your comment to mean that more details were to come as to what you wanted me to do. Perhaps that was not the right interpretation.

I didn't know if you all would want to take any of the ideas that you liked and write it how you preferred it to be written, but I am happy to split this PR up if there is interest in merging parts of it. If that's the case, is there any guidance on how you'd like it split, or shall I use my own judgement?

Copy link
Member

@awoods awoods left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks again for this, @pwinckles . Very helpful.

In order to expedite review and merge of this work, I would suggest splitting the suggested text into three new pull-requests, closing the current pull-request.

  • PR-1: "OCFL Community Extensions" and "Using Community Extensions"
  • PR-2: "Implementing Community Extensions"
  • PR-3: "Specifying Community Extensions"

@pwinckles
Copy link
Contributor Author

Closing this PR in favor of PRs #30, #31, and #32

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants