Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

New storage layout extension NNNN-uri-direct-storage-layout #63

Open
wants to merge 2 commits into
base: main
Choose a base branch
from

Conversation

alvinsw
Copy link

@alvinsw alvinsw commented Dec 7, 2022

We want to be able to directly map a URI into the storage layout directory.
It may be similar to #57 but simpler and just use the path of any valir URI directly.

@zimeon
Copy link
Contributor

zimeon commented Dec 18, 2022

Should there be a note about the possibility of many to one mappings created by the idea of regex->string replacement? A warning or advice about what to do in the event of collision?

Is the replacement strictly regex->string or is regex->regex-replacement intended? I ask because later there is a comment about static string replacement which sort of implies there might be something dynamic too

How should multiple replacements be handled? Are the regexes applied in turn? Ie. does [['a','b'],['b','c']] applied to a produce c?

@awoods
Copy link
Member

awoods commented Jun 1, 2023

@alvinsw : Is this extension still of interest? There are open questions above.

@alvinsw
Copy link
Author

alvinsw commented Aug 9, 2023

Yes I think the replacement is a weak point here. After discussion with @ptsefton we'll take off all the parameters including the one for string replacement. So the spec should be simpler and straightforward.
I'll push an update soon.

@zimeon
Copy link
Contributor

zimeon commented Jul 18, 2024

@alvinsw & @ptsefton - Are you still interested in moving forward with this extension or should be close out this PR?

@alvinsw
Copy link
Author

alvinsw commented Aug 29, 2024

We still need the layout option where we can directly map a URI to directory paths without any hashing.
There are some overlaps or similarity with the other proposed extension NNNN-direct-clean-path-layout. However, I couldn't understand the last comment from @neilsjefferies that says it should be amended as an object extension. How can that works? If PR 57 can go through as a layout extension in some form or another then we can merge this one into that.

@zimeon
Copy link
Contributor

zimeon commented Aug 29, 2024

Thanks for replying @alvinsw . If you are still interested in moving this forward, could you push the update to reduce parameters you proposed in your Aug 9, 2023 #63 (comment).

(We aren't sure whether #57 is going to move forward but anyway the comments from @neilsjefferies do not apply to your use case.)

@alvinsw
Copy link
Author

alvinsw commented Nov 26, 2024

@zimeon I have updated the document and removed all parameters. Can this be approved now?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants