Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve description of storage root extensions #557

Closed
zimeon opened this issue Jul 2, 2021 · 5 comments · Fixed by #607
Closed

Improve description of storage root extensions #557

zimeon opened this issue Jul 2, 2021 · 5 comments · Fixed by #607
Assignees
Labels
Editorial Editorial issues (no changes to intent) Storage Root
Milestone

Comments

@zimeon
Copy link
Contributor

zimeon commented Jul 2, 2021

We currently describe Storage Root extensions by reference to Object extensions. This is fine in terms of what the structure is and an error in the storage root extensions structure should result in E086. However, there is no warning code defined for use of an unregistered extension in a storage root. The code W013 is used for object extensions but can't simply be used again for Storage Root extensions.

I think the best solution is simply to write out the structure requirement again for Storage Root extensions, commenting that this is the same as Object extensions. We can keep the error code E086 and the define a new warning code for use of an unregistered extension.

@rosy1280
Copy link
Contributor

rosy1280 commented Mar 17, 2022

Editors agreed with @zimeon 's recommendation. @awoods will create a pull request for this ticket.

@awoods
Copy link
Member

awoods commented Apr 7, 2022

@zimeon
Copy link
Contributor Author

zimeon commented Apr 7, 2022

Editors agree that the replication method provides a cleaner solution for readers and it is helpful to have separate error codes for the object and storage root cases.

@zimeon
Copy link
Contributor Author

zimeon commented Apr 7, 2022

The issue @pwinckles raised #583 (review) about the proposed E113 being unenforceable overlaps with #565. I think we could move forward with this issue by simply removing the text from the E113 sentence onward in #583, and rely on a resolution of #565 to address the notion of what constitutes a registered extension name.

@awoods
Copy link
Member

awoods commented Apr 13, 2022

Revisit based on changes made in: #584 (review)

awoods pushed a commit that referenced this issue Jun 22, 2022
This update replicates the Object extension specification text from Object extension into Storage Root extension

Resolves: #557

Supersedes: #583
julianmorley pushed a commit that referenced this issue Jun 23, 2022
This update replicates the Object extension specification text from Object extension into Storage Root extension

Resolves: #557

Supersedes: #583
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment