Fixed: Clarify path separators used in the inventory #283
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ahankinson
requested review from
rosy1280,
awoods,
zimeon,
julianmorley and
neilsjefferies
awoods
reviewed
Dec 5, 2018
draft/spec/index.html
Outdated
| @@ -485,6 +485,11 @@ <h2>Inventory</h2> | |||
| <code>inventory.json</code>. The order of entries in both the [[JSON]] objects and arrays used in inventory | |||
| files has no significance. | |||
| </p> | |||
| <p> | |||
| The forward slash (/) path separator MUST be used in existing and logical file paths in the manifest, | |||
There was a problem hiding this comment.
Should we add links to the manifest, fixity, and state sections of the spec?
zimeon
previously approved these changes
Dec 5, 2018
julianmorley
previously approved these changes
Dec 5, 2018
rosy1280
previously approved these changes
Dec 6, 2018
ahankinson
dismissed stale reviews from rosy1280, julianmorley, and zimeon
via
a66e873
zimeon
approved these changes
Dec 6, 2018
rosy1280
approved these changes
Dec 6, 2018
awoods
approved these changes
Dec 6, 2018
|
This can be merged now under the 72h rule. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #219