Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Filesystem features in implementation notes #317

Merged
merged 7 commits into from
Apr 23, 2019

Conversation

neilsjefferies
Copy link
Member

#284 and #285

draft/spec/index.html Outdated Show resolved Hide resolved
zimeon
zimeon previously requested changes Mar 6, 2019
Copy link
Contributor

@zimeon zimeon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Overall sense is good but I see a number of minor issues

draft/spec/index.html Outdated Show resolved Hide resolved
draft/spec/index.html Outdated Show resolved Hide resolved
draft/spec/index.html Outdated Show resolved Hide resolved
draft/spec/index.html Outdated Show resolved Hide resolved
draft/spec/index.html Outdated Show resolved Hide resolved
draft/spec/index.html Outdated Show resolved Hide resolved
draft/spec/index.html Outdated Show resolved Hide resolved
draft/spec/index.html Outdated Show resolved Hide resolved
Copy link
Contributor

@rosy1280 rosy1280 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

agree with the requested changes. will approve once they are made.

@ahankinson ahankinson changed the title Neilsjefferies filesystem features Filesystem features in implementation notes Mar 20, 2019
Andrew Woods added 3 commits April 3, 2019 14:57
* Code review editorial updates

* Remove normative text regarding Unicode and case-sensitivity, per code review comments
@rosy1280 rosy1280 dismissed zimeon’s stale review April 12, 2019 13:49

updates made, time to re-review

rosy1280
rosy1280 previously approved these changes Apr 12, 2019
draft/spec/index.html Show resolved Hide resolved
draft/spec/index.html Outdated Show resolved Hide resolved
draft/spec/index.html Outdated Show resolved Hide resolved
draft/spec/index.html Show resolved Hide resolved
draft/spec/index.html Show resolved Hide resolved
draft/spec/index.html Show resolved Hide resolved
awoods
awoods previously approved these changes Apr 14, 2019
@awoods awoods dismissed stale reviews from rosy1280 and themself via f57a85b April 22, 2019 14:03
@julianmorley julianmorley merged commit bc854bf into master Apr 23, 2019
@julianmorley julianmorley deleted the neilsjefferies-filesystem-features branch April 23, 2019 16:21
@zimeon zimeon mentioned this pull request Apr 27, 2019
@zimeon zimeon mentioned this pull request May 7, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

7 participants