-
Notifications
You must be signed in to change notification settings - Fork 14
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Filesystem features in implementation notes #317
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ahankinson
reviewed
Mar 6, 2019
zimeon
previously requested changes
Mar 6, 2019
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Overall sense is good but I see a number of minor issues
birkland
reviewed
Mar 7, 2019
rosy1280
reviewed
Mar 13, 2019
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
agree with the requested changes. will approve once they are made.
ahankinson
changed the title
Neilsjefferies filesystem features
Filesystem features in implementation notes
Mar 20, 2019
…e review comments
* Code review editorial updates * Remove normative text regarding Unicode and case-sensitivity, per code review comments
rosy1280
requested review from
zimeon,
rosy1280,
ahankinson,
julianmorley and
awoods
April 12, 2019 13:44
rosy1280
previously approved these changes
Apr 12, 2019
ahankinson
suggested changes
Apr 12, 2019
awoods
previously approved these changes
Apr 14, 2019
…om/ocfl/spec into neilsjefferies-filesystem-features
zimeon
approved these changes
Apr 22, 2019
ahankinson
approved these changes
Apr 23, 2019
awoods
approved these changes
Apr 23, 2019
rosy1280
approved these changes
Apr 23, 2019
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
#284 and #285