Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Inventory version must match object version #479

Merged
merged 1 commit into from
Jun 16, 2020
Merged

Inventory version must match object version #479

merged 1 commit into from
Jun 16, 2020

Conversation

zimeon
Copy link
Contributor

@zimeon zimeon commented Jun 15, 2020

Fixes #475

neilsjefferies
neilsjefferies requested changes Jun 15, 2020
View reviewed changes
Copy link
Member

@neilsjefferies neilsjefferies left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

[the type value] -> the [type value]

@zimeon
Copy link
Contributor Author

zimeon commented Jun 15, 2020

@neilsjefferies the change of text from the spec to error is from "this" to "the type value", so don't we want all three words in [..]?

@julianmorley julianmorley merged commit ea98b81 into master Jun 16, 2020
@julianmorley julianmorley deleted the issue-475 branch June 16, 2020 13:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@neilsjefferies neilsjefferies neilsjefferies approved these changes

@julianmorley julianmorley julianmorley approved these changes

@ahankinson ahankinson ahankinson approved these changes

@awoods awoods awoods approved these changes

@rosy1280 rosy1280 rosy1280 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Object and inventory versioning
6 participants
@zimeon @rosy1280 @awoods @ahankinson @julianmorley @neilsjefferies