Additional MUSTs re manifest keys #561
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
zimeon
requested review from
rosy1280,
awoods,
julianmorley and
neilsjefferies
rosy1280
reviewed
Sep 28, 2021
rosy1280
previously approved these changes
Sep 29, 2021
neilsjefferies
previously approved these changes
Oct 1, 2021
awoods
requested changes
Oct 3, 2021
|
As expected, there is a (trivial) merge conflict. |
|
Have fixed merge conflict as well as addressing the error @awoods found |
awoods
requested changes
Oct 3, 2021
awoods
approved these changes
Oct 3, 2021
neilsjefferies
approved these changes
Oct 4, 2021
rosy1280
approved these changes
Oct 5, 2021
julianmorley
approved these changes
Oct 5, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Part 1 of #537
(Will conflict with #560 so merge that first and then fix this)